From: Deepak R Varma <mh12gx2825@gmail.com>
To: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
daniel.baluta@gmail.com, kieran.bingham@ideasonboard.com
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v4] media: staging/intel-ipu3: css: simplify expression
Date: Mon, 23 Mar 2020 00:49:03 +0530 [thread overview]
Message-ID: <20200322191859.GA13840@deeUbuntu> (raw)
An array index computed inside square brackets complicates the code
and also extends the line beyond 80 character. Add new variable to
compute array index separately and use it as an index during assignment.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
Changes since v3:
1. Removed extra 'i' alongside word PATCH in the subject line
2. Removed extra curly braces that are no more needed post
implemented changes. Pointed out by Stefano.
Changes since v2:
- Added feedback from Julia
1. Rephrase patch description to make it concise and simpler.
Changes since v1:
- Added feedback from Helen
1. Updated variable type to "unsigned int" from earlier "int"
2. Implemented the change in another area in same scope
3. Left newly added variable uninitialised.
drivers/staging/media/ipu3/ipu3-css-params.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index 4533dacad4be..cc526c57248c 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -49,14 +49,13 @@ imgu_css_scaler_setup_lut(unsigned int taps, unsigned int input_width,
int tap, phase, phase_sum_left, phase_sum_right;
int exponent = imgu_css_scaler_get_exp(output_width, input_width);
int mantissa = (1 << exponent) * output_width;
- unsigned int phase_step;
+ unsigned int phase_step, phase_taps;
if (input_width == output_width) {
for (phase = 0; phase < IMGU_SCALER_PHASES; phase++) {
- for (tap = 0; tap < taps; tap++) {
- coeff_lut[phase * IMGU_SCALER_FILTER_TAPS + tap]
- = 0;
- }
+ phase_taps = phase * IMGU_SCALER_FILTER_TAPS;
+ for (tap = 0; tap < taps; tap++)
+ coeff_lut[phase_taps + tap] = 0;
}
info->phase_step = IMGU_SCALER_PHASES *
@@ -82,8 +81,8 @@ imgu_css_scaler_setup_lut(unsigned int taps, unsigned int input_width,
coeff += 1 << (IMGU_SCALER_COEFF_BITS - 1);
coeff >>= IMGU_SCALER_COEFF_BITS;
- coeff_lut[phase * IMGU_SCALER_FILTER_TAPS + tap] =
- coeff;
+ phase_taps = phase * IMGU_SCALER_FILTER_TAPS + tap;
+ coeff_lut[phase_taps] = coeff;
}
}
--
2.17.1
reply other threads:[~2020-03-22 19:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322191859.GA13840@deeUbuntu \
--to=mh12gx2825@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.