From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6806789560169660416 X-Received: by 2002:a17:902:8542:: with SMTP id d2mr19896425plo.200.1584925486577; Sun, 22 Mar 2020 18:04:46 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a17:90a:982:: with SMTP id 2ls8002195pjo.1.gmail; Sun, 22 Mar 2020 18:04:45 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsSTUdfEbsB+ImgzKyMD1GPxgwF9bTJHBf9hn3cejl6O3oe2Qm0dk6chzjoqSERC5Xn3A3B X-Received: by 2002:a17:90a:26e3:: with SMTP id m90mr22934892pje.144.1584925485083; Sun, 22 Mar 2020 18:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584925485; cv=none; d=google.com; s=arc-20160816; b=YR7DmkXrIfGQQdjhdAXRpwz/iQgRtNuvjBXkGct8asaUMm7s4Cfwkcfl1NRskBOeEP 3NGsGzLJY2DVauCK/dVEeAeq6RwEvzRqNJJA2FN+m0jK92ExnPUygdvegnS9wzCIMLqS ViiEQ5gM+2VusbJVtNFJXcvCw2eK/XxEMmxNeZxcz+CH9ktAPGIZyw1+vIIY69/s+1GM YAuAtqyMVnIq3cO4KjL+iqqSR66S+G987auG/BNVYSsZHNhPsEwPbkHhBR1YOzefbRnf 7pWcLPJIj7LvYNvy4ZaaxfkmBx05R8+4DgtTEaHyz6ov6z9Iy1JGawXrh8Njn+Mfxs0T C5AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=aG1HR6vnX9d/puzieVgxoR5+qeHzgld0YjOlInXM12g=; b=i3uG9trOFOkFJTbNV+EX4cRf52Y19uxDuw1xRn8gWpcJ8lix98+lHMcMsdN9FbG4Iu DVp3NK1Y190tD8v2qO7wJAetPPyceLbNvzQRgqZSxLL6sMkBUmH6Kgmg2VBZGdsEFds4 u1cuWjEgqNPz48VKmpaxCVI1fzP/5sGHYe4q9yzcjU4dky0sy32MhnYFZxhr1PACgfpv /7t65i2vXljUkEaeSUkhHefQg3yuLMrJNBd27HxgNdmDMUGOSmlqS8V17oMg8q4yy3DD G8Lp7X4yFu1GgQh6bdtjMk+b4vbFlcMlE9hGRc+K35fGToDs+wUDx26wly52ndtGmT4E IPvg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LD++SuMv; spf=pass (google.com: domain of sbrivio@redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=sbrivio@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com. [216.205.24.74]) by gmr-mx.google.com with ESMTPS id c10si1048313pjo.2.2020.03.22.18.04.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Mar 2020 18:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of sbrivio@redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LD++SuMv; spf=pass (google.com: domain of sbrivio@redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=sbrivio@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584925483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aG1HR6vnX9d/puzieVgxoR5+qeHzgld0YjOlInXM12g=; b=LD++SuMv10RwYBDj1gQIezbJWyURhrso8rcrcNwZmBJcTC454eEXcY+duP3bQmGd0vIzJD wTj/6PwpTmRYPsgwbTMU1hbVJSIiXD0SQNrutBXVSC+crVAsXoe8ISLcPXIwn7P15GzE9S ba0aLQoG/D8Nz9TEZBdjq+2M/un9cFU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-gkMjLTdKPYCXVIHRwbB7lA-1; Sun, 22 Mar 2020 21:04:40 -0400 X-MC-Unique: gkMjLTdKPYCXVIHRwbB7lA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25360107ACCC; Mon, 23 Mar 2020 01:04:38 +0000 (UTC) Received: from elisabeth (unknown [10.40.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E23960BF1; Mon, 23 Mar 2020 01:04:33 +0000 (UTC) Date: Mon, 23 Mar 2020 02:04:25 +0100 From: Stefano Brivio To: Shreeya Patel Cc: Joe Perches , Greg KH , Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators Message-ID: <20200323020425.62dbeebb@elisabeth> In-Reply-To: References: <19950c71482b3be0dd9518398af85e964f3b66b1.1584826154.git.shreeya.patel23498@gmail.com> <20200322112744.GC75383@kroah.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Hi Shreeya, On Mon, 23 Mar 2020 04:48:08 +0530 Shreeya Patel wrote: > On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote: > > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote: > > Hi Greg and Joe, > > > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote: > > > > Add space around operators for improving the code > > > > readability. > > > > Reported by checkpatch.pl > > > > > > > > git diff -w shows no difference. > > > > diff of the .o files before and after the changes shows no > > > > difference. > > > > > > There is no need to have these two lines on every changelog comment > > > in > > > this series :( > > > Yes I get that. > > > In my opinion, there's no need for a series here. > > > > Whitespace only changes _should_ be done all at once. > > > > Whitespace changes _could_ have changed string constants. > > > > So noting that the patch in only whitespace and that > > there isn't a difference in object files is useful as > > it shows any change has been compiled and tested. > > > > Joe, I feel the same thing, there is no need of a patch series > for it but I was given a suggestion that it becomes difficult for the > reviewers to review the patch so it is good to send a patchset instead. In this case, reviewing the 224 lines you're touching in one shot feels the same as reviewing them over 11 patches, as the change is always of the same type. Maybe a single patch is actually even a bit quicker to review. Are you sure the suggestion was referring to this, and it wasn't about different type of changes in the same patch? -- Stefano