From: Jaegeuk Kim <jaegeuk@kernel.org>
To: John <graysky@archlinux.us>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] fstrim does not recognize FSVER=1.13 of F2FS partitions
Date: Sun, 22 Mar 2020 21:11:43 -0700 [thread overview]
Message-ID: <20200323041143.GC147648@google.com> (raw)
In-Reply-To: <CAO_nJAYTbPqWKAnG1+i2J1jnEKN6QtiMV_CxVyranZ-AWK9Agg@mail.gmail.com>
On 03/18, John wrote:
> On Mon, Mar 16, 2020 at 9:44 PM Chao Yu <yuchao0@huawei.com> wrote:
> >
> > On 2020/3/16 17:52, John wrote:
> > > On Sun, Mar 15, 2020 at 9:24 PM Chao Yu <yuchao0@huawei.com> wrote:
> > >>
> > >> What's your mount option and mkfs option on those two partitions, and what's
> > >> your kernel version?
> > >
> > > I am mounting the partitions with systemd like so (/etc/fstab entry):
> > > LABEL=incoming /incoming f2fs noauto,x-systemd.automount 0 0
> > >
> > > But I can reproduce this if I totally remove the entries within
> > > /etc/fstab, reboot, and mount manually like this:
> > > mount LABEL=incoming /incoming
> >
> > However, the directory where you trigger trim is "/mnt/media"?
> >
> > Quoted:
> > "Invoking it manually on the newer one gives this:
> > # fstrim -v /mnt/media
> > fstrim: /mnt/media: the discard operation is not supported"
Hmm, could you share cat /proc/mounts?
> >
> > Could you give more details about that? What device is behind /mnt/media?
>
> The SSD has two partitions on it formatted to F2FS.
> LABEL=incoming was created with f2fs-tools v1.12.0
> LABEL=media was created with f2fs-tools v1.13.0
>
> The physical device is a Samsung 860 EVO 2TB SSD.
>
> > > Inspecting my shell history, I created them both with this command:
> > > mkfs.f2fs -l incoming /dev/sdb2
> > >
> > > I am running 5.5.9 on Arch Linux, but I believe I experienced this
> > > under previous 5.5.x series as well.
> > >
> > > If you create a F2FS partition using the latest stable release of
> > > f2fs-tools (1.13.0) are you able to reproduce the inability to trim?
> >
> > I can't, and also there is such option in mkfs to disable trim functionality
> > during format.
> >
>
> I might be misunderstanding. When you said "I can't" does that mean
> when you created a partition with f2fstools v1.13.0, mounted it, and
> then ran the fstrim on it, fstrim completed successfully? Which
> version of fstrim do you have installed? I am using util-linux
> 2.35.1.
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-03-23 4:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 18:09 [f2fs-dev] fstrim does not recognize FSVER=1.13 of F2FS partitions John
2020-03-16 1:24 ` Chao Yu
2020-03-16 9:52 ` John
2020-03-17 1:44 ` Chao Yu
2020-03-18 20:25 ` John
2020-03-23 4:11 ` Jaegeuk Kim [this message]
2020-03-23 10:27 ` John
2020-03-23 15:02 ` Jaegeuk Kim
2020-03-23 20:12 ` John
2020-03-24 2:32 ` Chao Yu
[not found] ` <CAO_nJAYWQWrWaQVfUmVpJGFtOeKKE76im-AkLUDTJm8DN4VAgA@mail.gmail.com>
[not found] ` <2292eb8d-8357-227f-5448-d1d03b33c042@huawei.com>
2020-03-25 13:58 ` John
2020-03-25 15:28 ` Jaegeuk Kim
2020-03-25 18:41 ` John
2020-03-25 19:04 ` John
2020-03-25 19:59 ` Jaegeuk Kim
2020-03-25 21:13 ` John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323041143.GC147648@google.com \
--to=jaegeuk@kernel.org \
--cc=graysky@archlinux.us \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.