From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0034DC10F26 for ; Mon, 23 Mar 2020 07:35:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF8632070A for ; Mon, 23 Mar 2020 07:35:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hsUrDrka" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF8632070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nod3M/snp5Luc/8TFcMbEYWM1n+1Yu81VNy8MvdQotM=; b=hsUrDrkaw2/M8N EhIp3fKRUGBRDN7hqh+rxBfPv4dnVB/A86uG/pMyWhVt3h66+3dRQLcKf3UTFDwT4WrxASqFlfi2J DBt1hJNv8uuujJNRvos6pcA7alOovbr/T+4qx9LNldMt2up7D1dRzThtyJPPgfoIdG9JSXIt8okxf J8Ovaz/0mUvXSLhH7A2Rw1DC3bRJ0zy3SRXxoisXez8Qp9ustN+4N4y1IcWfCsZlbtkDLcPvHtxYN kojpnc8crd9HNMH/QL/VGyzKubvO3X6CRqBEvwNxraarOhr5h1ysEYwet/INPRNlHihE3eaA5XAyF GOucnmRxJe2q321kX3Og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGHbv-0003TX-8o; Mon, 23 Mar 2020 07:34:59 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGHbr-0003S1-F9 for linux-nvme@lists.infradead.org; Mon, 23 Mar 2020 07:34:58 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9210868BEB; Mon, 23 Mar 2020 08:34:53 +0100 (CET) Date: Mon, 23 Mar 2020 08:34:53 +0100 From: Christoph Hellwig To: Israel Rukshin Subject: Re: [PATCH 6/6] nvme-tcp: Add warning on state change failure at nvme_tcp_setup_ctrl Message-ID: <20200323073453.GE30302@lst.de> References: <1584899989-14623-1-git-send-email-israelr@mellanox.com> <1584899989-14623-7-git-send-email-israelr@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1584899989-14623-7-git-send-email-israelr@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_003455_677345_9FF9E05F X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shlomi Nimrodi , Max Gurtovoy , Sagi Grimberg , Linux-nvme , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, Mar 22, 2020 at 07:59:49PM +0200, Israel Rukshin wrote: > The transition to LIVE state should not fail in case of a new controller. > Moving to DELETING state before nvme_tcp_create_ctrl() allocates all the > resources may leads to NULL dereference at teardown flow (e.g., IO tagset, > admin_q, connect_q). > > Signed-off-by: Israel Rukshin > Reviewed-by: Max Gurtovoy Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme