From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 432B9C4332B for ; Mon, 23 Mar 2020 13:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 094B22072D for ; Mon, 23 Mar 2020 13:53:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FiUrOegi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbgCWNx0 (ORCPT ); Mon, 23 Mar 2020 09:53:26 -0400 Received: from merlin.infradead.org ([205.233.59.134]:32896 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728446AbgCWNxZ (ORCPT ); Mon, 23 Mar 2020 09:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VsIacH7Sh5ef5u7EkjMPFVRuVS0DilbeeeCgQ0sPI44=; b=FiUrOegiyOvXBT6Nfm8LsKf0Gm IXdL81FdMFoF79HlVotHj14oAK5hYrXAKwX7avJu8bwtdyHuKyyOQHdcdUuME/6hgCkNmmqmiHE5T TCIIrsfcBOB2ogWKrjRxSqBAlQ6d61Tb1SWThZRRzzcneR4GBtPtYQz+UCtVEOjlPf16TyNQtM+ja D/S8ZqYYwfwk1jiElMptRcPwAaqK8Pv5/qUJIkvIS/39dzsNYpri+KDaODXiEeJjjhn/CMx6Stxu1 29nEijYDIjPN1Y6MdxCUqp3tTQQM/B1j2LNovQajv6QMv6A/4zNBdM5vpvLrilGyTuwlk+Cli7eve z4zR1eAA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGNW7-0006OW-6A; Mon, 23 Mar 2020 13:53:23 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id B50AB983504; Mon, 23 Mar 2020 14:53:20 +0100 (CET) Date: Mon, 23 Mar 2020 14:53:20 +0100 From: Peter Zijlstra To: Frederic Weisbecker Cc: LKML , Sebastian Andrzej Siewior , "Paul E . McKenney" , Thomas Gleixner Subject: Re: [RFC PATCH 1/3] lockdep/irq: Be more strict about IRQ-threadable code end Message-ID: <20200323135320.GJ2452@worktop.programming.kicks-ass.net> References: <20200323033207.32370-1-frederic@kernel.org> <20200323033207.32370-2-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200323033207.32370-2-frederic@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2020 at 04:32:05AM +0100, Frederic Weisbecker wrote: > --- a/kernel/irq/handle.c > +++ b/kernel/irq/handle.c > @@ -144,18 +144,24 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags > > for_each_action_of_desc(desc, action) { > irqreturn_t res; > + bool threadable; > > /* > * If this IRQ would be threaded under force_irqthreads, mark it so. > */ > - if (irq_settings_can_thread(desc) && > - !(action->flags & (IRQF_NO_THREAD | IRQF_PERCPU | IRQF_ONESHOT))) > + threadable = (irq_settings_can_thread(desc) && > + !(action->flags & (IRQF_NO_THREAD | IRQF_PERCPU | IRQF_ONESHOT))); > + > + if (threadable) > trace_hardirq_threaded(); > > trace_irq_handler_entry(irq, action); > res = action->handler(irq, action->dev_id); > trace_irq_handler_exit(irq, action, res); > > + if (threadable) > + trace_hardirq_unthreaded(); AFAICT this doesn't work for nested IRQ handlers. > if (WARN_ONCE(!irqs_disabled(),"irq %u handler %pS enabled interrupts\n", > irq, action->handler)) > local_irq_disable(); > -- > 2.25.0 >