From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey.Semin@baikalelectronics.ru
Cc: Hoan Tran <hoan@os.amperecomputing.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Allison Randal <allison@lohutok.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] gpio: dwapb: Add debounce reference clock support
Date: Mon, 23 Mar 2020 20:38:37 +0200 [thread overview]
Message-ID: <20200323183837.GV1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200323180632.14119-6-Sergey.Semin@baikalelectronics.ru>
On Mon, Mar 23, 2020 at 09:06:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> Aside from the APB reference clock DW GPIO controller can have a
> dedicated clock connected to setup a debounce time interval for
> GPIO-based IRQs. Since this functionality is optional the corresponding
> clock source is also optional. Due to this lets handle the debounce
> clock in the same way as it has been developed for the APB reference
> clock, but using the bulk request/enable-disable methods.
> + if (err) {
> + dev_err(gpio->dev, "Cannot reenable APB/Debounce clocks\n");
> + return err;
> + }
Yeah, this should be a separate change.
Otherwise looks good.
Also, did I miss the documentation update (bindings)?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-23 18:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:24 [PATCH 0/4] gpio: dwapb: Fix reference clocks usage Sergey.Semin
2020-03-12 13:58 ` Linus Walleij
2020-03-13 15:29 ` Sergey Semin
2020-03-23 18:06 ` [PATCH v2 0/6] " Sergey.Semin
2020-03-23 18:06 ` [PATCH v2 1/6] dt-bindings: gpio: Convert snps,dw-apb-gpio to DT schema Sergey.Semin
2020-03-23 18:06 ` [PATCH v2 2/6] dt-bindings: gpio: Add DW GPIO debounce clock property Sergey.Semin
2020-03-23 18:06 ` [PATCH v2 3/6] dt-bindings: gpio: Add Sergey Semin to DW APB GPIO driver maintainers Sergey.Semin
2020-03-23 18:06 ` [PATCH v2 4/6] gpio: dwapb: Use optional-clocks interface for APB ref-clock Sergey.Semin
2020-03-23 18:36 ` Andy Shevchenko
2020-03-23 18:06 ` [PATCH v2 5/6] gpio: dwapb: Add debounce reference clock support Sergey.Semin
2020-03-23 18:38 ` Andy Shevchenko [this message]
2020-03-23 19:25 ` Sergey Semin
2020-03-23 21:37 ` Andy Shevchenko
2020-03-23 18:06 ` [PATCH v2 6/6] MAINTAINERS: Add Segey Semin to maintainers of DW APB GPIO driver Sergey.Semin
2020-03-23 18:34 ` Andy Shevchenko
2020-03-23 19:18 ` Sergey Semin
2020-03-23 18:36 ` Joe Perches
2020-03-23 19:16 ` Sergey Semin
2020-03-23 18:41 ` Andy Shevchenko
2020-03-23 19:43 ` Sergey Semin
2020-03-23 19:53 ` [PATCH v3 0/6] gpio: dwapb: Fix reference clocks usage Sergey.Semin
2020-03-23 19:53 ` [PATCH v3 1/6] dt-bindings: gpio: Convert snps,dw-apb-gpio to DT schema Sergey.Semin
2020-03-31 19:24 ` Rob Herring
2020-03-23 19:53 ` [PATCH v3 2/6] dt-bindings: gpio: Add DW GPIO debounce clock property Sergey.Semin
2020-03-23 19:53 ` [PATCH v3 3/6] dt-bindings: gpio: Add Sergey Semin to DW APB GPIO driver maintainers Sergey.Semin
2020-03-31 19:25 ` Rob Herring
2020-03-23 19:53 ` [PATCH v3 4/6] gpio: dwapb: Use optional-clocks interface for APB ref-clock Sergey.Semin
2020-03-23 19:54 ` [PATCH v3 5/6] gpio: dwapb: Add debounce reference clock support Sergey.Semin
2020-03-23 19:54 ` [PATCH v3 6/6] MAINTAINERS: Add Segey Semin to maintainers of DW APB GPIO driver Sergey.Semin
2020-03-23 21:39 ` [PATCH v3 0/6] gpio: dwapb: Fix reference clocks usage Andy Shevchenko
2020-04-15 21:27 ` [PATCH 0/4] " Linus Walleij
2020-04-16 5:09 ` Sergey Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323183837.GV1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=allison@lohutok.net \
--cc=bgolaszewski@baylibre.com \
--cc=fancer.lancer@gmail.com \
--cc=hoan@os.amperecomputing.com \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.