Re: [PATCH 1/2 v1] dt-bindings: touchscreen: Add CY8CTMA140 bindings

[Rob Herring <robh@kernel.org>]

On Tue, Mar 10, 2020 at 03:28:17PM +0100, Linus Walleij wrote:
> This adds device tree bindings for the Cypress CY8CTMA140
> touchscreen.
> 
> Cc: devicetree@vger.kernel.org
> Cc: Ferruh Yigit <fery@cypress.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../input/touchscreen/cypress,cy8ctma140.yaml | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.yaml
> new file mode 100644
> index 000000000000..66b488e48b74
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/cypress,cy8ctma140.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cypress CY8CTMA140 series touchscreen controller bindings
> +
> +maintainers:
> +  - Linus Walleij <linus.walleij@linaro.org>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    const: cypress,cy8ctma140
> +
> +  reg:
> +    description: I2C client address, defined by hardware

Can drop this. That's every 'reg'.

> +    const: 0x20
> +
> +  clock-frequency:
> +    description: I2C client max frequency, defined by hardware
> +    const: 400000

What if I have a board which can't do 400k? Perhaps 'maximum: 400000' 
instead.

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vcpin-supply:
> +    description: Analog power supply regulator on VCPIN pin
> +
> +  vdd-supply:
> +    description: Digital power supply regulator on VDD pin
> +
> +  touchscreen-inverted-x: true
> +  touchscreen-inverted-y: true
> +  touchscreen-size-x: true
> +  touchscreen-size-y: true
> +  touchscreen-swapped-x-y: true
> +  touchscreen-max-pressure: true
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - touchscreen-size-x
> +  - touchscreen-size-y
> +  - touchscreen-max-pressure
> +
> +examples:
> +- |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c@00000000 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      touchscreen@20 {
> +        compatible = "cypress,cy8ctma140";
> +        reg = <0x20>;
> +        touchscreen-size-x = <480>;
> +        touchscreen-size-y = <800>;
> +        touchscreen-max-pressure = <255>;
> +        interrupt-parent = <&gpio6>;
> +        interrupts = <26 IRQ_TYPE_EDGE_FALLING>;
> +        vdd-supply = <&ab8500_ldo_aux2_reg>;
> +        vcpin-supply = <&ab8500_ldo_aux2_reg>;
> +      };
> +    };
> +
> +...
> -- 
> 2.21.1
>