From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEACAC54EEB for ; Tue, 24 Mar 2020 08:14:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFFD8207FF for ; Tue, 24 Mar 2020 08:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFFD8207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E96AB6E46D; Tue, 24 Mar 2020 08:14:18 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AC5B6E07D; Tue, 24 Mar 2020 07:38:32 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 287FC68BFE; Tue, 24 Mar 2020 08:38:30 +0100 (CET) Date: Tue, 24 Mar 2020 08:38:29 +0100 From: Christoph Hellwig To: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 8/9] mm/hmm: do not set pfns when returning an error code Message-ID: <20200324073829.GG23447@lst.de> References: <20200324011457.2817-1-jgg@ziepe.ca> <20200324011457.2817-9-jgg@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200324011457.2817-9-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Tue, 24 Mar 2020 08:14:14 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philip Yang , Ralph Campbell , John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , Jason Gunthorpe , amd-gfx@lists.freedesktop.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Mar 23, 2020 at 10:14:56PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > Most places that return an error code, like -EFAULT, do not set > HMM_PFN_ERROR, only two places do this. > > Resolve this inconsistency by never setting the pfns on an error > exit. This doesn't seem like a worthwhile thing to do anyhow. > > If for some reason it becomes important, it makes more sense to directly > return the address of the failing page rather than have the caller scan > for the HMM_PFN_ERROR. > > No caller inspects the pnfs output array if hmm_range_fault() fails. > > Signed-off-by: Jason Gunthorpe Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FC1C4332B for ; Tue, 24 Mar 2020 07:38:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7865220719 for ; Tue, 24 Mar 2020 07:38:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7865220719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 261C46B0006; Tue, 24 Mar 2020 03:38:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 212A86B000E; Tue, 24 Mar 2020 03:38:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 101226B0010; Tue, 24 Mar 2020 03:38:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id EC9B66B0006 for ; Tue, 24 Mar 2020 03:38:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4AA118248047 for ; Tue, 24 Mar 2020 07:38:33 +0000 (UTC) X-FDA: 76629453306.04.berry20_4aa6ba6b4f947 X-HE-Tag: berry20_4aa6ba6b4f947 X-Filterd-Recvd-Size: 1876 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 07:38:32 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 287FC68BFE; Tue, 24 Mar 2020 08:38:30 +0100 (CET) Date: Tue, 24 Mar 2020 08:38:29 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com, linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Philip Yang , Jason Gunthorpe Subject: Re: [PATCH v2 hmm 8/9] mm/hmm: do not set pfns when returning an error code Message-ID: <20200324073829.GG23447@lst.de> References: <20200324011457.2817-1-jgg@ziepe.ca> <20200324011457.2817-9-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324011457.2817-9-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 23, 2020 at 10:14:56PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > Most places that return an error code, like -EFAULT, do not set > HMM_PFN_ERROR, only two places do this. > > Resolve this inconsistency by never setting the pfns on an error > exit. This doesn't seem like a worthwhile thing to do anyhow. > > If for some reason it becomes important, it makes more sense to directly > return the address of the failing page rather than have the caller scan > for the HMM_PFN_ERROR. > > No caller inspects the pnfs output array if hmm_range_fault() fails. > > Signed-off-by: Jason Gunthorpe Looks good, Reviewed-by: Christoph Hellwig