From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF4AC41621 for ; Tue, 24 Mar 2020 15:48:19 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7989520774 for ; Tue, 24 Mar 2020 15:48:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7989520774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 59AF08694A; Tue, 24 Mar 2020 15:48:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MSjLjP8nbJdl; Tue, 24 Mar 2020 15:48:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4CE32868E4; Tue, 24 Mar 2020 15:48:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 36060C089F; Tue, 24 Mar 2020 15:48:17 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4CC59C0177 for ; Tue, 24 Mar 2020 15:48:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3371487E9C for ; Tue, 24 Mar 2020 15:48:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fuHxeYZAmLE5 for ; Tue, 24 Mar 2020 15:48:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by whitealder.osuosl.org (Postfix) with ESMTPS id E416587E8E for ; Tue, 24 Mar 2020 15:48:13 +0000 (UTC) IronPort-SDR: vtf4QN7xSqpvawnR7n8cZbMme/yvcZY+t4SkU9jzgyyBPWnvdNG6cVxTIijVjsrukPsr30RHZ1 ZwG0XONIaZ2w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2020 08:48:13 -0700 IronPort-SDR: /3TviJPiPGIiX5u5mtsR+VfG5tYCSytp+4NuPBMOSeO8k3LBM5E9P6El05mhD1Ec6Ap3qorrZv Mnn6EgS1k81A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,300,1580803200"; d="scan'208";a="393322380" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga004.jf.intel.com with ESMTP; 24 Mar 2020 08:48:13 -0700 Date: Tue, 24 Mar 2020 08:53:56 -0700 From: Jacob Pan To: Jean-Philippe Brucker Subject: Re: [PATCH 2/2] iommu/vt-d: Replace intel SVM APIs with generic SVA APIs Message-ID: <20200324085356.64f6a904@jacob-builder> In-Reply-To: <20200320092955.GA1702630@myrica> References: <1582586797-61697-1-git-send-email-jacob.jun.pan@linux.intel.com> <1582586797-61697-4-git-send-email-jacob.jun.pan@linux.intel.com> <20200320092955.GA1702630@myrica> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , Dave Jiang , Raj Ashok , Jean-Philippe Brucker , LKML , iommu@lists.linux-foundation.org, David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gRnJpLCAyMCBNYXIgMjAyMCAxMDoyOTo1NSArMDEwMApKZWFuLVBoaWxpcHBlIEJydWNrZXIg PGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz4gd3JvdGU6Cgo+IEhpIEphY29iLAo+IAo+IEkgdGhp bmsgdGhpcyBzdGVwIGlzIHJlYWxseSB1c2VmdWwgYW5kIHRoZSBwYXRjaCBsb29rcyBnb29kIG92 ZXJhbGwsCj4gdGhhbmtzIGZvciBkb2luZyB0aGlzLiBTb21lIGNvbW1tZW50cyBpbmxpbmUKPiAK PiBPbiBNb24sIEZlYiAyNCwgMjAyMCBhdCAwMzoyNjozN1BNIC0wODAwLCBKYWNvYiBQYW4gd3Jv dGU6Cj4gPiBUaGlzIHBhdGNoIGlzIGFuIGluaXRpYWwgc3RlcCB0byByZXBsYWNlIEludGVsIFNW TSBjb2RlIHdpdGggdGhlCj4gPiBmb2xsb3dpbmcgSU9NTVUgU1ZBIG9wczoKPiA+IGludGVsX3N2 bV9iaW5kX21tKCkgPT4gaW9tbXVfc3ZhX2JpbmRfZGV2aWNlKCkKPiA+IGludGVsX3N2bV91bmJp bmRfbW0oKSA9PiBpb21tdV9zdmFfdW5iaW5kX2RldmljZSgpCj4gPiBpbnRlbF9zdm1faXNfcGFz aWRfdmFsaWQoKSA9PiBpb21tdV9zdmFfZ2V0X3Bhc2lkKCkKPiA+IAo+ID4gVGhlIGZlYXR1cmVz IGJlbG93IHdpbGwgY29udGludWUgdG8gd29yayBidXQgYXJlIG5vdCBpbmNsdWRlZCBpbgo+ID4g dGhpcyBwYXRjaCBpbiB0aGF0IHRoZXkgYXJlIGhhbmRsZWQgbW9zdGx5IHdpdGhpbiB0aGUgSU9N TVUKPiA+IHN1YnN5c3RlbS4KPiA+IC0gSU8gcGFnZSBmYXVsdAo+ID4gLSBtbXUgbm90aWZpZXIK PiA+IAo+ID4gQ29uc29saWRhdGlvbiBvZiB0aGUgYWJvdmUgd2lsbCBjb21lIGFmdGVyIG1lcmdp bmcgZ2VuZXJpYyBJT01NVSBzdmEKPiA+IGNvZGVbMV0uIFRoZXJlIHNob3VsZCBub3QgYmUgYW55 IGNoYW5nZXMgbmVlZGVkIGZvciBTVkEgdXNlcnMgc3VjaAo+ID4gYXMgYWNjZWxlcmF0b3IgZGV2 aWNlIGRyaXZlcnMgZHVyaW5nIHRoaXMgdGltZS4KPiA+IAo+ID4gWzFdIGh0dHA6Ly9qcGJydWNr ZXIubmV0L3N2YS8KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogSmFjb2IgUGFuIDxqYWNvYi5qdW4u cGFuQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvaW9tbXUvaW50ZWwtaW9t bXUuYyB8ICAgMyArKwo+ID4gIGRyaXZlcnMvaW9tbXUvaW50ZWwtc3ZtLmMgICB8IDEyMwo+ID4g KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IGluY2x1ZGUv bGludXgvaW50ZWwtaW9tbXUuaCB8ICAgNyArKysgaW5jbHVkZS9saW51eC9pbnRlbC1zdm0uaAo+ ID4gfCAgODUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIDQgZmlsZXMgY2hhbmdlZCwg NzgKPiA+IGluc2VydGlvbnMoKyksIDE0MCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvaW9tbXUvaW50ZWwtaW9tbXUuYwo+ID4gYi9kcml2ZXJzL2lvbW11L2ludGVs LWlvbW11LmMgaW5kZXggNWVjYTZlMTBkMmE0Li5jY2ZhNWFkZmQwNmQKPiA+IDEwMDY0NCAtLS0g YS9kcml2ZXJzL2lvbW11L2ludGVsLWlvbW11LmMKPiA+ICsrKyBiL2RyaXZlcnMvaW9tbXUvaW50 ZWwtaW9tbXUuYwo+ID4gQEAgLTY0NzUsNiArNjQ3NSw5IEBAIGNvbnN0IHN0cnVjdCBpb21tdV9v cHMgaW50ZWxfaW9tbXVfb3BzID0gewo+ID4gIAkuY2FjaGVfaW52YWxpZGF0ZQk9IGludGVsX2lv bW11X3N2YV9pbnZhbGlkYXRlLAo+ID4gIAkuc3ZhX2JpbmRfZ3Bhc2lkCT0gaW50ZWxfc3ZtX2Jp bmRfZ3Bhc2lkLAo+ID4gIAkuc3ZhX3VuYmluZF9ncGFzaWQJPSBpbnRlbF9zdm1fdW5iaW5kX2dw YXNpZCwKPiA+ICsJLnN2YV9iaW5kCQk9IGludGVsX3N2bV9iaW5kLAo+ID4gKwkuc3ZhX3VuYmlu ZAkJPSBpbnRlbF9zdm1fdW5iaW5kLAo+ID4gKwkuc3ZhX2dldF9wYXNpZAkJPSBpbnRlbF9zdm1f Z2V0X3Bhc2lkLAo+ID4gICNlbmRpZgo+ID4gIH07Cj4gPiAgCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9pb21tdS9pbnRlbC1zdm0uYyBiL2RyaXZlcnMvaW9tbXUvaW50ZWwtc3ZtLmMKPiA+IGlu ZGV4IDFkN2E5NTM3MmY4Yy4uMzVkOTQ5NTEzNzI4IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9p b21tdS9pbnRlbC1zdm0uYwo+ID4gKysrIGIvZHJpdmVycy9pb21tdS9pbnRlbC1zdm0uYwo+ID4g QEAgLTUxNiwxMyArNTE2LDE0IEBAIGludCBpbnRlbF9zdm1fdW5iaW5kX2dwYXNpZChzdHJ1Y3Qg ZGV2aWNlCj4gPiAqZGV2LCBpbnQgcGFzaWQpIHJldHVybiByZXQ7Cj4gPiAgfQo+ID4gIAo+ID4g LWludCBpbnRlbF9zdm1fYmluZF9tbShzdHJ1Y3QgZGV2aWNlICpkZXYsIGludCAqcGFzaWQsIGlu dCBmbGFncywKPiA+IHN0cnVjdCBzdm1fZGV2X29wcyAqb3BzKSArLyogQ2FsbGVyIG11c3QgaG9s ZCBwYXNpZF9tdXRleCwgbW0KPiA+IHJlZmVyZW5jZSAqLyArc3RhdGljIGludCBpbnRlbF9zdm1f YmluZF9tbShzdHJ1Y3QgZGV2aWNlICpkZXYsIGludAo+ID4gZmxhZ3MsIHN0cnVjdCBzdm1fZGV2 X29wcyAqb3BzLAo+ID4gKwkJICAgICAgc3RydWN0IG1tX3N0cnVjdCAqbW0sIHN0cnVjdCBpbnRl bF9zdm1fZGV2Cj4gPiAqKnNkKSB7Cj4gPiAgCXN0cnVjdCBpbnRlbF9pb21tdSAqaW9tbXUgPSBp bnRlbF9zdm1fZGV2aWNlX3RvX2lvbW11KGRldik7Cj4gPiAgCXN0cnVjdCBkZXZpY2VfZG9tYWlu X2luZm8gKmluZm87Cj4gPiAgCXN0cnVjdCBpbnRlbF9zdm1fZGV2ICpzZGV2Owo+ID4gIAlzdHJ1 Y3QgaW50ZWxfc3ZtICpzdm0gPSBOVUxMOwo+ID4gLQlzdHJ1Y3QgbW1fc3RydWN0ICptbSA9IE5V TEw7Cj4gPiAgCWludCBwYXNpZF9tYXg7Cj4gPiAgCWludCByZXQ7Cj4gPiAgCj4gPiBAQCAtNTM5 LDE2ICs1NDAsMTUgQEAgaW50IGludGVsX3N2bV9iaW5kX21tKHN0cnVjdCBkZXZpY2UgKmRldiwg aW50Cj4gPiAqcGFzaWQsIGludCBmbGFncywgc3RydWN0IHN2bV9kZXZfIH0gZWxzZQo+ID4gIAkJ cGFzaWRfbWF4ID0gMSA8PCAyMDsKPiA+ICAKPiA+ICsJLyogQmluZCBzdXBlcnZpc29yIFBBU0lE IHNodWxkIGhhdmUgbW0gPSBOVUxMICovICAKPiAKPiBzaG91bGQKPiAKPiA+ICAJaWYgKGZsYWdz ICYgU1ZNX0ZMQUdfU1VQRVJWSVNPUl9NT0RFKSB7Cj4gPiAtCQlpZiAoIWVjYXBfc3JzKGlvbW11 LT5lY2FwKSkKPiA+ICsJCWlmICghZWNhcF9zcnMoaW9tbXUtPmVjYXApIHx8IG1tKSB7Cj4gPiAr CQkJcHJfZXJyKCJTdXBlcnZpc29yIFBBU0lEIHdpdGggdXNlcgo+ID4gcHJvdmlkZWQgbW0uXG4i KTsgcmV0dXJuIC1FSU5WQUw7Cj4gPiAtCX0gZWxzZSBpZiAocGFzaWQpIHsKPiA+IC0JCW1tID0g Z2V0X3Rhc2tfbW0oY3VycmVudCk7Cj4gPiAtCQlCVUdfT04oIW1tKTsKPiA+ICsJCX0KPiA+ICAJ fQo+ID4gIAo+ID4gLQltdXRleF9sb2NrKCZwYXNpZF9tdXRleCk7Cj4gPiAtCWlmIChwYXNpZCAm JiAhKGZsYWdzICYgU1ZNX0ZMQUdfUFJJVkFURV9QQVNJRCkpIHsKPiA+ICsJaWYgKCEoZmxhZ3Mg JiBTVk1fRkxBR19QUklWQVRFX1BBU0lEKSkgewo+ID4gIAkJc3RydWN0IGludGVsX3N2bSAqdDsK PiA+ICAKPiA+ICAJCWxpc3RfZm9yX2VhY2hfZW50cnkodCwgJmdsb2JhbF9zdm1fbGlzdCwgbGlz dCkgewo+ID4gQEAgLTU4Niw5ICs1ODYsNyBAQCBpbnQgaW50ZWxfc3ZtX2JpbmRfbW0oc3RydWN0 IGRldmljZSAqZGV2LCBpbnQKPiA+ICpwYXNpZCwgaW50IGZsYWdzLCBzdHJ1Y3Qgc3ZtX2Rldl8g c2Rldi0+ZGV2ID0gZGV2Owo+ID4gIAo+ID4gIAlyZXQgPSBpbnRlbF9pb21tdV9lbmFibGVfcGFz aWQoaW9tbXUsIGRldik7Cj4gPiAtCWlmIChyZXQgfHwgIXBhc2lkKSB7Cj4gPiAtCQkvKiBJZiB0 aGV5IGRvbid0IGFjdHVhbGx5IHdhbnQgdG8gYXNzaWduIGEgUEFTSUQsCj4gPiB0aGlzIGlzCj4g PiAtCQkgKiBqdXN0IGFuIGVuYWJsaW5nIGNoZWNrL3ByZXBhcmF0aW9uLiAqLwo+ID4gKwlpZiAo cmV0KSB7Cj4gPiAgCQlrZnJlZShzZGV2KTsKPiA+ICAJCWdvdG8gb3V0Owo+ID4gIAl9Cj4gPiBA QCAtNjg4LDE4ICs2ODYsMTcgQEAgaW50IGludGVsX3N2bV9iaW5kX21tKHN0cnVjdCBkZXZpY2Ug KmRldiwgaW50Cj4gPiAqcGFzaWQsIGludCBmbGFncywgc3RydWN0IHN2bV9kZXZfIH0KPiA+ICAJ fQo+ID4gIAlsaXN0X2FkZF9yY3UoJnNkZXYtPmxpc3QsICZzdm0tPmRldnMpOwo+ID4gLQo+ID4g LSBzdWNjZXNzOgo+ID4gLQkqcGFzaWQgPSBzdm0tPnBhc2lkOwo+ID4gK3N1Y2Nlc3M6Cj4gPiAr CXNkZXYtPnBhc2lkID0gc3ZtLT5wYXNpZDsKPiA+ICsJc2Rldi0+c3ZhLmRldiA9IGRldjsKPiA+ ICsJaWYgKHNkKQo+ID4gKwkJKnNkID0gc2RldjsgIAo+IAo+IE9uZSB0aGluZyB0aGF0IG1pZ2h0 IGJlIG1pc3Npbmc6IGNhbGxpbmcgYmluZCgpIG11bHRpcGxlIHRpbWVzIHdpdGgKPiB0aGUgc2Ft ZSAoZGV2LCBtbSkgcGFpciBzaG91bGQgdGFrZSByZWZlcmVuY2VzIHRvIHRoZSBzdm0gc3RydWN0 LCBzbwo+IGRldmljZSBkcml2ZXJzIGNhbiBjYWxsIHVuYmluZCgpIG9uIGl0IHRoYXQgbWFueSB0 aW1lcy4KPiAKPiA+ICAJcmV0ID0gMDsKPiA+ICAgb3V0Ogo+ID4gLQltdXRleF91bmxvY2soJnBh c2lkX211dGV4KTsKPiA+IC0JaWYgKG1tKQo+ID4gLQkJbW1wdXQobW0pOwo+ID4gIAlyZXR1cm4g cmV0Owo+ID4gIH0KPiA+IC1FWFBPUlRfU1lNQk9MX0dQTChpbnRlbF9zdm1fYmluZF9tbSk7Cj4g PiAgCj4gPiArLyogQ2FsbGVyIG11c3QgaG9sZCBwYXNpZF9tdXRleCAqLwo+ID4gIGludCBpbnRl bF9zdm1fdW5iaW5kX21tKHN0cnVjdCBkZXZpY2UgKmRldiwgaW50IHBhc2lkKQo+ID4gIHsKPiA+ ICAJc3RydWN0IGludGVsX3N2bV9kZXYgKnNkZXY7Cj4gPiBAQCAtNzA3LDcgKzcwNCw2IEBAIGlu dCBpbnRlbF9zdm1fdW5iaW5kX21tKHN0cnVjdCBkZXZpY2UgKmRldiwgaW50Cj4gPiBwYXNpZCkg c3RydWN0IGludGVsX3N2bSAqc3ZtOwo+ID4gIAlpbnQgcmV0ID0gLUVJTlZBTDsKPiA+ICAKPiA+ IC0JbXV0ZXhfbG9jaygmcGFzaWRfbXV0ZXgpOwo+ID4gIAlpb21tdSA9IGludGVsX3N2bV9kZXZp Y2VfdG9faW9tbXUoZGV2KTsKPiA+ICAJaWYgKCFpb21tdSkKPiA+ICAJCWdvdG8gb3V0Owo+ID4g QEAgLTc1Myw0NSArNzQ5LDkgQEAgaW50IGludGVsX3N2bV91bmJpbmRfbW0oc3RydWN0IGRldmlj ZSAqZGV2LAo+ID4gaW50IHBhc2lkKSBicmVhazsKPiA+ICAJfQo+ID4gICBvdXQ6Cj4gPiAtCW11 dGV4X3VubG9jaygmcGFzaWRfbXV0ZXgpOwo+ID4gIAo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0K PiA+IC1FWFBPUlRfU1lNQk9MX0dQTChpbnRlbF9zdm1fdW5iaW5kX21tKTsKPiA+IC0KPiA+IC1p bnQgaW50ZWxfc3ZtX2lzX3Bhc2lkX3ZhbGlkKHN0cnVjdCBkZXZpY2UgKmRldiwgaW50IHBhc2lk KQo+ID4gLXsKPiA+IC0Jc3RydWN0IGludGVsX2lvbW11ICppb21tdTsKPiA+IC0Jc3RydWN0IGlu dGVsX3N2bSAqc3ZtOwo+ID4gLQlpbnQgcmV0ID0gLUVJTlZBTDsKPiA+IC0KPiA+IC0JbXV0ZXhf bG9jaygmcGFzaWRfbXV0ZXgpOwo+ID4gLQlpb21tdSA9IGludGVsX3N2bV9kZXZpY2VfdG9faW9t bXUoZGV2KTsKPiA+IC0JaWYgKCFpb21tdSkKPiA+IC0JCWdvdG8gb3V0Owo+ID4gLQo+ID4gLQlz dm0gPSBpb2FzaWRfZmluZChOVUxMLCBwYXNpZCwgTlVMTCk7Cj4gPiAtCWlmICghc3ZtKQo+ID4g LQkJZ290byBvdXQ7Cj4gPiAtCj4gPiAtCWlmIChJU19FUlIoc3ZtKSkgewo+ID4gLQkJcmV0ID0g UFRSX0VSUihzdm0pOwo+ID4gLQkJZ290byBvdXQ7Cj4gPiAtCX0KPiA+IC0JLyogaW5pdF9tbSBp cyB1c2VkIGluIHRoaXMgY2FzZSAqLwo+ID4gLQlpZiAoIXN2bS0+bW0pCj4gPiAtCQlyZXQgPSAx Owo+ID4gLQllbHNlIGlmIChhdG9taWNfcmVhZCgmc3ZtLT5tbS0+bW1fdXNlcnMpID4gMCkKPiA+ IC0JCXJldCA9IDE7Cj4gPiAtCWVsc2UKPiA+IC0JCXJldCA9IDA7Cj4gPiAtCj4gPiAtIG91dDoK PiA+IC0JbXV0ZXhfdW5sb2NrKCZwYXNpZF9tdXRleCk7Cj4gPiAtCj4gPiAtCXJldHVybiByZXQ7 Cj4gPiAtfQo+ID4gLUVYUE9SVF9TWU1CT0xfR1BMKGludGVsX3N2bV9pc19wYXNpZF92YWxpZCk7 Cj4gPiAgCj4gPiAgLyogUGFnZSByZXF1ZXN0IHF1ZXVlIGRlc2NyaXB0b3IgKi8KPiA+ICBzdHJ1 Y3QgcGFnZV9yZXFfZHNjIHsKPiA+IEBAIC05ODQsMyArOTQ0LDU2IEBAIHN0YXRpYyBpcnFyZXR1 cm5fdCBwcnFfZXZlbnRfdGhyZWFkKGludCBpcnEsCj4gPiB2b2lkICpkKSAKPiA+ICAJcmV0dXJu IElSUV9SRVRWQUwoaGFuZGxlZCk7Cj4gPiAgfQo+ID4gKwo+ID4gKyNkZWZpbmUgdG9faW50ZWxf c3ZtX2RldihoYW5kbGUpIGNvbnRhaW5lcl9vZihoYW5kbGUsIHN0cnVjdAo+ID4gaW50ZWxfc3Zt X2Rldiwgc3ZhKSArc3RydWN0IGlvbW11X3N2YSAqCj4gPiAraW50ZWxfc3ZtX2JpbmQoc3RydWN0 IGRldmljZSAqZGV2LCBzdHJ1Y3QgbW1fc3RydWN0ICptbSwgdm9pZAo+ID4gKmRydmRhdGEpICt7 Cj4gPiArCXN0cnVjdCBpb21tdV9zdmEgKnN2YSA9IEVSUl9QVFIoLUVJTlZBTCk7Cj4gPiArCXN0 cnVjdCBpbnRlbF9zdm1fZGV2ICpzZGV2ID0gTlVMTDsKPiA+ICsJaW50IGZsYWdzID0gMDsKPiA+ ICsJaW50IHJldDsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogVE9ETzogQ29uc29saWRhdGUgd2l0 aCBnZW5lcmljIGlvbW11LXN2YSBiaW5kIGFmdGVyIGl0Cj4gPiBpcyBtZXJnZWQuCj4gPiArCSAq IEl0IHdpbGwgcmVxdWlyZSBzaGFyZWQgU1ZNIGRhdGEgc3RydWN0dXJlcywgaS5lLgo+ID4gY29t YmluZSBpb19tbQo+ID4gKwkgKiBhbmQgaW50ZWxfc3ZtIGV0Yy4KPiA+ICsJICovCj4gPiArCWlm IChkcnZkYXRhKQo+ID4gKwkJZmxhZ3MgPSAqKGludCAqKWRydmRhdGE7ICAKPiAKPiBkcnZkYXRh IGlzIG1vcmUgZm9yIHN0b3JpbmcgZGV2aWNlIGRyaXZlciBjb250ZXh0cyB0aGF0IGNhbiBiZSBw YXNzZWQKPiB0byBpb21tdV9zdmFfb3BzLCBidXQgSSBnZXQgdGhhdCB0aGlzIGlzIHRlbXBvcmFy eS4KPiAKPiBBcyB1c3VhbCBJJ20gZHJlYWRpbmcgc3VwZXJ2aXNvciBtb2RlIG1ha2luZyBpdCBp bnRvIHRoZSBjb21tb24gQVBJLgo+IFdoYXQgYXJlIHlvdXIgcGxhbnMgcmVnYXJkaW5nIFNVUEVS VklTT1JfTU9ERSBhbmQgUFJJVkFURV9QQVNJRAo+IGZsYWdzPyAgVGhlIHByZXZpb3VzIGRpc2N1 c3Npb24gb24gdGhlIHN1YmplY3QgWzFdIGhhZCBtZSBob3BpbmcgdGhhdAo+IHlvdSBjb3VsZCBy ZXBsYWNlIHN1cGVydmlzb3IgbW9kZSB3aXRoIG5vcm1hbCBtYXBwaW5ncyAoYXV4aWxpYXJ5Cj4g ZG9tYWlucz8pIEknbSBsZXNzIHdvcnJpZWQgYWJvdXQgUFJJVkFURV9QQVNJRCwgaXQgd291bGQg anVzdCBhZGQKPiBjb21wbGV4aXR5IGludG8gdGhlIEFQSSBhbmQgaW9tbXUtc3ZhIGltcGxlbWVu dGF0aW9uLCBidXQgZG9lc24ndAo+IHJlYWxseSBoYXZlIHNlY3VyaXR5IGltcGxpY2F0aW9ucy4K PiAKPiBbMV0KPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1pb21tdS8yMDE5MDIyODIy MDQ0OS5HQTEyNjgyQGFyYWotbW9ibDEuamYuaW50ZWwuY29tLwo+IAo+ID4gKwltdXRleF9sb2Nr KCZwYXNpZF9tdXRleCk7Cj4gPiArCXJldCA9IGludGVsX3N2bV9iaW5kX21tKGRldiwgZmxhZ3Ms IE5VTEwsIG1tLCAmc2Rldik7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlzdmEgPSBFUlJfUFRSKHJl dCk7Cj4gPiArCWVsc2UgaWYgKHNkZXYpCj4gPiArCQlzdmEgPSAmc2Rldi0+c3ZhOwo+ID4gKwll bHNlCj4gPiArCQlXQVJOKCFzZGV2LCAiU1ZNIGJpbmQgc3VjY2VlZGVkIHdpdGggbm8gc2RldiFc biIpOwo+ID4gKwo+ID4gKwltdXRleF91bmxvY2soJnBhc2lkX211dGV4KTsKPiA+ICsKPiA+ICsJ cmV0dXJuIHN2YTsKPiA+ICt9Cj4gPiArCj4gPiArdm9pZCBpbnRlbF9zdm1fdW5iaW5kKHN0cnVj dCBpb21tdV9zdmEgKnN2YSkKPiA+ICt7Cj4gPiArCXN0cnVjdCBpbnRlbF9zdm1fZGV2ICpzZGV2 Owo+ID4gKwo+ID4gKwltdXRleF9sb2NrKCZwYXNpZF9tdXRleCk7Cj4gPiArCXNkZXYgPSB0b19p bnRlbF9zdm1fZGV2KHN2YSk7Cj4gPiArCWludGVsX3N2bV91bmJpbmRfbW0oc2Rldi0+ZGV2LCBz ZGV2LT5wYXNpZCk7Cj4gPiArCW11dGV4X3VubG9jaygmcGFzaWRfbXV0ZXgpOwo+ID4gK30KPiA+ ICsKPiA+ICtpbnQgaW50ZWxfc3ZtX2dldF9wYXNpZChzdHJ1Y3QgaW9tbXVfc3ZhICpzdmEpCj4g PiArewo+ID4gKwlzdHJ1Y3QgaW50ZWxfc3ZtX2RldiAqc2RldjsKPiA+ICsJaW50IHBhc2lkOwo+ ID4gKwo+ID4gKwltdXRleF9sb2NrKCZwYXNpZF9tdXRleCk7Cj4gPiArCXNkZXYgPSB0b19pbnRl bF9zdm1fZGV2KHN2YSk7Cj4gPiArCXBhc2lkID0gc2Rldi0+cGFzaWQ7Cj4gPiArCW11dGV4X3Vu bG9jaygmcGFzaWRfbXV0ZXgpOwo+ID4gKwo+ID4gKwlyZXR1cm4gcGFzaWQ7Cj4gPiArfQo+ID4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaW50ZWwtaW9tbXUuaAo+ID4gYi9pbmNsdWRlL2xp bnV4L2ludGVsLWlvbW11LmggaW5kZXggMzdjZmQzNWI3Y2NmLi4wNDQ0OTNhMTFkY2UKPiA+IDEw MDY0NCAtLS0gYS9pbmNsdWRlL2xpbnV4L2ludGVsLWlvbW11LmgKPiA+ICsrKyBiL2luY2x1ZGUv bGludXgvaW50ZWwtaW9tbXUuaAo+ID4gQEAgLTcwMiw2ICs3MDIsMTEgQEAgZXh0ZXJuIGludCBp bnRlbF9zdm1fZmluaXNoX3BycShzdHJ1Y3QKPiA+IGludGVsX2lvbW11ICppb21tdSk7IGV4dGVy biBpbnQgaW50ZWxfc3ZtX2JpbmRfZ3Bhc2lkKHN0cnVjdAo+ID4gaW9tbXVfZG9tYWluICpkb21h aW4sIHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0Cj4gPiBpb21tdV9ncGFzaWRfYmluZF9kYXRh ICpkYXRhKTsgZXh0ZXJuIGludAo+ID4gaW50ZWxfc3ZtX3VuYmluZF9ncGFzaWQoc3RydWN0IGRl dmljZSAqZGV2LCBpbnQgcGFzaWQpOyArZXh0ZXJuCj4gPiBzdHJ1Y3QgaW9tbXVfc3ZhICogK2lu dGVsX3N2bV9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0Cj4gPiBtbV9zdHJ1Y3QgKm1t LCB2b2lkICpkcnZkYXRhKTsgK2V4dGVybiB2b2lkIGludGVsX3N2bV91bmJpbmQoc3RydWN0Cj4g PiBpb21tdV9zdmEgKmhhbmRsZSk7ICtleHRlcm4gaW50IGludGVsX3N2bV9nZXRfcGFzaWQoc3Ry dWN0Cj4gPiBpb21tdV9zdmEgKmhhbmRsZSk7ICsKPiA+ICBzdHJ1Y3Qgc3ZtX2Rldl9vcHM7Cj4g PiAgCj4gPiAgc3RydWN0IGludGVsX3N2bV9kZXYgewo+ID4gQEAgLTcwOSw2ICs3MTQsOCBAQCBz dHJ1Y3QgaW50ZWxfc3ZtX2RldiB7Cj4gPiAgCXN0cnVjdCByY3VfaGVhZCByY3U7Cj4gPiAgCXN0 cnVjdCBkZXZpY2UgKmRldjsKPiA+ICAJc3RydWN0IHN2bV9kZXZfb3BzICpvcHM7Cj4gPiArCXN0 cnVjdCBpb21tdV9zdmEgc3ZhOwo+ID4gKwlpbnQgcGFzaWQ7Cj4gPiAgCWludCB1c2VyczsKPiA+ ICAJdTE2IGRpZDsKPiA+ICAJdTE2IGRldl9pb3RsYjoxOwo+ID4gZGlmZiAtLWdpdCBhL2luY2x1 ZGUvbGludXgvaW50ZWwtc3ZtLmggYi9pbmNsdWRlL2xpbnV4L2ludGVsLXN2bS5oCj4gPiBpbmRl eCBhMmMxODlhZDBiMDEuLmZiN2U3ODZkODg3NyAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvbGlu dXgvaW50ZWwtc3ZtLmgKPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvaW50ZWwtc3ZtLmgKPiA+IEBA IC02Miw4OSArNjIsNCBAQCBzdHJ1Y3Qgc3ZtX2Rldl9vcHMgewo+ID4gICAqLwo+ID4gICNkZWZp bmUgU1ZNX0ZMQUdfR1VFU1RfUEFTSUQJKDE8PDMpCj4gPiAgCj4gPiAtI2lmZGVmIENPTkZJR19J TlRFTF9JT01NVV9TVk0KPiA+IC0KPiA+IC0vKioKPiA+IC0gKiBpbnRlbF9zdm1fYmluZF9tbSgp IC0gQmluZCB0aGUgY3VycmVudCBwcm9jZXNzIHRvIGEgUEFTSUQKPiA+IC0gKiBAZGV2OglEZXZp Y2UgdG8gYmUgZ3JhbnRlZCBhY2Nlc3MKPiA+IC0gKiBAcGFzaWQ6CUFkZHJlc3MgZm9yIGFsbG9j YXRlZCBQQVNJRAo+ID4gLSAqIEBmbGFnczoJRmxhZ3MuIExhdGVyIGZvciByZXF1ZXN0aW5nIHN1 cGVydmlzb3IgbW9kZSwgZXRjLgo+ID4gLSAqIEBvcHM6CUNhbGxiYWNrcyB0byBkZXZpY2UgZHJp dmVyCj4gPiAtICoKPiA+IC0gKiBUaGlzIGZ1bmN0aW9uIGF0dGVtcHRzIHRvIGVuYWJsZSBQQVNJ RCBzdXBwb3J0IGZvciB0aGUgZ2l2ZW4KPiA+IGRldmljZS4KPiA+IC0gKiBJZiB0aGUgQHBhc2lk IGFyZ3VtZW50IGlzIG5vbi0lTlVMTCwgYSBQQVNJRCBpcyBhbGxvY2F0ZWQgZm9yCj4gPiBhY2Nl c3MKPiA+IC0gKiB0byB0aGUgTU0gb2YgdGhlIGN1cnJlbnQgcHJvY2Vzcy4KPiA+IC0gKgo+ID4g LSAqIEJ5IHVzaW5nIGEgJU5VTEwgdmFsdWUgZm9yIHRoZSBAcGFzaWQgYXJndW1lbnQsIHRoaXMg ZnVuY3Rpb24KPiA+IGNhbgo+ID4gLSAqIGJlIHVzZWQgdG8gc2ltcGx5IHZhbGlkYXRlIHRoYXQg UEFTSUQgc3VwcG9ydCBpcyBhdmFpbGFibGUgZm9yCj4gPiB0aGUKPiA+IC0gKiBnaXZlbiBkZXZp Y2Ug4oCUIGkuZS4gdGhhdCBpdCBpcyBiZWhpbmQgYW4gSU9NTVUgd2hpY2ggaGFzIHRoZQo+ID4g LSAqIHJlcXVpc2l0ZSBzdXBwb3J0LCBhbmQgaXMgZW5hYmxlZC4KPiA+IC0gKgo+ID4gLSAqIFBh Z2UgZmF1bHRzIGFyZSBoYW5kbGVkIHRyYW5zcGFyZW50bHkgYnkgdGhlIElPTU1VIGNvZGUsIGFu ZAo+ID4gdGhlcmUKPiA+IC0gKiBzaG91bGQgYmUgbm8gbmVlZCBmb3IgdGhlIGRldmljZSBkcml2 ZXIgdG8gYmUgaW52b2x2ZWQuIElmIGEKPiA+IHBhZ2UKPiA+IC0gKiBmYXVsdCBjYW5ub3QgYmUg aGFuZGxlZCAoaS5lLiBpcyBhbiBpbnZhbGlkIGFkZHJlc3MgcmF0aGVyIHRoYW4KPiA+IC0gKiBq dXN0IG5lZWRzIHBhZ2luZyBpbiksIHRoZW4gdGhlIHBhZ2UgcmVxdWVzdCB3aWxsIGJlIGNvbXBs ZXRlZAo+ID4gYnkKPiA+IC0gKiB0aGUgY29yZSBJT01NVSBjb2RlIHdpdGggYXBwcm9wcmlhdGUg c3RhdHVzLCBhbmQgdGhlIGRldmljZQo+ID4gaXRzZWxmCj4gPiAtICogY2FuIHRoZW4gcmVwb3J0 IHRoZSByZXN1bHRpbmcgZmF1bHQgdG8gaXRzIGRyaXZlciB2aWEgd2hhdGV2ZXIKPiA+IC0gKiBt ZWNoYW5pc20gaXMgYXBwcm9wcmlhdGUuCj4gPiAtICoKPiA+IC0gKiBNdWx0aXBsZSBjYWxscyBm cm9tIHRoZSBzYW1lIHByb2Nlc3MgbWF5IHJlc3VsdCBpbiB0aGUgc2FtZQo+ID4gUEFTSUQKPiA+ IC0gKiBiZWluZyByZS11c2VkLiBBIHJlZmVyZW5jZSBjb3VudCBpcyBrZXB0Lgo+ID4gLSAqLwo+ ID4gLWV4dGVybiBpbnQgaW50ZWxfc3ZtX2JpbmRfbW0oc3RydWN0IGRldmljZSAqZGV2LCBpbnQg KnBhc2lkLCBpbnQKPiA+IGZsYWdzLAo+ID4gLQkJCSAgICAgc3RydWN0IHN2bV9kZXZfb3BzICpv cHMpOyAgCj4gCj4gSSBub3RpY2Ugc3ZtX2Rldl9vcHMgaXNuJ3QgdXNlZCBhbnltb3JlLiBXaWxs IHlvdSByZW1vdmUgaXQgZW50aXJlbHksCj4gb3IgZG8geW91IHRoaW5rIHdlIHNob3VsZCBtb3Zl IHN2bV9kZXZfb3BzOjpmYXVsdF9jYigpIHRvCj4gaW9tbXVfc3ZhX29wcz8KPiAKSSBkb247dCB0 aGluayBmYXVsdF9jYigpIGlzIHVzZWZ1bCBhbnltb3JlIHNpbmNlIHdlIGhhdmUgcGVyIGRldmlj ZQpmYXVsdCByZXBvcnRpbmcgQVBJcy4gSSB3aWxsIHJlbW92ZSBpdC4gVGhhbmtzIGZvciB0aGUg cmVtaW5kZXIuCgo+IGlvbW11X3N2YV9vcHM6Om1tX2V4aXQoKSBpcyBhbHNvIG1pc3NpbmcsIGJ1 dCBJIHBsYW4gdG8gc2VuZCBhIFJGQyB0bwo+IHJlbW92ZSBpdCBzaG9ydGx5LCBzbyBkb24ndCBi b3RoZXIgOikKUmVtb3ZlIGlvbW11X3N2YV9vcHM/IEkgd2lsbCB3YWl0IGZvciB0aGUgcGF0Y2gu CgpUaGFua3MsCgpKYWNvYgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9t bXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E10BC43331 for ; Tue, 24 Mar 2020 15:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 643A22076F for ; Tue, 24 Mar 2020 15:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbgCXPsP convert rfc822-to-8bit (ORCPT ); Tue, 24 Mar 2020 11:48:15 -0400 Received: from mga11.intel.com ([192.55.52.93]:32877 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727847AbgCXPsO (ORCPT ); Tue, 24 Mar 2020 11:48:14 -0400 IronPort-SDR: 5glEzXVEhApY7SvY6mam7u2pdjppm58XCXGPw67gO1KC9HIQtXVC+bf0yiYHl4U3EgfTDGdihx aXjdO4mHxAgQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2020 08:48:13 -0700 IronPort-SDR: /3TviJPiPGIiX5u5mtsR+VfG5tYCSytp+4NuPBMOSeO8k3LBM5E9P6El05mhD1Ec6Ap3qorrZv Mnn6EgS1k81A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,300,1580803200"; d="scan'208";a="393322380" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga004.jf.intel.com with ESMTP; 24 Mar 2020 08:48:13 -0700 Date: Tue, 24 Mar 2020 08:53:56 -0700 From: Jacob Pan To: Jean-Philippe Brucker Cc: iommu@lists.linux-foundation.org, LKML , Lu Baolu , Joerg Roedel , David Woodhouse , Yi Liu , "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , Eric Auger , Dave Jiang , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH 2/2] iommu/vt-d: Replace intel SVM APIs with generic SVA APIs Message-ID: <20200324085356.64f6a904@jacob-builder> In-Reply-To: <20200320092955.GA1702630@myrica> References: <1582586797-61697-1-git-send-email-jacob.jun.pan@linux.intel.com> <1582586797-61697-4-git-send-email-jacob.jun.pan@linux.intel.com> <20200320092955.GA1702630@myrica> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Mar 2020 10:29:55 +0100 Jean-Philippe Brucker wrote: > Hi Jacob, > > I think this step is really useful and the patch looks good overall, > thanks for doing this. Some commments inline > > On Mon, Feb 24, 2020 at 03:26:37PM -0800, Jacob Pan wrote: > > This patch is an initial step to replace Intel SVM code with the > > following IOMMU SVA ops: > > intel_svm_bind_mm() => iommu_sva_bind_device() > > intel_svm_unbind_mm() => iommu_sva_unbind_device() > > intel_svm_is_pasid_valid() => iommu_sva_get_pasid() > > > > The features below will continue to work but are not included in > > this patch in that they are handled mostly within the IOMMU > > subsystem. > > - IO page fault > > - mmu notifier > > > > Consolidation of the above will come after merging generic IOMMU sva > > code[1]. There should not be any changes needed for SVA users such > > as accelerator device drivers during this time. > > > > [1] http://jpbrucker.net/sva/ > > > > Signed-off-by: Jacob Pan > > --- > > drivers/iommu/intel-iommu.c | 3 ++ > > drivers/iommu/intel-svm.c | 123 > > ++++++++++++++++++++++++-------------------- > > include/linux/intel-iommu.h | 7 +++ include/linux/intel-svm.h > > | 85 ------------------------------ 4 files changed, 78 > > insertions(+), 140 deletions(-) > > > > diff --git a/drivers/iommu/intel-iommu.c > > b/drivers/iommu/intel-iommu.c index 5eca6e10d2a4..ccfa5adfd06d > > 100644 --- a/drivers/iommu/intel-iommu.c > > +++ b/drivers/iommu/intel-iommu.c > > @@ -6475,6 +6475,9 @@ const struct iommu_ops intel_iommu_ops = { > > .cache_invalidate = intel_iommu_sva_invalidate, > > .sva_bind_gpasid = intel_svm_bind_gpasid, > > .sva_unbind_gpasid = intel_svm_unbind_gpasid, > > + .sva_bind = intel_svm_bind, > > + .sva_unbind = intel_svm_unbind, > > + .sva_get_pasid = intel_svm_get_pasid, > > #endif > > }; > > > > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > > index 1d7a95372f8c..35d949513728 100644 > > --- a/drivers/iommu/intel-svm.c > > +++ b/drivers/iommu/intel-svm.c > > @@ -516,13 +516,14 @@ int intel_svm_unbind_gpasid(struct device > > *dev, int pasid) return ret; > > } > > > > -int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, > > struct svm_dev_ops *ops) +/* Caller must hold pasid_mutex, mm > > reference */ +static int intel_svm_bind_mm(struct device *dev, int > > flags, struct svm_dev_ops *ops, > > + struct mm_struct *mm, struct intel_svm_dev > > **sd) { > > struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); > > struct device_domain_info *info; > > struct intel_svm_dev *sdev; > > struct intel_svm *svm = NULL; > > - struct mm_struct *mm = NULL; > > int pasid_max; > > int ret; > > > > @@ -539,16 +540,15 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ } else > > pasid_max = 1 << 20; > > > > + /* Bind supervisor PASID shuld have mm = NULL */ > > should > > > if (flags & SVM_FLAG_SUPERVISOR_MODE) { > > - if (!ecap_srs(iommu->ecap)) > > + if (!ecap_srs(iommu->ecap) || mm) { > > + pr_err("Supervisor PASID with user > > provided mm.\n"); return -EINVAL; > > - } else if (pasid) { > > - mm = get_task_mm(current); > > - BUG_ON(!mm); > > + } > > } > > > > - mutex_lock(&pasid_mutex); > > - if (pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > > + if (!(flags & SVM_FLAG_PRIVATE_PASID)) { > > struct intel_svm *t; > > > > list_for_each_entry(t, &global_svm_list, list) { > > @@ -586,9 +586,7 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ sdev->dev = dev; > > > > ret = intel_iommu_enable_pasid(iommu, dev); > > - if (ret || !pasid) { > > - /* If they don't actually want to assign a PASID, > > this is > > - * just an enabling check/preparation. */ > > + if (ret) { > > kfree(sdev); > > goto out; > > } > > @@ -688,18 +686,17 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ } > > } > > list_add_rcu(&sdev->list, &svm->devs); > > - > > - success: > > - *pasid = svm->pasid; > > +success: > > + sdev->pasid = svm->pasid; > > + sdev->sva.dev = dev; > > + if (sd) > > + *sd = sdev; > > One thing that might be missing: calling bind() multiple times with > the same (dev, mm) pair should take references to the svm struct, so > device drivers can call unbind() on it that many times. > > > ret = 0; > > out: > > - mutex_unlock(&pasid_mutex); > > - if (mm) > > - mmput(mm); > > return ret; > > } > > -EXPORT_SYMBOL_GPL(intel_svm_bind_mm); > > > > +/* Caller must hold pasid_mutex */ > > int intel_svm_unbind_mm(struct device *dev, int pasid) > > { > > struct intel_svm_dev *sdev; > > @@ -707,7 +704,6 @@ int intel_svm_unbind_mm(struct device *dev, int > > pasid) struct intel_svm *svm; > > int ret = -EINVAL; > > > > - mutex_lock(&pasid_mutex); > > iommu = intel_svm_device_to_iommu(dev); > > if (!iommu) > > goto out; > > @@ -753,45 +749,9 @@ int intel_svm_unbind_mm(struct device *dev, > > int pasid) break; > > } > > out: > > - mutex_unlock(&pasid_mutex); > > > > return ret; > > } > > -EXPORT_SYMBOL_GPL(intel_svm_unbind_mm); > > - > > -int intel_svm_is_pasid_valid(struct device *dev, int pasid) > > -{ > > - struct intel_iommu *iommu; > > - struct intel_svm *svm; > > - int ret = -EINVAL; > > - > > - mutex_lock(&pasid_mutex); > > - iommu = intel_svm_device_to_iommu(dev); > > - if (!iommu) > > - goto out; > > - > > - svm = ioasid_find(NULL, pasid, NULL); > > - if (!svm) > > - goto out; > > - > > - if (IS_ERR(svm)) { > > - ret = PTR_ERR(svm); > > - goto out; > > - } > > - /* init_mm is used in this case */ > > - if (!svm->mm) > > - ret = 1; > > - else if (atomic_read(&svm->mm->mm_users) > 0) > > - ret = 1; > > - else > > - ret = 0; > > - > > - out: > > - mutex_unlock(&pasid_mutex); > > - > > - return ret; > > -} > > -EXPORT_SYMBOL_GPL(intel_svm_is_pasid_valid); > > > > /* Page request queue descriptor */ > > struct page_req_dsc { > > @@ -984,3 +944,56 @@ static irqreturn_t prq_event_thread(int irq, > > void *d) > > return IRQ_RETVAL(handled); > > } > > + > > +#define to_intel_svm_dev(handle) container_of(handle, struct > > intel_svm_dev, sva) +struct iommu_sva * > > +intel_svm_bind(struct device *dev, struct mm_struct *mm, void > > *drvdata) +{ > > + struct iommu_sva *sva = ERR_PTR(-EINVAL); > > + struct intel_svm_dev *sdev = NULL; > > + int flags = 0; > > + int ret; > > + > > + /* > > + * TODO: Consolidate with generic iommu-sva bind after it > > is merged. > > + * It will require shared SVM data structures, i.e. > > combine io_mm > > + * and intel_svm etc. > > + */ > > + if (drvdata) > > + flags = *(int *)drvdata; > > drvdata is more for storing device driver contexts that can be passed > to iommu_sva_ops, but I get that this is temporary. > > As usual I'm dreading supervisor mode making it into the common API. > What are your plans regarding SUPERVISOR_MODE and PRIVATE_PASID > flags? The previous discussion on the subject [1] had me hoping that > you could replace supervisor mode with normal mappings (auxiliary > domains?) I'm less worried about PRIVATE_PASID, it would just add > complexity into the API and iommu-sva implementation, but doesn't > really have security implications. > > [1] > https://lore.kernel.org/linux-iommu/20190228220449.GA12682@araj-mobl1.jf.intel.com/ > > > + mutex_lock(&pasid_mutex); > > + ret = intel_svm_bind_mm(dev, flags, NULL, mm, &sdev); > > + if (ret) > > + sva = ERR_PTR(ret); > > + else if (sdev) > > + sva = &sdev->sva; > > + else > > + WARN(!sdev, "SVM bind succeeded with no sdev!\n"); > > + > > + mutex_unlock(&pasid_mutex); > > + > > + return sva; > > +} > > + > > +void intel_svm_unbind(struct iommu_sva *sva) > > +{ > > + struct intel_svm_dev *sdev; > > + > > + mutex_lock(&pasid_mutex); > > + sdev = to_intel_svm_dev(sva); > > + intel_svm_unbind_mm(sdev->dev, sdev->pasid); > > + mutex_unlock(&pasid_mutex); > > +} > > + > > +int intel_svm_get_pasid(struct iommu_sva *sva) > > +{ > > + struct intel_svm_dev *sdev; > > + int pasid; > > + > > + mutex_lock(&pasid_mutex); > > + sdev = to_intel_svm_dev(sva); > > + pasid = sdev->pasid; > > + mutex_unlock(&pasid_mutex); > > + > > + return pasid; > > +} > > diff --git a/include/linux/intel-iommu.h > > b/include/linux/intel-iommu.h index 37cfd35b7ccf..044493a11dce > > 100644 --- a/include/linux/intel-iommu.h > > +++ b/include/linux/intel-iommu.h > > @@ -702,6 +702,11 @@ extern int intel_svm_finish_prq(struct > > intel_iommu *iommu); extern int intel_svm_bind_gpasid(struct > > iommu_domain *domain, struct device *dev, struct > > iommu_gpasid_bind_data *data); extern int > > intel_svm_unbind_gpasid(struct device *dev, int pasid); +extern > > struct iommu_sva * +intel_svm_bind(struct device *dev, struct > > mm_struct *mm, void *drvdata); +extern void intel_svm_unbind(struct > > iommu_sva *handle); +extern int intel_svm_get_pasid(struct > > iommu_sva *handle); + > > struct svm_dev_ops; > > > > struct intel_svm_dev { > > @@ -709,6 +714,8 @@ struct intel_svm_dev { > > struct rcu_head rcu; > > struct device *dev; > > struct svm_dev_ops *ops; > > + struct iommu_sva sva; > > + int pasid; > > int users; > > u16 did; > > u16 dev_iotlb:1; > > diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h > > index a2c189ad0b01..fb7e786d8877 100644 > > --- a/include/linux/intel-svm.h > > +++ b/include/linux/intel-svm.h > > @@ -62,89 +62,4 @@ struct svm_dev_ops { > > */ > > #define SVM_FLAG_GUEST_PASID (1<<3) > > > > -#ifdef CONFIG_INTEL_IOMMU_SVM > > - > > -/** > > - * intel_svm_bind_mm() - Bind the current process to a PASID > > - * @dev: Device to be granted access > > - * @pasid: Address for allocated PASID > > - * @flags: Flags. Later for requesting supervisor mode, etc. > > - * @ops: Callbacks to device driver > > - * > > - * This function attempts to enable PASID support for the given > > device. > > - * If the @pasid argument is non-%NULL, a PASID is allocated for > > access > > - * to the MM of the current process. > > - * > > - * By using a %NULL value for the @pasid argument, this function > > can > > - * be used to simply validate that PASID support is available for > > the > > - * given device — i.e. that it is behind an IOMMU which has the > > - * requisite support, and is enabled. > > - * > > - * Page faults are handled transparently by the IOMMU code, and > > there > > - * should be no need for the device driver to be involved. If a > > page > > - * fault cannot be handled (i.e. is an invalid address rather than > > - * just needs paging in), then the page request will be completed > > by > > - * the core IOMMU code with appropriate status, and the device > > itself > > - * can then report the resulting fault to its driver via whatever > > - * mechanism is appropriate. > > - * > > - * Multiple calls from the same process may result in the same > > PASID > > - * being re-used. A reference count is kept. > > - */ > > -extern int intel_svm_bind_mm(struct device *dev, int *pasid, int > > flags, > > - struct svm_dev_ops *ops); > > I notice svm_dev_ops isn't used anymore. Will you remove it entirely, > or do you think we should move svm_dev_ops::fault_cb() to > iommu_sva_ops? > I don;t think fault_cb() is useful anymore since we have per device fault reporting APIs. I will remove it. Thanks for the reminder. > iommu_sva_ops::mm_exit() is also missing, but I plan to send a RFC to > remove it shortly, so don't bother :) Remove iommu_sva_ops? I will wait for the patch. Thanks, Jacob