From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3270C4332B for ; Tue, 24 Mar 2020 10:28:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E0352080C for ; Tue, 24 Mar 2020 10:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zuxb7YEO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E0352080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGgnD-0001oB-Nz for qemu-devel@archiver.kernel.org; Tue, 24 Mar 2020 06:28:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53000) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGgmc-0001OT-To for qemu-devel@nongnu.org; Tue, 24 Mar 2020 06:27:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGgmb-0001uq-Ul for qemu-devel@nongnu.org; Tue, 24 Mar 2020 06:27:42 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:22259) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGgmb-0001uc-Ql for qemu-devel@nongnu.org; Tue, 24 Mar 2020 06:27:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585045661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRSwIHB9FDaEfBcZaeovxAxK87P7DlQp0vXds5HNMhM=; b=Zuxb7YEOijUXT5T3coHVn5qLc8zSgXLL3DW5fzmkITyIoLtM9rYZ8S436lgxZKQU2/n7jV ny3BU85WgPaAoRq0GKXkX2ParHKgpmeTrsXBYy3eYIdJtL1kIjUb0hQsNycAoz5smpzsCr xohtmYq50XG+fGGF9tjkBE78RziUXts= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-HSCGA_UOP-WUr_PnhzXVQA-1; Tue, 24 Mar 2020 06:27:39 -0400 X-MC-Unique: HSCGA_UOP-WUr_PnhzXVQA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9617C800D54; Tue, 24 Mar 2020 10:27:33 +0000 (UTC) Received: from work-vm (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FC40A0A60; Tue, 24 Mar 2020 10:27:32 +0000 (UTC) Date: Tue, 24 Mar 2020 10:27:29 +0000 From: "Dr. David Alan Gilbert" To: Mao Zhongyi Subject: Re: [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters Message-ID: <20200324102729.GC2645@work-vm> References: <20200321151015.564989-1-maozhongyi@cmss.chinamobile.com> MIME-Version: 1.0 In-Reply-To: <20200321151015.564989-1-maozhongyi@cmss.chinamobile.com> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote: > 'params->has_tls_authz =3D true' has been hardcoded as true in > qmp_query_migrate_parameters, so remove the redundant check. >=20 > Signed-off-by: Mao Zhongyi > --- > monitor/hmp-cmds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index f8be6bbb16..d18826309b 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -461,7 +461,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const = QDict *qdict) > params->max_postcopy_bandwidth); > monitor_printf(mon, "%s: '%s'\n", > MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ), > - params->has_tls_authz ? params->tls_authz : ""); > + params->tls_authz); > } > =20 > qapi_free_MigrationParameters(params); That's OK, but we may as well combine it with the previous one. Dave > --=20 > 2.17.1 >=20 >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK