From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.2 required=3.0 tests=DEAR_SOMETHING,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E02C4332B for ; Tue, 24 Mar 2020 11:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44CA1208C3 for ; Tue, 24 Mar 2020 11:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585047968; bh=2LvE4EYXx6S7St3XOfLekrr0TlyAbuI62HGedV7PVfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SZQBsH2EgOVxapbl6U2h9gYd4uI8iMccLL7HbGde5/igHGgszO6bH652za/KSB+jM qVKYf4hBYwWnJTgUYK4L7Q9sbqsV0E1tqYMfcxaOB3UyrIjQdTStecx+89abQWct1H Pf8nwfqWr3BtM4eoMj34iDEQpdb1LYaUqzHDc6dg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbgCXLGH (ORCPT ); Tue, 24 Mar 2020 07:06:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:36556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgCXLGH (ORCPT ); Tue, 24 Mar 2020 07:06:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A02F20786; Tue, 24 Mar 2020 11:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585047967; bh=2LvE4EYXx6S7St3XOfLekrr0TlyAbuI62HGedV7PVfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BMhjKYnTWQPLqClRhwzeajd6cZLTTFORXjkcvfQmEmIVUg7JPlcZsMrANTFof7NHd wlWlxdOGa8LS/D11JaFVyXerSDI6CgWlFZtnDC2IKK2L+gWLquXQla4/5eWmsPKoTQ WgB2JPDT362mDWfTZOs1hyoYL2NDudE1kUbt6Hoo= Date: Tue, 24 Mar 2020 12:06:04 +0100 From: gregkh To: =?utf-8?B?5ZSQ5b2s?= Cc: Sergei Shtylyov , cernekee , balbi , "f.fainelli" , bcm-kernel-feedback-list , linux-usb , linux-arm-kernel , linux-kernel Subject: Re: Re: [PATCH] usb: gadget: bcm63xx_udc:remove useless variable definition Message-ID: <20200324110604.GA2225782@kroah.com> References: <20200324062932.8364-1-tangbin@cmss.chinamobile.com> <5f67315d-18c1-e444-03e7-a79a21d48b02@cogentembedded.com> <202003241719218101862@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202003241719218101862@cmss.chinamobile.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Mar 24, 2020 at 05:19:22PM +0800, 唐彬 wrote: > Dear Sir: > I'm glad for you replay。Yes。I think the variable assignment here can be deleted。 Great, can you please fix up your patch to say that? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.2 required=3.0 tests=DEAR_SOMETHING,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF49DC4332B for ; Tue, 24 Mar 2020 11:06:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AADF620786 for ; Tue, 24 Mar 2020 11:06:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y1om+kgz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BMhjKYnT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AADF620786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HlMbKAmUdY4hdSAyJOK3XzNHpxzK46yQWZnON1FWZHc=; b=Y1om+kgzA4s5b9 3rBpj2k2IEGv1adwdok6jOn4Yp7ph2hkwduRlpHQUk+T6XCi3mFoDsQhkNxBhSxD/8hdxI12X7WKH cbkFXdR0J2zS2Mc1fSZ9WGnXG0g7auq9Dzlm0C6YwdGNKsyWcafZQzgv9L2yxFdqs8KtNCrzZfTm9 0v5ua9zCePjhnnQ0EZ3u+9t0KvUZHGjNS57AAlqyagRDf1RorTQsRnFl7Qot7F/CQaSUHPKLXWD9l gLUe5P45Ia7no/0pvmrWAYHR0iQxHt5aihspRtvJSvCA1g7NiE5S6VAbp9/WouhtPSuExDpB9qbDT L9VJ9IuFT3lI9eAgteyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGhOM-0003gp-IF; Tue, 24 Mar 2020 11:06:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGhNo-0003Jy-6U for linux-arm-kernel@lists.infradead.org; Tue, 24 Mar 2020 11:06:12 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A02F20786; Tue, 24 Mar 2020 11:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585047967; bh=2LvE4EYXx6S7St3XOfLekrr0TlyAbuI62HGedV7PVfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BMhjKYnTWQPLqClRhwzeajd6cZLTTFORXjkcvfQmEmIVUg7JPlcZsMrANTFof7NHd wlWlxdOGa8LS/D11JaFVyXerSDI6CgWlFZtnDC2IKK2L+gWLquXQla4/5eWmsPKoTQ WgB2JPDT362mDWfTZOs1hyoYL2NDudE1kUbt6Hoo= Date: Tue, 24 Mar 2020 12:06:04 +0100 From: gregkh To: =?utf-8?B?5ZSQ5b2s?= Subject: Re: Re: [PATCH] usb: gadget: bcm63xx_udc:remove useless variable definition Message-ID: <20200324110604.GA2225782@kroah.com> References: <20200324062932.8364-1-tangbin@cmss.chinamobile.com> <5f67315d-18c1-e444-03e7-a79a21d48b02@cogentembedded.com> <202003241719218101862@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202003241719218101862@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_040608_274373_449CACFD X-CRM114-Status: UNSURE ( 6.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi , "f.fainelli" , Sergei Shtylyov , cernekee , linux-kernel , linux-usb , bcm-kernel-feedback-list , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXIgMjQsIDIwMjAgYXQgMDU6MTk6MjJQTSArMDgwMCwg5ZSQ5b2sIHdyb3RlOgo+ IERlYXIgU2ly77yaCj4gICAgICAgICBJJ20gZ2xhZCBmb3IgeW91IHJlcGxheeOAglllc+OAgkkg dGhpbmsgdGhlIHZhcmlhYmxlIGFzc2lnbm1lbnQgaGVyZSBjYW4gYmUgZGVsZXRlZOOAggoKR3Jl YXQsIGNhbiB5b3UgcGxlYXNlIGZpeCB1cCB5b3VyIHBhdGNoIHRvIHNheSB0aGF0PwoKdGhhbmtz LAoKZ3JlZyBrLWgKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK