From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 24 Mar 2020 11:07:10 +0000 Subject: Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function Message-Id: <20200324110710.GL5477@dell> List-Id: References: <17fc1dcf8b9b392d1e37dc7e3e67409e3c502840.1584667964.git.gurus@codeaurora.org> <20200320133123.GD5477@dell> In-Reply-To: <20200320133123.GD5477@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Guru Das Srinagesh Cc: linux-pwm@vger.kernel.org, Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , linux-fbdev@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Subbaraman Narayanamurthy On Fri, 20 Mar 2020, Lee Jones wrote: > On Thu, 19 Mar 2020, Guru Das Srinagesh wrote: > > > Since the PWM framework is switching struct pwm_state.period's datatype > > to u64, prepare for this transition by using div_u64 to handle a 64-bit > > dividend instead of a straight division operation. > > > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Bartlomiej Zolnierkiewicz > > Cc: linux-pwm@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-fbdev@vger.kernel.org > > > > Signed-off-by: Guru Das Srinagesh > > Reviewed-by: Daniel Thompson > > --- > > drivers/video/backlight/pwm_bl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Can this patch be taken on its own? Hellooooo ... > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > > index efb4efc..3e5dbcf 100644 > > --- a/drivers/video/backlight/pwm_bl.c > > +++ b/drivers/video/backlight/pwm_bl.c > > @@ -625,7 +625,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->scale = data->max_brightness; > > } > > > > - pb->lth_brightness = data->lth_brightness * (state.period / pb->scale); > > + pb->lth_brightness = data->lth_brightness * (div_u64(state.period, > > + pb->scale)); > > > > props.type = BACKLIGHT_RAW; > > props.max_brightness = data->max_brightness; > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function Date: Tue, 24 Mar 2020 11:07:10 +0000 Message-ID: <20200324110710.GL5477@dell> References: <17fc1dcf8b9b392d1e37dc7e3e67409e3c502840.1584667964.git.gurus@codeaurora.org> <20200320133123.GD5477@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:54840 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727095AbgCXLGX (ORCPT ); Tue, 24 Mar 2020 07:06:23 -0400 Received: by mail-wm1-f68.google.com with SMTP id c81so2689367wmd.4 for ; Tue, 24 Mar 2020 04:06:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20200320133123.GD5477@dell> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Guru Das Srinagesh Cc: linux-pwm@vger.kernel.org, Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org On Fri, 20 Mar 2020, Lee Jones wrote: > On Thu, 19 Mar 2020, Guru Das Srinagesh wrote: > > > Since the PWM framework is switching struct pwm_state.period's datatype > > to u64, prepare for this transition by using div_u64 to handle a 64-bit > > dividend instead of a straight division operation. > > > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Bartlomiej Zolnierkiewicz > > Cc: linux-pwm@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-fbdev@vger.kernel.org > > > > Signed-off-by: Guru Das Srinagesh > > Reviewed-by: Daniel Thompson > > --- > > drivers/video/backlight/pwm_bl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Can this patch be taken on its own? Hellooooo ... > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > > index efb4efc..3e5dbcf 100644 > > --- a/drivers/video/backlight/pwm_bl.c > > +++ b/drivers/video/backlight/pwm_bl.c > > @@ -625,7 +625,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->scale = data->max_brightness; > > } > > > > - pb->lth_brightness = data->lth_brightness * (state.period / pb->scale); > > + pb->lth_brightness = data->lth_brightness * (div_u64(state.period, > > + pb->scale)); > > > > props.type = BACKLIGHT_RAW; > > props.max_brightness = data->max_brightness; > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E320DC41621 for ; Tue, 24 Mar 2020 11:06:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9CF920786 for ; Tue, 24 Mar 2020 11:06:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VT9q5/jF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9CF920786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47B6488584; Tue, 24 Mar 2020 11:06:24 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D622895B9 for ; Tue, 24 Mar 2020 11:06:22 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id d198so2703182wmd.0 for ; Tue, 24 Mar 2020 04:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=85coQpfIuRs+sPyYMKP16shkvF4ULZs9j9T/GaUTXMA=; b=VT9q5/jF2VHIjb1DZzmV5uWK7Uk3Y+xVfuIZA7l+c4XrodjvqMvAkW8PC0kNkLrgYM 3iana2G8gyGAfBnuD3tWiwwsYyndM+xe6dTnJx4myohK1jgaOQlQisQ7OTsUcVb4TiHA 02CR0L4AmTwZ6TWYAuBgOaGihewpebEYX1AZBguETu6kswW6pM8vMDVrOiQXeCUsunFq kEXdn3pTTM5sKdZAVZryI6XQZDdohQZwEGPxqePgXmdn6YyIfmajV2Z0g6BrJMMfVDSZ 3pxXnSFuuNvVcIbxrbVnimLoPa7kg7P2p0ab+jA5qME9NUdm6UCRGEBAySrUTOyPCHYo wC6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=85coQpfIuRs+sPyYMKP16shkvF4ULZs9j9T/GaUTXMA=; b=tQ8qaRkaGfpO4Yl/j6hIOQAZfhGAQBJ8JjdaqqlsIDoFrU0N5BhIe6Gc8Ha575eNd6 4r5uWKGfaVoY8399U9/oBnWCv6lIFh8dcA0y1mqUSlzU+rv8+ZNf3EfRqzNgRD1XKcCK SGsqfp/NVDCLxT4FKjAyLbU1A7PbMRUObSdKma6D90N+pdxRHbH4Ka5zT5vthhHwNFQT J/fLDo6kzGu+JqAQZN1Hcpiy2lFJDy3OXMw4Av0XJTv/Wlgul2Q4Xd4J3aStl5YvcwNn g/KQYPpIyAFC3y+tF5jpSrm65lM0ha7+Qh4UZcJaFL1Cy/nb67D7sKy2ORDBrYMhIh8w 7gxQ== X-Gm-Message-State: ANhLgQ2Hp6c44+UVKdlob/zdj53oPWBec8mQARUdW4K3ASuYJiNMEoJp RCw+Pv9DnL9ousvpexERBrxBjA== X-Google-Smtp-Source: ADFU+vvewfCSPSJ/JtfjkuAPYyDeLB/atTsI2+R8ZuR0hHyIJno3qS1Oa/lOKqJLRVXNnbIQOwCyQA== X-Received: by 2002:a05:600c:20d:: with SMTP id 13mr4980605wmi.74.1585047981072; Tue, 24 Mar 2020 04:06:21 -0700 (PDT) Received: from dell ([2.27.35.213]) by smtp.gmail.com with ESMTPSA id 98sm28341407wrk.52.2020.03.24.04.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 04:06:20 -0700 (PDT) Date: Tue, 24 Mar 2020 11:07:10 +0000 From: Lee Jones To: Guru Das Srinagesh Subject: Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function Message-ID: <20200324110710.GL5477@dell> References: <17fc1dcf8b9b392d1e37dc7e3e67409e3c502840.1584667964.git.gurus@codeaurora.org> <20200320133123.GD5477@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200320133123.GD5477@dell> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , linux-fbdev@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Subbaraman Narayanamurthy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAyMCBNYXIgMjAyMCwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBUaHUsIDE5IE1hciAy MDIwLCBHdXJ1IERhcyBTcmluYWdlc2ggd3JvdGU6Cj4gCj4gPiBTaW5jZSB0aGUgUFdNIGZyYW1l d29yayBpcyBzd2l0Y2hpbmcgc3RydWN0IHB3bV9zdGF0ZS5wZXJpb2QncyBkYXRhdHlwZQo+ID4g dG8gdTY0LCBwcmVwYXJlIGZvciB0aGlzIHRyYW5zaXRpb24gYnkgdXNpbmcgZGl2X3U2NCB0byBo YW5kbGUgYSA2NC1iaXQKPiA+IGRpdmlkZW5kIGluc3RlYWQgb2YgYSBzdHJhaWdodCBkaXZpc2lv biBvcGVyYXRpb24uCj4gPiAKPiA+IENjOiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3Jn Pgo+ID4gQ2M6IERhbmllbCBUaG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4g PiBDYzogSmluZ29vIEhhbiA8amluZ29vaGFuMUBnbWFpbC5jb20+Cj4gPiBDYzogQmFydGxvbWll aiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPgo+ID4gQ2M6IGxpbnV4 LXB3bUB2Z2VyLmtlcm5lbC5vcmcKPiA+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gPiBDYzogbGludXgtZmJkZXZAdmdlci5rZXJuZWwub3JnCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IEd1cnUgRGFzIFNyaW5hZ2VzaCA8Z3VydXNAY29kZWF1cm9yYS5vcmc+Cj4gPiBSZXZp ZXdlZC1ieTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJvLm9yZz4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3B3bV9ibC5jIHwgMyArKy0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gQ2FuIHRo aXMgcGF0Y2ggYmUgdGFrZW4gb24gaXRzIG93bj8KCkhlbGxvb29vbyAuLi4KCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcHdtX2JsLmMgYi9kcml2ZXJzL3ZpZGVvL2Jh Y2tsaWdodC9wd21fYmwuYwo+ID4gaW5kZXggZWZiNGVmYy4uM2U1ZGJjZiAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3B3bV9ibC5jCj4gPiArKysgYi9kcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9wd21fYmwuYwo+ID4gQEAgLTYyNSw3ICs2MjUsOCBAQCBzdGF0aWMgaW50 IHB3bV9iYWNrbGlnaHRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ICAJ CXBiLT5zY2FsZSA9IGRhdGEtPm1heF9icmlnaHRuZXNzOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCXBi LT5sdGhfYnJpZ2h0bmVzcyA9IGRhdGEtPmx0aF9icmlnaHRuZXNzICogKHN0YXRlLnBlcmlvZCAv IHBiLT5zY2FsZSk7Cj4gPiArCXBiLT5sdGhfYnJpZ2h0bmVzcyA9IGRhdGEtPmx0aF9icmlnaHRu ZXNzICogKGRpdl91NjQoc3RhdGUucGVyaW9kLAo+ID4gKwkJCQlwYi0+c2NhbGUpKTsKPiA+ICAK PiA+ICAJcHJvcHMudHlwZSA9IEJBQ0tMSUdIVF9SQVc7Cj4gPiAgCXByb3BzLm1heF9icmlnaHRu ZXNzID0gZGF0YS0+bWF4X2JyaWdodG5lc3M7Cj4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9d CkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJj ZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVy IHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK