All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: ajayg@nvidia.com,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"open list:I2C CONTROLLER DRIVER FOR NVIDIA GPU"
	<linux-i2c@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check_status()
Date: Tue, 24 Mar 2020 12:09:30 +0100	[thread overview]
Message-ID: <20200324110930.GH1134@ninjato> (raw)
In-Reply-To: <20200311165806.12365-1-kai.heng.feng@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]


>  	} while (time_is_after_jiffies(target));
>  
> -	if (time_is_before_jiffies(target)) {
> +	if (time_is_before_eq_jiffies(target)) {

While unlikely, there is a tiny race between the time_is_* calls,
jiffies could update inbetween them.

So, for the sake of good programming practice, I'd recommend to set a
flag in the do_while-loop and the have the logic above solely based on
the flag.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2020-03-24 11:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 16:58 [PATCH] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check_status() Kai-Heng Feng
2020-03-11 16:58 ` Kai-Heng Feng
2020-03-23  5:38 ` Kai-Heng Feng
2020-03-23 16:47   ` Ajay Gupta
2020-03-23 17:20     ` Kai-Heng Feng
2020-03-24  3:51       ` Ajay Gupta
2020-03-24 11:09 ` Wolfram Sang [this message]
2020-03-24 11:12   ` Kai-Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324110930.GH1134@ninjato \
    --to=wsa@the-dreams.de \
    --cc=ajayg@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.