From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jGjcP-0001Qj-Qw for mharc-grub-devel@gnu.org; Tue, 24 Mar 2020 09:29:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49502) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGjcN-0001Po-37 for grub-devel@gnu.org; Tue, 24 Mar 2020 09:29:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGjcL-0004qE-PA for grub-devel@gnu.org; Tue, 24 Mar 2020 09:29:18 -0400 Received: from mail-eopbgr00051.outbound.protection.outlook.com ([40.107.0.51]:50567 helo=EUR02-AM5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGjcL-0004pa-EU for grub-devel@gnu.org; Tue, 24 Mar 2020 09:29:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqeTrIOLGEeDTNgsQsKzpFPYFjpqROZBFPGynUZM0szMIzoPKRA5P665U3zD32XSfH54cVZaRkZX0flw6gWvqcNmtu7R0meVomW5NY9tTVPvKzhy/FCgp79iGf0SZrCcvko7KLIh/yXPRk+fQphZY0sFg8NDev852OUDkhzLlJR7MTezuv+M6atg9AYnadf+EJVLTNY4hjyxjePLVb54O0FIapj3LQH3UjQQmFolmDbLKtm76ikgmGwDJ8x4sXjEeK9fmCILUnlalVUgZfStYF/A+LRb0YUq2a0iCVc2Y4XmAMtXTeHhnPme/f3Xj6drBAzrEAOLnUf5XHb8jPfk6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLciN7b1reeIaORubhjkyR2GJ4aVHvw0tXwCuVeF0g0=; b=DOemR79JFIAGzqDdR8tw3T/hOvTNbkYibTbbl6O1xLS9cNUmUhKsEL1i9uB23Lf55NKiIsez7ehov/JTbpyw+sEHxbLM8srae+ruMQCLbJc+Jvz3EBbw33B7K+uaJiE6nvRZXodIYvxIH1akyKXOHVxzjHhWWPQ3v128eBt8841SgIJjKT+TJ+sejxnjodfxjj/h6wNAImg1m/ruAilf+QbrMabUr94d61zXJKXeK03pp5H5qazc7uxDf2N2rPYglUk39sHF1VkNXNoFfE111+1uL6hQO1AitUc6hEQV4aDQbSndXm+KK6YShG8B5mqH99ue4exRcjXIvEDm9Xs/Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=itdev.co.uk; dmarc=pass action=none header.from=itdev.co.uk; dkim=pass header.d=itdev.co.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itdevltd.onmicrosoft.com; s=selector2-itdevltd-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLciN7b1reeIaORubhjkyR2GJ4aVHvw0tXwCuVeF0g0=; b=sxUtnBBIsKER0luLqA6d44p+IwTjFIDF562oV7fPQu3bxUidonDJ7f+4++N+qSvKyg6Ubymxn3egaXrQe8dQQ30HAi5we2Tl1ebQW6Z49giQfCE/g/TbaU78gg4zrMzLh75un9bIHcfPHdQK3n9Xa6gEnOOLU4ou5p3kt97N3pk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.hardy@itdev.co.uk; Received: from DB8PR08MB5257.eurprd08.prod.outlook.com (10.255.18.14) by DB8PR08MB5276.eurprd08.prod.outlook.com (20.179.15.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18; Tue, 24 Mar 2020 13:29:14 +0000 Received: from DB8PR08MB5257.eurprd08.prod.outlook.com ([fe80::ccae:4f34:1ab9:946e]) by DB8PR08MB5257.eurprd08.prod.outlook.com ([fe80::ccae:4f34:1ab9:946e%6]) with mapi id 15.20.2835.023; Tue, 24 Mar 2020 13:29:14 +0000 Date: Tue, 24 Mar 2020 13:29:12 +0000 From: Simon Hardy To: grub-devel@gnu.org Subject: [PATCH] Fix GRUB i386-pc build with Ubuntu gcc Message-ID: <20200324132911.GA358144@itdev.co.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: LO2P265CA0101.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::17) To DB8PR08MB5257.eurprd08.prod.outlook.com (2603:10a6:10:e8::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from itdev.co.uk (82.24.20.222) by LO2P265CA0101.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.15 via Frontend Transport; Tue, 24 Mar 2020 13:29:13 +0000 X-Originating-IP: [82.24.20.222] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3797263f-9c09-4708-a1d7-08d7cff75814 X-MS-TrafficTypeDiagnostic: DB8PR08MB5276: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(66946007)(6916009)(66476007)(66556008)(52116002)(55016002)(7696005)(86362001)(36756003)(5660300002)(81166006)(8676002)(2906002)(33656002)(81156014)(8936002)(956004)(26005)(186003)(16526019)(508600001)(44832011)(2616005)(1076003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR08MB5276; H:DB8PR08MB5257.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VsmucXukZJiHIsxAeoP/qBK2OcVdnQg5g6x11bfEVwOiFOdQ69bJvXcWQXqxKmFjGNwLwqpQm1VA0zKz9kAs7c7i/cyhEbFAkUVt7bez1RiVeZ+q3E+J2k1//OpN3Ai9Bw85HJ8zi9PQbunUpTTuuEGIuUmNIpGELSaBYUjjc4P5I5LZNrcLbSUQdcYE1xtWYlUIYQCsKjbQAF+dNsXDHrjN2LWEe0OwotWjJkQadAfPFgKWAxjUPjD//u4/d6U1EvERB28SIwej030hRhPf1rQkPq43cDC34UA2bB54tiI1+sCFcm0WRrQxUB22wi9MglzNMT3pBuNSJeCJJutsqt8K5eNRITOa2mXhng1FvNktwTXH9LhWdVoKeb5bR4kGBOAulzgf7oPjFQCuBlVUqflpwdbdkuP9pyQMdFuO2d7jFgd9n0sime78oXfQ/dO8 X-MS-Exchange-AntiSpam-MessageData: wBvw+/mNVEuYReupQAvSrHk1H0JmO6Aevk1uO2156/8YM+IwbUVHaoS/53K7CROgt98B6QW29lgJnvpUA7W2hmHhR8yO3DwU51SimkvAZ1iCpT/y7bUkXsu9Sm69wh7o+Zi3R+Z5OHefrSLZI+X0XA== X-OriginatorOrg: itdev.co.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 3797263f-9c09-4708-a1d7-08d7cff75814 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 13:29:13.9452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zuRkIVjYisv4Sz0zYvHXDD2wI8dnfz30ywpU9/fYeYCqCnGhQ/7K1qM2YsThN6CyBvvYITy2PzyPa/jdHo2s2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5276 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.0.51 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 13:29:20 -0000 With recent versions of gcc on Ubuntu a very large lzma_decompress.img file is output. (e.g. 134479600 bytes instead of 2864.) This causes grub-mkimage to fail with: "error: Decompressor is too big." This seems to be caused by a section .note.gnu.property that is placed at an offset such that objcopy needs to pad the img file with zeros. This issue is present on: Ubuntu 19.10 with gcc (Ubuntu 8.3.0-26ubuntu1~19.10) 8.3.0 Ubuntu 19.10 with gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008 This issue is not present on: Ubuntu 19.10 with gcc (Ubuntu 7.5.0-3ubuntu1~19.10) 7.5.0 RHEL 8.0 with gcc 8.3.1 20190507 (Red Hat 8.3.1-4) The issue can be fixed by removing the section using objcopy as shown in this patch: Signed-off-by: Simon Hardy --- gentpl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gentpl.py b/gentpl.py index 387588c05..c86550d4f 100644 --- a/gentpl.py +++ b/gentpl.py @@ -766,7 +766,7 @@ def image(defn, platform): if test x$(TARGET_APPLE_LINKER) = x1; then \ $(MACHO2IMG) $< $@; \ else \ - $(TARGET_OBJCOPY) $(""" + cname(defn) + """_OBJCOPYFLAGS) --strip-unneeded -R .note -R .comment -R .note.gnu.build-id -R .MIPS.abiflags -R .reginfo -R .rel.dyn -R .note.gnu.gold-version -R .ARM.exidx $< $@; \ + $(TARGET_OBJCOPY) $(""" + cname(defn) + """_OBJCOPYFLAGS) --strip-unneeded -R .note -R .comment -R .note.gnu.build-id -R .MIPS.abiflags -R .reginfo -R .rel.dyn -R .note.gnu.gold-version -R .note.gnu.property -R .ARM.exidx $< $@; \ fi """) -- 2.25.0