From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C3FC43331 for ; Tue, 24 Mar 2020 14:17:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C59DE2078A for ; Tue, 24 Mar 2020 14:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DH0eEE/M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C59DE2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGkNP-0006Vd-Qs for qemu-devel@archiver.kernel.org; Tue, 24 Mar 2020 10:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56550) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGkMk-00066Q-Mx for qemu-devel@nongnu.org; Tue, 24 Mar 2020 10:17:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGkMi-0005iY-SF for qemu-devel@nongnu.org; Tue, 24 Mar 2020 10:17:14 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:51806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGkMi-0005gY-OL for qemu-devel@nongnu.org; Tue, 24 Mar 2020 10:17:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585059431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+ir3/YXWwtGMW/jqL7GJv1mlO7peyDXMLoUy0hzKXc=; b=DH0eEE/MlFarbLheo+eaGHv5/NI2mUS4JiKY3snzoItYDjdxMFzQv19b+/jn8P6tAvOwYu n1JcDyT0o/+HibWYF3WLCYUTpNfR1RCueI+LQ02hYoRUhZHgKgqpekIoiGrePWyc/EnMiw LATbY2ywtV4SIgRLQ60TWbSMPyZv6EM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-WFlHEucNOD-nLOtdGdxnuA-1; Tue, 24 Mar 2020 10:17:10 -0400 X-MC-Unique: WFlHEucNOD-nLOtdGdxnuA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 286F096F60; Tue, 24 Mar 2020 14:17:09 +0000 (UTC) Received: from localhost (unknown [10.40.208.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67718A7D6; Tue, 24 Mar 2020 14:17:04 +0000 (UTC) Date: Tue, 24 Mar 2020 15:17:02 +0100 From: Igor Mammedov To: Ani Sinha Subject: Re: Hot unplug disabling on pci-pci bridge Message-ID: <20200324151702.4c2eb79e@redhat.com> In-Reply-To: <90435944-E1E5-49AB-A039-ADBEC58EFB0B@nutanix.com> References: <20200324121703.472b034b@redhat.com> <90435944-E1E5-49AB-A039-ADBEC58EFB0B@nutanix.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-devel@nongnu.org" , Laine Stump Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 24 Mar 2020 13:29:10 +0000 Ani Sinha wrote: > On Mar 24, 2020, at 4:47 PM, Igor Mammedov > wrote: > > you probably have APCI hotplug for bridges enabled (which applies to > all cold-plugged bridges). > You can disable it by setting following property > -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off > then it should fall back to SHPC which are are tying to disable > > Ok I patched to change the default : > > --- > hw/acpi/piix4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index d706360..db888cb 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -675,7 +675,7 @@ static Property piix4_pm_properties[] = { > DEFINE_PROP_UINT8(ACPI_PM_PROP_S4_DISABLED, PIIX4PMState, disable_s4, 1), > DEFINE_PROP_UINT8(ACPI_PM_PROP_S4_VAL, PIIX4PMState, s4_val, 2), > DEFINE_PROP_BOOL("acpi-pci-hotplug-with-bridge-support", PIIX4PMState, > - use_acpi_pci_hotplug, true), > + use_acpi_pci_hotplug, false), > DEFINE_PROP_BOOL("memory-hotplug-support", PIIX4PMState, > acpi_memory_hotplug.is_enabled, true), > DEFINE_PROP_END_OF_LIST(), > -- > 1.9.4 > > This seems to work but now Windows is giving an option to eject pci bridges. Clicking it does not do anything. I wonder if we can disable that as well. AFAIK hot unplugging bridges would not take effect until ACPI tables are updated and the OS kernel re-reads the updated tables. See https://bugzilla.redhat.com/show_bug.cgi?id=1339875 if you are interested in hacking ACPI PCI hotplug more, look at how build_append_pci_bus_devices() works > > Ani > [cid:809BEDB4-EEF6-4197-A083-4AF2E9999CEB]