From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: virtio-fs-list <virtio-fs@redhat.com>
Subject: Re: [Virtio-fs] xfstest generic/503 hangs
Date: Tue, 24 Mar 2020 19:52:30 +0000 [thread overview]
Message-ID: <20200324195230.GH2645@work-vm> (raw)
In-Reply-To: <1c152d0a-cd7c-9474-708b-fa825e97cd4a@redhat.com>
* Max Reitz (mreitz@redhat.com) wrote:
> On 23.03.20 19:43, Dr. David Alan Gilbert wrote:
> > * Max Reitz (mreitz@redhat.com) wrote:
> >> Hi,
> >>
> >> I have this bug report here:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1813885
> >>
> >> And I’m afraid I’m not really making progress on debugging it, so I was
> >> wondering whether any of you might have some insights.
> >>
> >> The problem is that the generic/503 xfstest hangs on virtio-fs. Now, I
> >> don’t know how the reporter got that test to run in the first place,
> >> because for me, it requires fcollapse and fzero, which as far as I can
> >> tell are currently not supported for virtio-fs.
> >>
> >> So I first had to disable those requirements, and then let the helper
> >> program (src/t_mmap_collision.c) not test those operations.
> >>
> >> Then, the test hangs. What I could find out so far is that the hang
> >> occurs in src/t_mmap_collision.c’s truncate_down_fn() (run through
> >> run_test(&truncate_down_fn), namely in one of the pread()s. I can also
> >> see that some of the pread()s before fail with EFAULT.
> >>
> >> A bit more context: t_mmap_collision.c opens a test file twice (I think
> >> the idea is that you open it once on an FS with DAX, and once without,
> >> but AFAIU it should work either way). For the relevant test, it mmap()s
> >> the DAX FD, truncates it, then fallocates it to increase the size again.
> >> Then it reads from the non-DAX FD.
> >
> > Can you just confirm where the DAX is happening here? As I read that bz
> > entry it's using the qemu which doesn't have DAX code yet.
>
> I actually don’t know whether it really uses DAX. When I say “DAX” here
> (and “dax_fd”), I mean it in the spirit of the test, which tries to open
> a file once with DAX and once without. But it isn’t like it verifies
> that the first instance actually uses DAX.
>
> So I think it rather likely that it doesn’t use DAX, and just two FDs
> for a single file concurrently.
OK, I don't think DAX is really involved.
Does Liu Bo's:
https://www.redhat.com/archives/virtio-fs/2020-March/msg00074.html
help?
Dave
> Max
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-03-24 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 18:18 [Virtio-fs] xfstest generic/503 hangs Max Reitz
2020-03-23 18:40 ` Liu Bo
2020-03-23 19:12 ` Liu Bo
2020-03-24 17:32 ` Max Reitz
2020-03-23 18:43 ` Dr. David Alan Gilbert
2020-03-24 17:30 ` Max Reitz
2020-03-24 19:52 ` Dr. David Alan Gilbert [this message]
2020-03-25 9:49 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324195230.GH2645@work-vm \
--to=dgilbert@redhat.com \
--cc=mreitz@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.