From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v5 1/6] i2c: core: Provide generic definitions for bus frequencies
Date: Tue, 24 Mar 2020 22:09:29 +0100 [thread overview]
Message-ID: <20200324210929.GB7641@ninjato> (raw)
In-Reply-To: <20200324123216.78113-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Tue, Mar 24, 2020 at 02:32:11PM +0200, Andy Shevchenko wrote:
> There are few maximum bus frequencies being used in the I²C core code.
> Provide generic definitions for bus frequencies and use them in the core.
>
> The drivers may use predefined constants where it is appropriate.
> Some of them are already using these under slightly different names.
> We will convert them later to use newly introduced defines.
>
> Note, the name of modes are chosen to follow well established naming
> scheme [1].
>
> These definitions will also help to avoid typos in the numbers that
> may lead to subtle errors.
>
> [1]: https://en.wikipedia.org/wiki/I%C2%B2C#Differences_between_modes
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-03-24 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 12:32 [PATCH v5 1/6] i2c: core: Provide generic definitions for bus frequencies Andy Shevchenko
2020-03-24 12:32 ` [PATCH v5 2/6] i2c: core: Allow override timing properties with 0 Andy Shevchenko
2020-03-24 21:09 ` Wolfram Sang
2020-03-24 12:32 ` [PATCH v5 3/6] i2c: rcar: Consolidate timings calls in rcar_i2c_clock_calculate() Andy Shevchenko
2020-03-24 21:09 ` Wolfram Sang
2020-03-24 12:32 ` [PATCH v5 4/6] i2c: stm32f7: switch to I²C generic property parsing Andy Shevchenko
2020-03-24 21:09 ` Wolfram Sang
2020-03-24 12:32 ` [PATCH v5 5/6] i2c: algo: Use generic definitions for bus frequencies Andy Shevchenko
2020-03-24 21:09 ` Wolfram Sang
2020-03-24 21:09 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324210929.GB7641@ninjato \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.