From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] Use SAFE_RUNCMD()
Date: Wed, 25 Mar 2020 02:53:25 +0100 [thread overview]
Message-ID: <20200325015324.GA15127@yuki.lan> (raw)
In-Reply-To: <20200324172102.GA1307@dell5510>
Hi!
> > Also if we are going to add this functionality it should be added as an
> > .needs_cmds array in the tst_test structure.
> .needs_cmds sounds as a good idea. But let's do it as a separate effort.
> I'll leave already sent v2 for review. Once .needs_cmds is implemented, we can
> use it as well for copy_file_range02.c.
Actually I would like to avoid exposing the function to the tests and
force people to use the .needs_cmds instead in order to have a proper
metadata.
> BTW what do you think on changing 255 (and 254) for something less common?
> It's just a corner case swapon on certain setup in copy_file_range02.c returns
> 255 on error:
I do not think that this will solve the problem. We may hit the same
problem with any random number we will choose.
I guess checking for the command existence before we vfork() would be
safer bet here.
> Setting up swapspace version 1, size = 36 KiB (36864 bytes)
> no label, UUID=bae78639-be0b-42b2-9e91-815b05f5751b
> swapon: /tmp/msT4Ch/file_swap: swapon failed: Invalid argument
> copy_file_range02.c:95: CONF: swapon binary not installed or failed
>
> Kind regards,
> Petr
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-25 1:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 13:49 [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only) Petr Vorel
2020-03-20 13:49 ` [LTP] [PATCH 2/2] Use SAFE_RUNCMD() Petr Vorel
2020-03-23 3:13 ` Yang Xu
2020-03-23 9:04 ` Petr Vorel
2020-03-23 9:10 ` Li Wang
2020-03-23 9:52 ` Yang Xu
2020-03-23 11:37 ` Petr Vorel
2020-03-23 13:42 ` Li Wang
2020-03-23 14:32 ` Li Wang
2020-03-23 16:04 ` Petr Vorel
2020-03-24 23:51 ` Cyril Hrubis
2020-03-24 17:21 ` Petr Vorel
2020-03-25 1:53 ` Cyril Hrubis [this message]
2020-03-24 18:55 ` Petr Vorel
2020-03-25 5:56 ` Li Wang
2020-03-25 5:30 ` Li Wang
2020-03-25 17:07 ` Cyril Hrubis
2020-03-25 9:34 ` Petr Vorel
2020-03-25 10:03 ` Cyril Hrubis
2020-03-25 15:40 ` Petr Vorel
2020-03-25 10:42 ` Yang Xu
2020-03-25 15:56 ` Petr Vorel
2020-03-26 5:27 ` Li Wang
2020-03-26 8:03 ` Yang Xu
2020-03-23 15:49 ` Petr Vorel
2020-03-24 6:27 ` Li Wang
2020-03-23 2:43 ` [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only) Yang Xu
2020-03-23 9:20 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325015324.GA15127@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.