From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Replace deprecated <strings.h> with <string.h>
Date: Wed, 25 Mar 2020 11:12:10 +0100 [thread overview]
Message-ID: <20200325101209.GC5404@yuki.lan> (raw)
In-Reply-To: <20200325110148.07f0a740@daedruan>
Hi!
> Closes: #521
>
> Signed-off-by: Jozef Pupava <jpupava@suse.com>
> ---
> testcases/kernel/containers/share/ns_create.c | 2 +-
> testcases/kernel/fs/fsx-linux/fsx-linux.c | 2 +-
> .../open_posix_testsuite/conformance/interfaces/sem_timedwait/3-1.c | 2 +-
> .../open_posix_testsuite/conformance/interfaces/sem_timedwait/7-1.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/testcases/kernel/containers/share/ns_create.c b/testcases/kernel/containers/share/ns_create.c
> index 1d0339e71..4a4007c3a 100644
> --- a/testcases/kernel/containers/share/ns_create.c
> +++ b/testcases/kernel/containers/share/ns_create.c
> @@ -30,7 +30,7 @@
> #include <sys/stat.h>
> #include <unistd.h>
> #include <string.h>
> -#include <strings.h>
> +#include <string.h>
The string.h include is already there, so we just need to delete it
here.
> #include <errno.h>
> #include "test.h"
> #include "lapi/namespaces_constants.h"
> diff --git a/testcases/kernel/fs/fsx-linux/fsx-linux.c b/testcases/kernel/fs/fsx-linux/fsx-linux.c
> index 02f3eb827..4a20f4da6 100644
> --- a/testcases/kernel/fs/fsx-linux/fsx-linux.c
> +++ b/testcases/kernel/fs/fsx-linux/fsx-linux.c
> @@ -43,7 +43,7 @@
> #include <sys/param.h>
> #include <limits.h>
> #include <time.h>
> -#include <strings.h>
> +#include <string.h>
> #include <sys/time.h>
> #endif
> #include <fcntl.h>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/3-1.c
> index dd42bbd91..97bdbff5d 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/3-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/3-1.c
> @@ -20,7 +20,7 @@
> #endif
> #include <semaphore.h>
> #include <stdio.h>
> -#include <strings.h>
> +#include <string.h>
> #include <time.h>
> #include <unistd.h>
> #include "posixtest.h"
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/7-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/7-1.c
> index 79de0af7f..da2cd3084 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/7-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/7-1.c
> @@ -21,7 +21,7 @@
> #endif
> #include <semaphore.h>
> #include <stdio.h>
> -#include <strings.h>
> +#include <string.h>
> #include <time.h>
> #include <unistd.h>
> #include "posixtest.h"
As far as I can tell there are no string functions used in the
sem_timedwait() tests, so we can as well just remove the include in
these two.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2020-03-25 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 10:01 [LTP] [PATCH] Replace deprecated <strings.h> with <string.h> Jozef Pupava
2020-03-25 10:12 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325101209.GC5404@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.