Re: [PATCH v3 15/22] media: Kconfig: move media controller core select to main Kconfig

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Wed, 25 Mar 2020 11:08:34 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:

> Em Wed, 25 Mar 2020 12:00:59 +0200
> Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:
> 
> > Hi Mauro,
> > 
> > On Wed, Mar 25, 2020 at 10:49:29AM +0100, Mauro Carvalho Chehab wrote:
> > > Let's place the main API selections at the media/Kconfig file,
> > > as this way we can better organize things.
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > >  drivers/media/Kconfig    | 9 +++++++++
> > >  drivers/media/mc/Kconfig | 9 ---------
> > >  2 files changed, 9 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > > index d6766085c91b..3872e46545e6 100644
> > > --- a/drivers/media/Kconfig
> > > +++ b/drivers/media/Kconfig
> > > @@ -144,6 +144,15 @@ config VIDEO_DEV
> > >  	depends on MEDIA_SUPPORT
> > >  	default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_PLATFORM_SUPPORT
> > >  
> > > +config MEDIA_CONTROLLER
> > > +	bool "Media Controller API"
> > > +	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
> > > +	help
> > > +	  Enable the media controller API used to query media devices internal
> > > +	  topology and configure it dynamically.
> > > +
> > > +	  This API is mostly used by camera interfaces in embedded platforms.
> > > +
> > >  source "drivers/media/v4l2-core/Kconfig"
> > >  
> > >  #
> > > diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> > > index 3b9795cfcb36..b3579d6c9e32 100644
> > > --- a/drivers/media/mc/Kconfig
> > > +++ b/drivers/media/mc/Kconfig
> > > @@ -3,15 +3,6 @@
> > >  #	Selectable only for webcam/grabbers, as other drivers don't use it
> > >  #
> > >  
> > > -config MEDIA_CONTROLLER
> > > -	bool "Media Controller API"
> > > -	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
> > > -	help
> > > -	  Enable the media controller API used to query media devices internal
> > > -	  topology and configure it dynamically.
> > > -
> > > -	  This API is mostly used by camera interfaces in embedded platforms.
> > > -
> > >  config MEDIA_CONTROLLER_DVB
> > >  	bool "Enable Media controller for DVB (EXPERIMENTAL)"
> > >  	depends on MEDIA_CONTROLLER && DVB_CORE  
> > 
> > This moves the main MC configuration out of the directory but leaves the
> > rest of the MC configuration under the mc directory. All MC related
> > configuration is currently in a single place, which makes sense.
> > 
> > I guess you can always have arguments for and against, but my preference is
> > keeping it as-is.
> 
> Well, the advantage (after applying the entire series), is that it can now
> present two separate menus:
> 
> the first one with the core stuff (MC, V4L and DVB), and a second one
> with the extra features for those three.
> 
> Btw, it just occurred to me that perhaps we could map it on a different way,
> using a menu for MC, another one for V4L and a third one for DVB.

What occurred to me is shown at the patch below (applied after this patch
series).

IMHO, it is a way better to present things like that.

Thanks,
Mauro

[PATCH] media: Kconfig: Better organize the per-API options

After this change, the menu is displayed like above.

1) When filtering is not active:

    --- Multimedia support
        [ ]   Filter devices by their types
        [*]   Autoselect ancillary drivers (tuners, sensors, i2c, spi, frontends)
              Media core support  --->
              Video4Linux options  --->
              Media controller options  --->
              Digital TV options  --->
              HDMI CEC options  --->
              Media drivers  --->

2) When filtering is active:

    --- Multimedia support
        [*]   Filter devices by their types
        [*]   Autoselect ancillary drivers (tuners, sensors, i2c, spi, frontends)
              Media device types  --->
              Video4Linux options  --->
              Media controller options  --->
              Digital TV options  --->
              HDMI CEC options  --->
              Media drivers  --->

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 2a69b8024a0f..f942d19cf99b 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -184,10 +184,19 @@ endmenu # Media core support
 #
 # Extra per-media API core functionality
 
-menu "Media core additional options"
+menu "Video4Linux options"
 source "drivers/media/v4l2-core/Kconfig"
+endmenu
+
+menu "Media controller options"
 source "drivers/media/mc/Kconfig"
+endmenu
+
+menu "Digital TV options"
 source "drivers/media/dvb-core/Kconfig"
+endmenu
+
+menu "HDMI CEC options"
 source "drivers/media/cec/Kconfig"
 endmenu