From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sam Muhammed <jane.pnx9@gmail.com>
Cc: Julia Lawall <julia.lawall@inria.fr>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.
Date: Wed, 25 Mar 2020 13:36:44 +0100 [thread overview]
Message-ID: <20200325123643.GA3454907@kroah.com> (raw)
In-Reply-To: <44ca99f66316430555a2da1379283ca846acb027.camel@gmail.com>
On Wed, Mar 25, 2020 at 04:00:36AM -0400, Sam Muhammed wrote:
> On Tue, 2020-03-24 at 22:22 +0100, Julia Lawall wrote:
> >
> > On Tue, 24 Mar 2020, Sam Muhammed wrote:
> >
> > > Cleanup Checkpatch.pl CHECKs about missing
> > > spaces around multiple operators.
> > >
> > > Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> > > ---
> > > drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
> > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c
> > > index d93097ed781c..e599ae1bdfd0 100644
> > > --- a/drivers/staging/kpc2000/kpc_dma/fileops.c
> > > +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c
> > > @@ -19,7 +19,7 @@ static inline
> > > unsigned int count_pages(unsigned long iov_base, size_t iov_len)
> > > {
> > > unsigned long first = (iov_base & PAGE_MASK) >> PAGE_SHIFT;
> > > - unsigned long last = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
> > > + unsigned long last = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;
> >
> > It seems that the & operators were lined up before and that is not the
> > case any more.
> >
>
> Yes, why they were aligned anyways?
Because it is easier to understand the code that way, don't you think?
next prev parent reply other threads:[~2020-03-25 12:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:09 [PATCH 0/6] Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS Sam Muhammed
2020-03-24 21:09 ` [PATCH 1/6] Staging: kpc2000: kpc_dma: Remove comparison to NULL Sam Muhammed
2020-03-24 21:09 ` [PATCH 2/6] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc() Sam Muhammed
2020-03-24 21:23 ` [Outreachy kernel] " Julia Lawall
2020-03-24 21:24 ` Julia Lawall
2020-03-25 8:10 ` Sam Muhammed
2020-03-25 13:01 ` Julia Lawall
2020-03-24 21:09 ` [PATCH 3/6] Staging: kpc2000: kpc_dma: Remove unnecessary braces Sam Muhammed
2020-03-24 21:23 ` [Outreachy kernel] " Julia Lawall
2020-03-24 21:09 ` [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators Sam Muhammed
2020-03-24 21:22 ` [Outreachy kernel] " Julia Lawall
2020-03-25 8:00 ` Sam Muhammed
2020-03-25 12:36 ` Greg Kroah-Hartman [this message]
2020-03-25 12:57 ` Sam Muhammed
2020-03-30 1:02 ` Stefano Brivio
2020-03-30 11:55 ` Sam Muhammed
2020-03-30 14:29 ` Stefano Brivio
2020-03-24 21:09 ` [PATCH 5/6] Staging: kpc2000: kpc_dma: Include the preferred header Sam Muhammed
2020-03-24 21:09 ` [PATCH 6/6] Staging: kpc2000: kpc_dma: Use the SPDK comment style Sam Muhammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325123643.GA3454907@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jane.pnx9@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.