All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org, nicholas.johnson-opensource@outlook.com.au
Subject: Re: [PATCH v3 2/2] nvmem: core: use is_bin_visible for permissions
Date: Wed, 25 Mar 2020 13:44:57 +0100	[thread overview]
Message-ID: <20200325124457.GA3511062@kroah.com> (raw)
In-Reply-To: <20200325122116.15096-3-srinivas.kandagatla@linaro.org>

On Wed, Mar 25, 2020 at 12:21:16PM +0000, Srinivas Kandagatla wrote:
> By using is_bin_visible callback to set permissions will remove a
> large list of attribute groups. These group permissions can be
> dynamically derived in the callback.
> 
> Also add checks for read/write callbacks and set permissions accordingly.
> 
> As part of this cleanup it does not make sense to have a separate
> nvmem-sysfs.c and nvmem.h file anymore, so move all the relevant
> data structures and functions to core.c

And because of that move, it's impossible to see the real changes made
here :(

Can you do this in two steps, one do the code/logic changes, and the
other do the "move into one file"?  That way it is actually reviewable,
as it is, it's impossible to do so.

I'll go queue up the first patch to make the series smaller :)

thanks,

greg k-h

  reply	other threads:[~2020-03-25 12:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 12:21 [PATCH v3 0/2] nvmem: use is_bin_visible callback Srinivas Kandagatla
2020-03-25 12:21 ` [PATCH v3 1/2] nvmem: core: add root_only member to nvmem device struct Srinivas Kandagatla
2020-03-25 12:21 ` [PATCH v3 2/2] nvmem: core: use is_bin_visible for permissions Srinivas Kandagatla
2020-03-25 12:44   ` Greg KH [this message]
2020-03-25 12:50     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200325124457.GA3511062@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicholas.johnson-opensource@outlook.com.au \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.