From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43BE7C43331 for ; Wed, 25 Mar 2020 12:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A38820775 for ; Wed, 25 Mar 2020 12:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585140302; bh=qgXKHtmY9kOCICENIGp4XHbWH+aHq+z99hqCOfHAILU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=x+pn9KzYfKVR/OoS4z97tOYiY6Xc+CY2CqSwnRfPEARbk138abtLUSdHAorao12xb iQJpVdLtR6Kny6zCUMgd9yi9rbrRTelOlU8lVUHROk6aYtePNuo2DqM3ynI8e8nNNy mxNr33uuB2BYF/IiG5MWUjCnhE4p8loHXzDepEEY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727402AbgCYMpB (ORCPT ); Wed, 25 Mar 2020 08:45:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:32884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727280AbgCYMpA (ORCPT ); Wed, 25 Mar 2020 08:45:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 389F02076A; Wed, 25 Mar 2020 12:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585140299; bh=qgXKHtmY9kOCICENIGp4XHbWH+aHq+z99hqCOfHAILU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GL67TANSfKxEIUirrL8/8UplMEO6rupt82NWhq2mineXAYpsugsoqTCxXg1PiOxX2 fOUbY3r4QUtvwKa//2yZ0I1yCol8/+7vOuhjhZS1WtdOBhcQ4hQIhhy408z0Lu3SI+ /g+QtMlU0qRagpGkqZBsk/DyS/1jkd6G/li9UXY0= Date: Wed, 25 Mar 2020 13:44:57 +0100 From: Greg KH To: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org, nicholas.johnson-opensource@outlook.com.au Subject: Re: [PATCH v3 2/2] nvmem: core: use is_bin_visible for permissions Message-ID: <20200325124457.GA3511062@kroah.com> References: <20200325122116.15096-1-srinivas.kandagatla@linaro.org> <20200325122116.15096-3-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325122116.15096-3-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2020 at 12:21:16PM +0000, Srinivas Kandagatla wrote: > By using is_bin_visible callback to set permissions will remove a > large list of attribute groups. These group permissions can be > dynamically derived in the callback. > > Also add checks for read/write callbacks and set permissions accordingly. > > As part of this cleanup it does not make sense to have a separate > nvmem-sysfs.c and nvmem.h file anymore, so move all the relevant > data structures and functions to core.c And because of that move, it's impossible to see the real changes made here :( Can you do this in two steps, one do the code/logic changes, and the other do the "move into one file"? That way it is actually reviewable, as it is, it's impossible to do so. I'll go queue up the first patch to make the series smaller :) thanks, greg k-h