From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Lukas Wunner <lukas@wunner.de>,
gregkh@linuxfoundation.org, jslaby@suse.com,
matwey.kornilov@gmail.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] serial: 8250: Add rs485 emulation to 8250_dw
Date: Wed, 25 Mar 2020 16:42:40 +0200 [thread overview]
Message-ID: <20200325144240.GF1922688@smile.fi.intel.com> (raw)
In-Reply-To: <1688171.mLF46rTMEE@diego>
On Wed, Mar 25, 2020 at 02:41:50PM +0100, Heiko Stübner wrote:
> Am Montag, 23. März 2020, 14:41:06 CET schrieb Andy Shevchenko:
> > On Mon, Mar 23, 2020 at 02:17:14PM +0100, Lukas Wunner wrote:
> > > On Mon, Mar 23, 2020 at 09:25:57AM +0100, Heiko Stübner wrote:
> > > > Am Donnerstag, 19. März 2020, 06:40:34 CET schrieb Lukas Wunner:
> >
> > > "rs485-re-gpios" seems a bit cryptic, how about "rs485-rx-enable-gpios"
> > > or "rs485-full-duplex-gpios"?
> >
> > First is in align with well established pin name, second is its elaboration,
> > I'm for any, but last.
>
> So I guess the intersection of both your preferences
> is "rs485-rx-enable-gpios" ... and I did go with that ;-)
> I've now moved my rs485 things over to tty-next + taking
> - "serial: Allow uart_get_rs485_mode() to return errno"
> - "serial: 8250: Support rs485 bus termination GPIO"
> from Lukas' git-tree + fixing other things according to review comments.
>
> I guess I'll now just sit on things till after the 5.7 merge window for
> the depending patches to get posted.
Sounds like a plan, thank you!
Or you can post anyway and resend after merge window. People will have a chance
to look at this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-25 14:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 14:26 [PATCH 0/7] serial: 8250: Add rs485 emulation to 8250_dw Heiko Stuebner
2020-03-18 14:26 ` [PATCH 1/7] serial: 8250: Make em485_rts_after_send() set mctrl according to rts state Heiko Stuebner
2020-03-18 14:26 ` [PATCH 2/7] serial: 8250: add serial_in_poll_timeout helper Heiko Stuebner
2020-03-18 15:09 ` Andy Shevchenko
2020-03-18 14:26 ` [PATCH 3/7] serial: 8250: Handle case port doesn't have TEMT interrupt using em485 Heiko Stuebner
2020-03-18 14:26 ` [PATCH 4/7] serial: 8250: Start rs485 after registering port if rs485 is enabled in probe Heiko Stuebner
2020-03-18 14:26 ` [PATCH 5/7] serial: 8250: handle DTR in rs485 emulation Heiko Stuebner
2020-03-18 14:26 ` [PATCH 6/7] serial: 8250_dw: add em485 support Heiko Stuebner
2020-03-18 15:15 ` Andy Shevchenko
2020-03-18 14:26 ` [PATCH 7/7] serial: 8250_dw: allow enable rs485 at boot time Heiko Stuebner
2020-03-18 15:16 ` Andy Shevchenko
2020-03-18 18:28 ` Heiko Stübner
2020-03-18 18:31 ` Heiko Stübner
2020-03-18 14:43 ` [PATCH 0/7] serial: 8250: Add rs485 emulation to 8250_dw Andy Shevchenko
2020-03-18 15:37 ` Lukas Wunner
2020-03-18 15:54 ` Andy Shevchenko
2020-03-18 18:49 ` Heiko Stübner
2020-03-19 5:40 ` Lukas Wunner
2020-03-23 8:25 ` Heiko Stübner
2020-03-23 13:17 ` Lukas Wunner
2020-03-23 13:41 ` Andy Shevchenko
2020-03-25 13:41 ` Heiko Stübner
2020-03-25 14:42 ` Andy Shevchenko [this message]
2020-03-18 15:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325144240.GF1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.