From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54A5C54FD0 for ; Wed, 25 Mar 2020 15:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C707920714 for ; Wed, 25 Mar 2020 15:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbgCYPBN (ORCPT ); Wed, 25 Mar 2020 11:01:13 -0400 Received: from verein.lst.de ([213.95.11.211]:41195 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727469AbgCYPBM (ORCPT ); Wed, 25 Mar 2020 11:01:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6EDE168B05; Wed, 25 Mar 2020 16:01:08 +0100 (CET) Date: Wed, 25 Mar 2020 16:01:08 +0100 From: Christoph Hellwig To: Theodore Ts'o , Jaegeuk Kim , Chao Yu , Al Viro , Richard Weinberger , linux-xfs@vger.kernel.org Cc: Eric Biggers , linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] fs: avoid double-writing the inode on a lazytime expiration Message-ID: <20200325150108.GA14435@lst.de> References: <20200325122825.1086872-1-hch@lst.de> <20200325122825.1086872-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325122825.1086872-3-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Mar 25, 2020 at 01:28:23PM +0100, Christoph Hellwig wrote: > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -1448,6 +1448,11 @@ static struct dquot **ext4_get_dquots(struct inode *inode) > return EXT4_I(inode)->i_dquot; > } > > +static void ext4_lazytime_expired(struct inode *inode) > +{ > + return ext4_dirty_inode(inode, I_DIRTY_SYNC); > +} FYI: this is inside an #ifdef CONFIG_QUOTA, so I'll have to respin even if the overall approach looks good. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01903C1975A for ; Wed, 25 Mar 2020 15:18:42 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C551D2076A for ; Wed, 25 Mar 2020 15:18:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="DimtcOv+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="b4f+eXe6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C551D2076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jH7nk-0004mZ-Ks; Wed, 25 Mar 2020 15:18:40 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jH7ni-0004mP-OW for linux-f2fs-devel@lists.sourceforge.net; Wed, 25 Mar 2020 15:18:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wI2iEhqXH5FunWtdKhJ1mMQW5BBNtoO0FFpOPXy3Ip4=; b=DimtcOv+n/AOK5S1aaeR7WEpxk wZsyXeEEf16S/Ivc2s1anbkAP58hlstKUBUnJVqA/PxHibfGoqnqb6f0AqDiy4tj6NBIaGN92w+ha DZpTdHzyZ4W4GIBUQAGZYWKu+HS5iXw5eDukilXc6OAahrsrchpRA/AS8RCCrkKsT+zg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wI2iEhqXH5FunWtdKhJ1mMQW5BBNtoO0FFpOPXy3Ip4=; b=b4f+eXe6QfUMYo3ZT1nK4SOJVu 5yM7bivetO+3/QnMUlYTL3cEeHfNLLvq/W7YDD2WfUsOeoboN+/1oAovO79KeWtM1yPltxfU2SdOG 27RFT8rzk/82RxkrxCCJq9OVWCF+jN639RuelvxximpNX3mQsdgDtIv1TicSsElEP9aw=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jH7ng-006ka0-QE for linux-f2fs-devel@lists.sourceforge.net; Wed, 25 Mar 2020 15:18:38 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6EDE168B05; Wed, 25 Mar 2020 16:01:08 +0100 (CET) Date: Wed, 25 Mar 2020 16:01:08 +0100 From: Christoph Hellwig To: Theodore Ts'o , Jaegeuk Kim , Chao Yu , Al Viro , Richard Weinberger , linux-xfs@vger.kernel.org Message-ID: <20200325150108.GA14435@lst.de> References: <20200325122825.1086872-1-hch@lst.de> <20200325122825.1086872-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200325122825.1086872-3-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1jH7ng-006ka0-QE Subject: Re: [f2fs-dev] [PATCH 2/4] fs: avoid double-writing the inode on a lazytime expiration X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Mar 25, 2020 at 01:28:23PM +0100, Christoph Hellwig wrote: > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -1448,6 +1448,11 @@ static struct dquot **ext4_get_dquots(struct inode *inode) > return EXT4_I(inode)->i_dquot; > } > > +static void ext4_lazytime_expired(struct inode *inode) > +{ > + return ext4_dirty_inode(inode, I_DIRTY_SYNC); > +} FYI: this is inside an #ifdef CONFIG_QUOTA, so I'll have to respin even if the overall approach looks good. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E0EC1975A for ; Wed, 25 Mar 2020 15:01:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69B6120714 for ; Wed, 25 Mar 2020 15:01:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KttcECHB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69B6120714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SgQ2iHHVxZAS41yFlCrGrE+2zG6pQzBu5hg2mY9Yb/w=; b=KttcECHBSspaFc CO57/Dm+4mg/pMQ3Esy4qdx57/dxwqpdESh3Wb8Ad76UoyuTDmrbf/0siUValwi/S2nc0y77amgKU zKa/wwqHFqfbcceQ9N9iIILDtw4+oAzzlJlpTT+Ts3Xe9wVYwpv3fKHbNbuS5a3LDHbd15uwgXF78 AB8X04EKZWk8nQ9zrtMf+o66ATmcArOXlkfbPRom4ozUSB9TqR6ybH8iYH6EuCxsQGQe1Ar+01LRU xOfjy8Qbw0EygtWL93vdSeJANsTdglWRBDLbuKECr3ta7jeqgcU4zUwr/qcJn3Lc6MZo7h1a2XPrU mDm+aYKUk54pvXUDK7Eg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH7Ws-00012p-S3; Wed, 25 Mar 2020 15:01:14 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH7Wp-00012M-RC for linux-mtd@lists.infradead.org; Wed, 25 Mar 2020 15:01:13 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6EDE168B05; Wed, 25 Mar 2020 16:01:08 +0100 (CET) Date: Wed, 25 Mar 2020 16:01:08 +0100 From: Christoph Hellwig To: Theodore Ts'o , Jaegeuk Kim , Chao Yu , Al Viro , Richard Weinberger , linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/4] fs: avoid double-writing the inode on a lazytime expiration Message-ID: <20200325150108.GA14435@lst.de> References: <20200325122825.1086872-1-hch@lst.de> <20200325122825.1086872-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200325122825.1086872-3-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200325_080112_028962_8C151960 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Mar 25, 2020 at 01:28:23PM +0100, Christoph Hellwig wrote: > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -1448,6 +1448,11 @@ static struct dquot **ext4_get_dquots(struct inode *inode) > return EXT4_I(inode)->i_dquot; > } > > +static void ext4_lazytime_expired(struct inode *inode) > +{ > + return ext4_dirty_inode(inode, I_DIRTY_SYNC); > +} FYI: this is inside an #ifdef CONFIG_QUOTA, so I'll have to respin even if the overall approach looks good. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/