From: Bjorn Helgaas <helgaas@kernel.org>
To: Shiju Jose <shiju.jose@huawei.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"james.morse@arm.com" <james.morse@arm.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"zhangliguang@linux.alibaba.com" <zhangliguang@linux.alibaba.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Linuxarm <linuxarm@huawei.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
tanxiaofei <tanxiaofei@huawei.com>,
yangyicong <yangyicong@huawei.com>
Subject: Re: [PATCH v5 0/2] ACPI: APEI: Add support to notify the vendor specific HW errors
Date: Wed, 25 Mar 2020 13:31:29 -0500 [thread overview]
Message-ID: <20200325183129.GA29158@google.com> (raw)
In-Reply-To: <84a30116698a49cda1e8b580ee35ce1f@huawei.com>
On Wed, Mar 25, 2020 at 04:27:15PM +0000, Shiju Jose wrote:
> >-----Original Message-----
> >From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> >3) drivers/pci/controller/pcie-hisi-error.c should be next to
> >drivers/pci/controller/dwc/pcie-hisi.c, shouldn't it?
>
> Our hip PCIe controller doesn't use DWC ip.
Ah, I was assuming this pcie-hisi-error.c driver was for the same
device claimed by pcie-hisi.c.
Error drivers like this will have some device-specific knowledge
(e.g., which registers to dump), but I guess they'll always be
used with the generic acpi/pci_root.c driver, right?
It looks like this driver has little or nothing to do with the PCI
core directly. It does include drivers/pci/pci.h, but I'm not sure it
really needs it.
Maybe drivers/pci/controller/ is the best place for it, but I'm not
sure. It's a little confusing because it's not really like the other
things there.
There are some vaguely similar things in drivers/acpi/apei/ and
drivers/acpi/nfit/. And of course there are .acpi_match_table uses
all over the drivers/ tree. Maybe we need a new subdirectory under
drivers/pci? drivers/pci/controller/apei/?
Any thoughts, Rafael?
Bjorn
prev parent reply other threads:[~2020-03-25 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:55 [PATCH v5 0/2] ACPI: APEI: Add support to notify the vendor specific HW errors Shiju Jose
2020-03-25 15:22 ` Bjorn Helgaas
2020-03-25 16:27 ` Shiju Jose
2020-03-25 18:31 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325183129.GA29158@google.com \
--to=helgaas@kernel.org \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=yangyicong@huawei.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.