From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Marzinski Subject: Re: [PATCH 2/3] libmutipath: don't close fd on dm_lib_release Date: Wed, 25 Mar 2020 17:00:45 -0500 Message-ID: <20200325220045.GC17313@octiron.msp.redhat.com> References: <1585083834-14237-1-git-send-email-bmarzins@redhat.com> <1585083834-14237-2-git-send-email-bmarzins@redhat.com> <20200325205255.GB17313@octiron.msp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20200325205255.GB17313@octiron.msp.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: Martin Wilck Cc: "dm-devel@redhat.com" List-Id: dm-devel.ids On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski wrote: > On Wed, Mar 25, 2020 at 03:16:50PM +0000, Martin Wilck wrote: > > On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > >=20 > > AFAICS, this function has been in libdm since 1.02.111. We support > > 1.02.89 (if all features enabled, otherwise even older). Perhaps we > > should make this function call conditional on the libdm verson? > >=20 > > But perhaps more importantly, why do we still need to call > > dm_lib_release()? AFAICS it's only needed for systems that have no udev > > support for creating device nodes (to call update_devs() via > > dm_lib_release()), and we don't support that anymore anyway, do we?=20 > >=20 > > Since 26c4bb0, we're always setting the > > DM_UDEV_DISABLE_LIBRARY_FALLBACK flag, and the cookie, too > > (we aren't setting it for DM_DEVICE_RELOAD, but it isn't needed for > > that, either, since no device nodes need to be created or removed); so > > dm_lib_release() should really have no effect. > >=20 > > Regards > > Martin >=20 > Good call. I'll redo this patch. Actually, I've changed my mind. Calling dm_lib_release() lets us release the memory that device-mapper uses to store all the node ops that it was saving up. Without calling dm_lib_release(), AFAICS, that memory keeps growing until the daemon exits. -Ben =20 > -Ben >=20 > >=20 > > --=20 > > Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 > > SUSE Software Solutions Germany GmbH > > HRB 36809, AG N=FCrnberg GF: Felix > > Imend=F6rffer > >=20 >=20 > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel