From: Baoquan He <bhe@redhat.com>
To: Waiman Long <longman@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org
Subject: Re: [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t
Date: Thu, 26 Mar 2020 12:02:24 +0800 [thread overview]
Message-ID: <20200326040224.GK3039@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20200326022617.26208-1-longman@redhat.com>
On 03/25/20 at 10:26pm, Waiman Long wrote:
> Both bootmem_data and bootmem_data_t structures are no longer defined.
> Remove the dummy forward declarations.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
> arch/alpha/include/asm/mmzone.h | 2 --
> include/linux/mmzone.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/arch/alpha/include/asm/mmzone.h b/arch/alpha/include/asm/mmzone.h
> index 7ee144f484f1..9b521c857436 100644
> --- a/arch/alpha/include/asm/mmzone.h
> +++ b/arch/alpha/include/asm/mmzone.h
> @@ -8,8 +8,6 @@
>
> #include <asm/smp.h>
>
> -struct bootmem_data_t; /* stupid forward decl. */
> -
> /*
> * Following are macros that are specific to this numa platform.
> */
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 462f6873905a..5c388eced889 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -706,7 +706,6 @@ struct deferred_split {
> * Memory statistics and page replacement data structures are maintained on a
> * per-zone basis.
> */
> -struct bootmem_data;
> typedef struct pglist_data {
> struct zone node_zones[MAX_NR_ZONES];
> struct zonelist node_zonelists[MAX_ZONELISTS];
Looks good to me.
Reviewed-by: Baoquan He <bhe@redhat.com>
next prev parent reply other threads:[~2020-03-26 4:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 2:26 [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t Waiman Long
2020-03-26 4:02 ` Baoquan He [this message]
2020-03-26 14:25 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326040224.GK3039@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.