Re: [PATCH v2] staging: octeon-usb: line over 80 characters

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 26, 2020 at 01:31:55AM +0300, Gokce Kuler wrote:
> Code readability increased for 80 character limit.
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

What changed from v1?  Always put that below the --- line

> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index dbafd46..de3b082 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2641,9 +2641,9 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
>  						     hcintmsk.u32);
>  				usbc_hcchar.s.chdis = 1;
>  				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCCHARX(
> -						     channel, usb->index),
> -						     usbc_hcchar.u32);
> +						CVMX_USBCX_HCCHARX(channel,
> +						       	usb->index),
> +						usbc_hcchar.u32);

No, that is harder to read now, you can try to get closer, but I would
just leave this alone for now as many people keep messing with it :)

thanks,

greg k-h