From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Fam Zheng <fam@euphon.net>,
integration@gluster.org, sheepdog@lists.wpkg.org,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>,
Jeff Cody <codyprime@gmail.com>, Stefan Weil <sw@weilnetz.de>,
Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Maxim Levitsky <mlevitsk@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Liu Yuan <namei.unix@gmail.com>, Max Reitz <mreitz@redhat.com>,
Jason Dillaman <dillaman@redhat.com>
Subject: Re: [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers
Date: Thu, 26 Mar 2020 14:28:28 +0100 [thread overview]
Message-ID: <20200326132828.GC7391@linux.fritz.box> (raw)
In-Reply-To: <922a6eb5-cb33-d2e4-ba0b-15078d1a6c59@redhat.com>
Am 26.03.2020 um 14:20 hat Eric Blake geschrieben:
> > +++ b/block/file-posix.c
> > @@ -3513,6 +3513,8 @@ static BlockDriver bdrv_host_device = {
> > .bdrv_reopen_prepare = raw_reopen_prepare,
> > .bdrv_reopen_commit = raw_reopen_commit,
> > .bdrv_reopen_abort = raw_reopen_abort,
> > + .bdrv_co_create_opts = bdrv_co_create_opts_simple,
> > + .create_opts = &bdrv_create_opts_simple,
>
> I'd drop the leading & for consistency with the rest of this struct
> initializer.
This one isn't a function pointer, so I think the & is necessary.
Kevin
next prev parent reply other threads:[~2020-03-26 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 1:12 [PATCH 0/2] Fix the generic image creation code Maxim Levitsky
2020-03-26 1:12 ` [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create Maxim Levitsky
2020-03-26 13:18 ` Eric Blake
2020-03-26 13:22 ` Maxim Levitsky
2020-03-26 13:27 ` Eric Blake
2020-03-26 1:12 ` [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers Maxim Levitsky
2020-03-26 11:20 ` Max Reitz
2020-03-26 13:20 ` Eric Blake
2020-03-26 13:28 ` Kevin Wolf [this message]
2020-03-26 13:35 ` Eric Blake
2020-03-26 13:39 ` Max Reitz
2020-03-26 13:30 ` Maxim Levitsky
2020-03-26 10:55 ` [PATCH 0/2] Fix the generic image creation code Denis V. Lunev
2020-03-26 12:23 ` Max Reitz
2020-03-26 13:38 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326132828.GC7391@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=codyprime@gmail.com \
--cc=den@openvz.org \
--cc=dillaman@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=integration@gluster.org \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.