From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23C3C43331 for ; Thu, 26 Mar 2020 13:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FCB52076A for ; Thu, 26 Mar 2020 13:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbgCZNvz (ORCPT ); Thu, 26 Mar 2020 09:51:55 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38106 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbgCZNvy (ORCPT ); Thu, 26 Mar 2020 09:51:54 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHSsv-003Jcf-BF; Thu, 26 Mar 2020 13:49:25 +0000 Date: Thu, 26 Mar 2020 13:49:25 +0000 From: Al Viro To: Michael Ellerman Cc: Sachin Sant , linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, Linux Next Mailing List Subject: Re: [powerpc] Intermittent crashes ( link_path_walk) with linux-next Message-ID: <20200326134925.GP23230@ZenIV.linux.org.uk> References: <1CB4E533-FD97-4C39-87ED-4857F3AB9097@linux.vnet.ibm.com> <87h7ybwdih.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7ybwdih.fsf@mpe.ellerman.id.au> Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Mar 26, 2020 at 10:40:06PM +1100, Michael Ellerman wrote: > > The code in question (link_path_walk() in fs/namei.c ) was recently changed by > > following commit: > > > > commit 881386f7e46a: > > link_path_walk(): sample parent's i_uid and i_mode for the last component > > That and about 10 other commits. > > Unless Al can give us a clue we'll need to bisect. Already fixed yesterday. It's not link_path_walk(), it's handle_dots() ignoring an error returned by step_into(). commit 5e3c3570ec97 is the broken one; commit 20971012f63e is its variant with the fix folded in. So next-20200325 has the bug and next-20200326 should have it fixed. Could you check the current -next and see if you still observe that crap? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEDFC43331 for ; Thu, 26 Mar 2020 13:58:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7025206E6 for ; Thu, 26 Mar 2020 13:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7025206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48p65n2015zDqjW for ; Fri, 27 Mar 2020 00:58:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=ftp.linux.org.uk (client-ip=195.92.253.2; helo=zeniv.linux.org.uk; envelope-from=viro@ftp.linux.org.uk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48p5xz4h1pzDqgj for ; Fri, 27 Mar 2020 00:51:48 +1100 (AEDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHSsv-003Jcf-BF; Thu, 26 Mar 2020 13:49:25 +0000 Date: Thu, 26 Mar 2020 13:49:25 +0000 From: Al Viro To: Michael Ellerman Subject: Re: [powerpc] Intermittent crashes ( link_path_walk) with linux-next Message-ID: <20200326134925.GP23230@ZenIV.linux.org.uk> References: <1CB4E533-FD97-4C39-87ED-4857F3AB9097@linux.vnet.ibm.com> <87h7ybwdih.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7ybwdih.fsf@mpe.ellerman.id.au> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sachin Sant , linux-fsdevel@vger.kernel.org, Linux Next Mailing List , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 26, 2020 at 10:40:06PM +1100, Michael Ellerman wrote: > > The code in question (link_path_walk() in fs/namei.c ) was recently changed by > > following commit: > > > > commit 881386f7e46a: > > link_path_walk(): sample parent's i_uid and i_mode for the last component > > That and about 10 other commits. > > Unless Al can give us a clue we'll need to bisect. Already fixed yesterday. It's not link_path_walk(), it's handle_dots() ignoring an error returned by step_into(). commit 5e3c3570ec97 is the broken one; commit 20971012f63e is its variant with the fix folded in. So next-20200325 has the bug and next-20200326 should have it fixed. Could you check the current -next and see if you still observe that crap?