From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: kreijack@inwind.it, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: btrfs-progs: RAID1C3/C4 missing some info in btrfs_raid_array
Date: Thu, 26 Mar 2020 18:36:39 +0100 [thread overview]
Message-ID: <20200326173638.GL5920@suse.cz> (raw)
In-Reply-To: <eaab47b8-4026-f5f2-5e4a-723c990cfbca@gmx.com>
On Thu, Mar 26, 2020 at 09:09:41AM +0800, Qu Wenruo wrote:
> On 2020/3/26 上午2:57, Goffredo Baroncelli wrote:
> > [BTRFS_RAID_RAID1C4] = {
> > .sub_stripes = 1,
> > .dev_stripes = 1,
> > .devs_max = 4,
> > .devs_min = 4,
> > .tolerated_failures = 3,
> > .devs_increment = 4,
> > .ncopies = 4,
> > },
> > [BTRFS_RAID_DUP] = {
> > [...]
> >
> > As you can see the items BTRFS_RAID_RAID1C3 and BTRFS_RAID_RAID1C4,
> > missed of the fields '.raid_name' and '.bg_flag';
> > if you look at BTRFS_RAID_RAID1 item, it has both the fields filled with
> > "raid1" and "BTRFS_BLOCK_GROUP_RAID1".
>
> Oh, you're right.
>
> AFAIK there is no special reason not to add these members.
Right, I forgot to add them back then.
prev parent reply other threads:[~2020-03-26 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 20:00 btrfs-progs: RAID1C3/C4 missing some info in btrfs_raid_array Goffredo Baroncelli
2020-03-25 0:12 ` Qu Wenruo
2020-03-25 18:57 ` Goffredo Baroncelli
2020-03-26 1:09 ` Qu Wenruo
2020-03-26 17:36 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326173638.GL5920@suse.cz \
--to=dsterba@suse.cz \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.