From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Avihai Horon <avihaih@mellanox.com>,
Eli Cohen <eli@dev.mellanox.co.il>,
linux-rdma@vger.kernel.org, Maor Gottlieb <maorg@mellanox.com>,
Roland Dreier <rolandd@cisco.com>
Subject: Re: [PATCH rdma-next] RDMA/cm: Update num_paths in cma_resolve_iboe_route error flow
Date: Thu, 26 Mar 2020 15:05:51 -0300 [thread overview]
Message-ID: <20200326180551.GA10496@ziepe.ca> (raw)
In-Reply-To: <20200318101741.47211-1-leon@kernel.org>
On Wed, Mar 18, 2020 at 12:17:41PM +0200, Leon Romanovsky wrote:
> From: Avihai Horon <avihaih@mellanox.com>
>
> After a successful allocation of path_rec, num_paths is set to 1,
> but any error after such allocation will leave num_paths uncleared.
>
> This causes to de-referencing a NULL pointer later on. Hence,
> num_paths needs to be set back to 0 if such an error occurs.
>
> The following crash from syzkaller revealed it.
..
>
> Fixes: 3c86aa70bf67 ("RDMA/cm: Add RDMA CM support for IBoE devices")
> Signed-off-by: Avihai Horon <avihaih@mellanox.com>
> Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Applied to for-next
Thanks,
Jason
prev parent reply other threads:[~2020-03-26 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 10:17 [PATCH rdma-next] RDMA/cm: Update num_paths in cma_resolve_iboe_route error flow Leon Romanovsky
2020-03-26 18:05 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326180551.GA10496@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=avihaih@mellanox.com \
--cc=dledford@redhat.com \
--cc=eli@dev.mellanox.co.il \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@mellanox.com \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.