From: Rafael Aquini <aquini@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
Eric B Munson <emunson@akamai.com>
Subject: Re: [PATCH] tools/testing/selftests/vm/mlock2-tests: fix mlock2 false-negative errors
Date: Thu, 26 Mar 2020 16:16:38 -0400 [thread overview]
Message-ID: <20200326201638.GA4605@optiplex-lnx> (raw)
In-Reply-To: <20200326125809.64d92920bcd481cf15207855@linux-foundation.org>
On Thu, Mar 26, 2020 at 12:58:09PM -0700, Andrew Morton wrote:
> On Thu, 26 Mar 2020 07:49:09 +0100 Michal Hocko <mhocko@kernel.org> wrote:
>
> > On Wed 25-03-20 17:49:49, Andrew Morton wrote:
> > > On Tue, 24 Mar 2020 11:49:10 -0400 Rafael Aquini <aquini@redhat.com> wrote:
> > >
> > > > Thanks Michal!
> > > >
> > > >
> > > > Acked-by: Rafael Aquini <aquini@redhat.com>
> > >
> > > I'll add
> > > Fixes: 9c4e6b1a7027f ("mm, mlock, vmscan: no more skipping pagevecs")
> >
> > Wouldn't be this misleading? It would suggest that this commit is
> > somehow incorrect. I would consider b3b0d09c7a23 ("selftests: vm: add
> > tests for lock on fault") to be a better fit.
>
> Yes, it's a bit misleading.
>
> Or maybe not. b3b0d09c7a23 was merged in 2015 and worked OK (afaik)
> until 9c4e6b1a7027f came along in 2020. So arguably, 2020's
> 9c4e6b1a7027f was correct but incomplete, since it failed to repair the
> impact upon the test code.
>
That's correct, and it was my reading, as well.
> I don't think that kernels prior to 2020's 9c4e6b1a7027f require this
> change(?), so we only need to backport this into 5.6.x, which is what
> my proposed Fixes: and cc:stable expresses.
>
Agreed
-- Rafael
next prev parent reply other threads:[~2020-03-26 20:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 1:35 [PATCH] tools/testing/selftests/vm/mlock2-tests: fix mlock2 false-negative errors Rafael Aquini
2020-03-22 1:43 ` Andrew Morton
2020-03-22 2:03 ` Rafael Aquini
2020-03-22 4:31 ` Andrew Morton
2020-03-22 5:41 ` Rafael Aquini
2020-03-22 16:40 ` Shakeel Butt
2020-03-22 16:36 ` Shakeel Butt
2020-03-23 7:52 ` Michal Hocko
2020-03-23 14:42 ` Rafael Aquini
2020-03-23 14:51 ` Michal Hocko
2020-03-23 15:02 ` Rafael Aquini
2020-03-23 15:12 ` Michal Hocko
2020-03-23 15:41 ` Rafael Aquini
2020-03-23 15:51 ` Michal Hocko
2020-03-23 15:54 ` Rafael Aquini
2020-03-24 15:42 ` Michal Hocko
2020-03-24 15:49 ` Rafael Aquini
2020-03-26 0:49 ` Andrew Morton
2020-03-26 2:22 ` Rafael Aquini
2020-03-26 6:49 ` Michal Hocko
2020-03-26 19:58 ` Andrew Morton
2020-03-26 20:16 ` Rafael Aquini [this message]
2020-03-26 20:19 ` Rafael Aquini
2020-03-22 16:31 ` Shakeel Butt
2020-03-23 14:16 ` Rafael Aquini
2020-03-23 14:29 ` Michal Hocko
2020-03-23 14:55 ` Rafael Aquini
2020-03-23 15:01 ` Michal Hocko
2020-03-23 15:07 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326201638.GA4605@optiplex-lnx \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=emunson@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.