From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] Avoid zero or negative int results in calculations
Date: Thu, 26 Mar 2020 21:32:22 +0100 [thread overview]
Message-ID: <20200326203222.GA19445@dell5510> (raw)
In-Reply-To: <20200326134603.GA5185@yuki.lan>
Hi,
> > > Define BUF_SIZE smaller than BLOCKSIZE for possitive offset result
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > BTW it significantly prolongs the run, but IMHO ok.
> Longer testruns should be avoided unless there is a good reason for it.
+1. Although the commit message does not describe what it fixes, it obviously
fixes something. It'd be nice to explain it a bit.
Before:
real 0m0,013s
user 0m0,004s
sys 0m0,009s
After (slowed by second commit, not by the rewrite):
real 0m0,402s
user 0m0,042s
sys 0m0,360s
Looks like the smaller buffer the faster it is.
I haven't tested other Martin's fix reported later.
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-26 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 13:38 [LTP] [PATCH 2/2] Avoid zero or negative int results in calculations Jozef Pupava
2020-03-26 8:45 ` Petr Vorel
2020-03-26 13:46 ` Cyril Hrubis
2020-03-26 20:32 ` Petr Vorel [this message]
2020-03-27 9:57 ` Petr Vorel
2020-03-27 10:15 ` Jozef Pupava
2020-03-27 10:17 ` Martin Doucha
2020-03-27 15:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326203222.GA19445@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.