All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
Date: Thu, 26 Mar 2020 21:37:35 +0100	[thread overview]
Message-ID: <20200326203735.GW22325@scaer> (raw)
In-Reply-To: <b4c0ce8d-0c24-1f5b-bef8-3f900150759c@smile.fr>

Romain, All,

On 2020-03-26 21:30 +0100, Romain Naour spake thusly:
> Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
> > On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
> >> The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
> > 
> > For the libmnl part, we already have a pending patch:
> >     https://patchwork.ozlabs.org/patch/1251106/
> > 
> >> But to keep the same 'Connman' setup as previous setup, we need to
> >> explicitly disable the 'WireGuard' support.
> >>
> >> The support of all the new 'Connman' options will be added by follow-up commits
> >> (or patches).
> >>
> >> Fixes:
> >> http://autobuild.buildroot.org/?reason=connman-1.38
> > 
> > AFAICS, all the failures have iptable support enabled, which should be
> > solved by the patch above...
> > 
> > I don't see how wireguard fits in the picture...
> 
> Sorry but our build still failing on current master with:

I was not trying to imply that master was fixed, just that we already
had a pending patch about libmnl.

[--SNIP--]
> It's unfortunate but we have several issues with the same error.
> The case fixed by James Hilliard is when BR2_PACKAGE_CONNMAN_NFTABLES is set.

Damn, iptables, not nftables. Your patch is still on the table, then.
;-)

Regards,
Yann E. MORIN.

> Best regards,
> Romain
> 
> > 
> > Regards,
> > Yann E. MORIN.
> > 
> >> Signed-off-by: Mikael Bourhis-Cloarec <mikael.bourhis@smile.fr>
> >> ---
> >> Changes v1 -> v2 (after review of Romain Naour)
> >>   - this fix concerns all Arch, not only x86_64
> >>   - do not add a new '_CONF_OPTS' line but use the previous one
> >>
> >>  package/connman/connman.mk | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> >> index 701be8b59d..62ae919862 100644
> >> --- a/package/connman/connman.mk
> >> +++ b/package/connman/connman.mk
> >> @@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES
> >>  CONNMAN_LICENSE = GPL-2.0
> >>  CONNMAN_LICENSE_FILES = COPYING
> >>  
> >> -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc
> >> +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \
> >> +	--disable-wireguard
> >>  
> >>  ifeq ($(BR2_INIT_SYSTEMD),y)
> >>  CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
> >> -- 
> >> 2.20.1
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> > 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-03-26 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 15:25 [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support Mikael Bourhis-Cloarec
2020-03-26 17:01 ` Romain Naour
2020-03-26 19:01 ` Yann E. MORIN
2020-03-26 20:30   ` Romain Naour
2020-03-26 20:37     ` Yann E. MORIN [this message]
2020-03-26 20:43       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200326203735.GW22325@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.