From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: John Wyatt <jbwyatt4@gmail.com>
Cc: Quentin Deslandes <quentin.deslandes@itdev.co.uk>,
Julia Lawall <julia.lawall@inria.fr>,
Stefano Brivio <sbrivio@redhat.com>,
"outreachy-kernel@googlegroups.com"
<outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH 1/2] staging: vt6656: remove unneeded variable: ret
Date: Fri, 27 Mar 2020 07:34:21 +0100 [thread overview]
Message-ID: <20200327063421.GG1601217@kroah.com> (raw)
In-Reply-To: <61efe5ca2f1cb286d697504828b232455f2be44f.camel@gmail.com>
On Thu, Mar 26, 2020 at 04:26:13PM -0700, John Wyatt wrote:
> On Wed, 2020-03-25 at 09:15 +0000, Quentin Deslandes wrote:
> > On 03/24/20 17:32:01, John Wyatt wrote:
> > > I do not know what these functions do.
> > >
> > > There is no function documentation for:
> > > vnt_exit_deep_sleep
> > > vnt_mac_reg_bits_on
> > > vnt_mac_reg_bits_off
> >
> > I understand, however discarding the return value of functions that
> > could
> > fail is not the best thing to do. Whatever those 3 functions are
> > doing,
> > you should rely on their return code, and if one of those fail,
> > vnt_radio_power_on() should fail too.
> >
> > > I am a new kernel developer intern with the Outreachy program. I am
> > > trying to fix a style issue reported by Coccinelle. I do not have
> > > that
> > > much experience with writing drivers yet.
> >
> > Don't worry, I'm not that experienced either. If my request is out of
> > scope for an Outreachy mentee, a more experienced contributor will
> > pop
> > in the discussion.
>
> To any of the Outreachy mentors please advise on what to do.
>
> I was asked by Greg Kroah-Hartman to make this patch set, but Quentin
> Deslandes asked to return undocumented return codes for this patch to
> solve this coccinelle issue.
What do you mean by "undocumented return codes"? Just pick an error
value that you think matches what went wrong and try that. Worst thing
is we review the patch and tell you to pick a different one :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-27 6:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 6:45 [PATCH 0/2] staging: vt6656: change function from always returning 0 to void John B. Wyatt IV
2020-03-24 6:45 ` [PATCH 1/2] staging: vt6656: remove unneeded variable: ret John B. Wyatt IV
2020-03-24 10:03 ` Quentin Deslandes
2020-03-25 0:32 ` John Wyatt
2020-03-25 9:15 ` Quentin Deslandes
2020-03-26 23:26 ` John Wyatt
2020-03-27 3:52 ` [Outreachy kernel] " Stefano Brivio
2020-03-27 21:41 ` John Wyatt
2020-03-27 6:34 ` Greg Kroah-Hartman [this message]
2020-03-27 21:44 ` John Wyatt
2020-03-24 6:45 ` [PATCH 2/2] staging: vt6656: change unused int return value to void John B. Wyatt IV
2020-03-24 17:28 ` [PATCH 0/2] staging: vt6656: change function from always returning 0 " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327063421.GG1601217@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jbwyatt4@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=quentin.deslandes@itdev.co.uk \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.