Re: [PATCH] staging: ralink-gdma: add blank line

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Mar 27, 2020 at 01:13:35AM +0300, Gokce Kuler wrote:
> Add missing blank line after declarations to follow 
> the Linux kernel coding conventions.
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index eabf109..b43f37f2 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -123,6 +123,7 @@ struct gdma_dma_dev {
>  	void __iomem *base;
>  	struct tasklet_struct task;
>  	volatile unsigned long chan_issued;
> +
>  	atomic_t cnt;
>  
>  	struct gdma_dmaengine_chan chan[];

No, you need to remove a blank line here to get this right, not add one.
Look at the list of variables...

thanks,

greg k-h