From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Saravana Kannan <saravanak@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, kernel-team@android.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1] driver core: Set fw_devlink to "permissive" behavior by default
Date: Fri, 27 Mar 2020 12:30:41 +0100 [thread overview]
Message-ID: <20200327113041.GA1708599@kroah.com> (raw)
In-Reply-To: <bd8b42d3-a35a-cc8e-0d06-2899416c2996@samsung.com>
On Fri, Mar 27, 2020 at 11:25:48AM +0100, Marek Szyprowski wrote:
> Hi,
>
> On 2020-03-21 22:03, Saravana Kannan wrote:
> > Set fw_devlink to "permissive" behavior by default so that device links
> > are automatically created (with DL_FLAG_SYNC_STATE_ONLY) by scanning the
> > firmware.
> >
> > This ensures suppliers get their sync_state() calls only after all their
> > consumers have probed successfully. Without this, suppliers will get
> > their sync_state() calls at late_initcall_sync() even if their consuer
> >
> > Ideally, we'd want to set fw_devlink to "on" or "rpm" by default. But
> > that needs more testing as it's known to break some corner case
> > drivers/platforms.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Frank Rowand <frowand.list@gmail.com>
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
>
> This patch has just landed in linux-next 20200326. Sadly it breaks
> booting of the Raspberry Pi3b and Pi4 boards, either in 32bit or 64bit
> mode. There is no warning nor panic message, just a silent freeze. The
> last message shown on the earlycon is:
>
> [ 0.893217] Serial: 8250/16550 driver, 1 ports, IRQ sharing enabled
Ugh, not good.
Saravana, mind if I revert this?
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-27 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200327102554eucas1p1f848633a39f8e158472506b84877f98c@eucas1p1.samsung.com>
2020-03-21 21:03 ` [RFC PATCH v1] driver core: Set fw_devlink to "permissive" behavior by default Saravana Kannan
2020-03-27 10:25 ` Marek Szyprowski
2020-03-27 11:30 ` Greg Kroah-Hartman [this message]
2020-03-27 15:21 ` Greg Kroah-Hartman
2020-03-27 18:30 ` Saravana Kannan
2020-03-30 6:20 ` Marek Szyprowski
2020-03-30 18:41 ` Saravana Kannan
2020-03-31 2:28 ` [PATCH v1] driver core: Fix handling of fw_devlink=permissive Saravana Kannan
2020-03-31 5:43 ` Marek Szyprowski
2020-03-31 6:18 ` Saravana Kannan
2020-03-31 7:07 ` Marek Szyprowski
2020-03-31 7:29 ` Greg Kroah-Hartman
2020-04-16 18:25 ` Saravana Kannan
2020-04-28 15:52 ` Greg Kroah-Hartman
2020-04-28 18:27 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327113041.GA1708599@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.