All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gokce Kuler <gokcekuler@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v4] staging: qlge: Adjust end of block comment
Date: Fri, 27 Mar 2020 14:52:23 +0100	[thread overview]
Message-ID: <20200327135223.GA2433128@kroah.com> (raw)
In-Reply-To: <20200327134906.GA10286@siyah2>

On Fri, Mar 27, 2020 at 04:49:06PM +0300, Gokce Kuler wrote:
> Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions.
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>

Take some time, and review what you did here and see that there is no
rush.  Go make a cup of tea/coffee/beer/whatever and take a pause.

Then, fix the line-wrap, add a new line before the signed-off-by: line,
and run the result through checkpatch.pl to ensure that all looks good
before sending it out again.

thanks,

greg k-h


      reply	other threads:[~2020-03-27 13:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 13:49 [PATCH v4] staging: qlge: Adjust end of block comment Gokce Kuler
2020-03-27 13:52 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327135223.GA2433128@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gokcekuler@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.