From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17867C43331 for ; Fri, 27 Mar 2020 15:52:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E79D020748 for ; Fri, 27 Mar 2020 15:52:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E79D020748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9134689FA7; Fri, 27 Mar 2020 15:52:58 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79B4689FA7 for ; Fri, 27 Mar 2020 15:52:56 +0000 (UTC) IronPort-SDR: CxQzHvFsMdn4ugE/LJpYeC5ylQdCxC2p2RF+TxqMGFZa2cTEgSmzLNEO9FQIDR4AxLbY4TN6Z8 DMD776TID+Mg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 08:52:55 -0700 IronPort-SDR: vR/S3VN7Jjc9tS7xEji06v7cFa0L8Nzpncb/8zuRP4TtO+HgK4UTJu9YqaL4kuJxm/DJwRpunp VhKaeM/HRLKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,313,1580803200"; d="scan'208";a="251180231" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 27 Mar 2020 08:52:53 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 27 Mar 2020 17:52:53 +0200 Date: Fri, 27 Mar 2020 17:52:53 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Kai Vehmanen Message-ID: <20200327155253.GH13686@intel.com> References: <20200324153212.6303-1-kai.vehmanen@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200324153212.6303-1-kai.vehmanen@linux.intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915: use forced codec wake on all gen9+ platforms X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 24, 2020 at 05:32:12PM +0200, Kai Vehmanen wrote: > Commit 632f3ab95fe2 ("drm/i915/audio: add codec wakeup override > enabled/disable callback"), added logic to toggle Codec Wake on gen9. > This is used by audio driver when it resets the HDA controller. > = > It seems explicit toggling of the wakeline can help to fix problems > with probe failing on some gen12 platforms. And based on specs, there > is no reason why this programming sequence should not be applied to all > gen9+ platforms. No side-effects are seen on gen10/11. So apply > the wake-logic to all gen9+ platforms. > = > Link: https://github.com/thesofproject/linux/issues/1847 > Signed-off-by: Kai Vehmanen Pushed to dinq. Thanks. > --- > drivers/gpu/drm/i915/display/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm= /i915/display/intel_audio.c > index 62f234f641de..950160f1a89f 100644 > --- a/drivers/gpu/drm/i915/display/intel_audio.c > +++ b/drivers/gpu/drm/i915/display/intel_audio.c > @@ -931,7 +931,7 @@ static void i915_audio_component_codec_wake_override(= struct device *kdev, > unsigned long cookie; > u32 tmp; > = > - if (!IS_GEN(dev_priv, 9)) > + if (INTEL_GEN(dev_priv) < 9) > return; > = > cookie =3D i915_audio_component_get_power(kdev); > -- = > 2.17.1 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx