From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: simplify queue allocation Date: Fri, 27 Mar 2020 17:17:54 +0100 Message-ID: <20200327161754.GA19480@lst.de> References: <20200327083012.1618778-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:51989 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727560AbgC0QR5 (ORCPT ); Fri, 27 Mar 2020 12:17:57 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Jens Axboe Cc: Christoph Hellwig , linux-bcache@vger.kernel.org, linux-block@vger.kernel.org On Fri, Mar 27, 2020 at 09:53:16AM -0600, Jens Axboe wrote: > On 3/27/20 2:30 AM, Christoph Hellwig wrote: > > Hi Jens, > > > > this series ensures all allocated queues have a valid ->make_request_fn > > and also nicely consolidates the code for allocating queues. > > This seems fine to me, but might be a good idea to shuffle 4/5 as the > last one, and do that one inside the merge window to avoid any potential > silly merge conflicts. they should be trivial to reorder if you want to skip patch 4 for now. But looking at current linux-next there isn't any conflict yet, and I don't expect one as most block drivers go through the block tree anyway.