From: Tony Jones <tonyj@suse.de>
To: Paul Clarke <pc@us.ibm.com>
Cc: linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: update docs regarding kernel/user space unwinding
Date: Fri, 27 Mar 2020 13:09:34 -0700 [thread overview]
Message-ID: <20200327200934.GB2715@suse.de> (raw)
In-Reply-To: <38ba2caa-dadd-52c4-c6ea-5e01b7e59ee2@us.ibm.com>
On Thu, Mar 26, 2020 at 04:32:26PM -0500, Paul Clarke wrote:
> > + and 'lbr'. The value 'dwarf' is effective only if libunwind
> > + (or a recent version of libdw) is present on the system;
> > + the value 'lbr' only works for certain cpus. The method for
> > + kernel space is controlled not by this option but by the
> > + kernel config (CONFIG_UNWINDER_*).
>
> Your changes are just copying the old text, so this isn't a criticism of your patches.
>
> Do we have information to replace "a recent version of libdw", which will quickly get stale?
Hi Paul.
The original "(libunwind or a recent version of libdw)" text was from Feb 2016. So a while ago.
bd0419e2a5a9f requires >= 0.157 but this is for probing. 0a4f2b6a3ba50 specifies >= 0.158 but I see no mention of
why in the commit but since it's from 2014 and elfutils is now at 0.178, I think it's safe to just remove the
reference.
As an aside, there is a lot of detail in perf-config.txt that's available in some of the other subcomands help files.
Seems a good way for things to get stale. It could also do with some grammatical cleanup.
Tony
next prev parent reply other threads:[~2020-03-27 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 16:40 [PATCH] perf tools: update docs regarding kernel/user space unwinding Tony Jones
2020-03-25 19:17 ` Arnaldo Carvalho de Melo
2020-03-25 19:29 ` Tony Jones
2020-03-26 21:32 ` Paul Clarke
2020-03-27 20:09 ` Tony Jones [this message]
2020-03-27 20:17 ` Arnaldo Melo
2020-03-27 20:33 ` Tony Jones
2020-04-04 8:41 ` [tip: perf/urgent] perf callchain: Update " tip-bot2 for Tony Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327200934.GB2715@suse.de \
--to=tonyj@suse.de \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=pc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.