From: Jules Irenge <jbi.octave@gmail.com>
To: julia.lawall@lip6.fr
Cc: boqun.feng@gmail.com, Jules Irenge <jbi.octave@example.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org (open list:SCHEDULER)
Subject: [PATCH 02/10] sched/topology: Replace 1 and 0 by boolean value
Date: Fri, 27 Mar 2020 21:23:49 +0000 [thread overview]
Message-ID: <20200327212358.5752-3-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200327212358.5752-1-jbi.octave@gmail.com>
From: Jules Irenge <jbi.octave@example.com>
Coccinelle reports a warning inside sched_energy_aware_handler()
WARNING: Assignment of 0/1 to bool variable
To fix this, 1 is replaced by true and 0 by false.
Given that variable sched_energy_update is of bool type.
This fixes the warnings.
Signed-off-by: Jules Irenge <jbi.octave@example.com>
---
kernel/sched/topology.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index dfb64c08a407..9d70cc68e549 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -221,9 +221,9 @@ int sched_energy_aware_handler(struct ctl_table *table, int write,
state = static_branch_unlikely(&sched_energy_present);
if (state != sysctl_sched_energy_aware) {
mutex_lock(&sched_energy_mutex);
- sched_energy_update = 1;
+ sched_energy_update = true;
rebuild_sched_domains();
- sched_energy_update = 0;
+ sched_energy_update = false;
mutex_unlock(&sched_energy_mutex);
}
}
--
2.25.1
next prev parent reply other threads:[~2020-03-27 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/10>
[not found] ` <20200327212358.5752-1-jbi.octave@gmail.com>
2020-03-27 21:23 ` [PATCH 01/10] locking/rtmutex: Remove Comparison to bool Jules Irenge
2020-03-28 11:28 ` Thomas Gleixner
2020-03-28 12:02 ` Jules Irenge
2020-03-28 12:44 ` Thomas Gleixner
2020-03-27 21:23 ` Jules Irenge [this message]
2020-03-30 11:27 ` [PATCH 02/10] sched/topology: Replace 1 and 0 by boolean value Peter Zijlstra
2020-04-03 16:23 ` Jules Irenge
2020-03-27 21:23 ` [PATCH 03/10] cpu: Remove Comparison to bool Jules Irenge
2020-03-28 11:29 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 04/10] irq: Replace 1 by true Jules Irenge
2020-03-27 21:23 ` [PATCH 05/10] softirq: Replace BUG() after if statement with BUG_ON Jules Irenge
2020-03-28 11:22 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 06/10] rcu: Replace assigned pointer ret value by corresponding boolean value Jules Irenge
2020-03-30 21:12 ` Paul E. McKenney
2020-03-27 21:23 ` [PATCH 07/10] sched/fair: Replace 1 and 0 by " Jules Irenge
2020-03-30 11:29 ` Peter Zijlstra
2020-03-27 21:23 ` [PATCH 08/10] trace: Replace printk and WARN_ON with WARN Jules Irenge
2020-03-27 21:23 ` [PATCH 09/10] kernel/sysctl.c: Replace 1 and 0 by corresponding boolean value Jules Irenge
2020-03-28 21:24 ` Kees Cook
2020-03-27 21:23 ` [PATCH 10/10] trace: Replace printk and WARN_ON with WARN Jules Irenge
2020-03-27 22:51 ` Steven Rostedt
2020-03-28 12:00 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327212358.5752-3-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jbi.octave@example.com \
--cc=julia.lawall@lip6.fr \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.