From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ASoC: snd_soc_dai_set_fmt add substream independence.
Date: Sat, 28 Mar 2020 11:44:01 +0800 [thread overview]
Message-ID: <202003281128.KAgzaEeD%lkp@intel.com> (raw)
In-Reply-To: <20200328015831.6230-1-flatmax@flatmax.org>
[-- Attachment #1: Type: text/plain, Size: 10860 bytes --]
Hi Matt,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v5.6-rc7]
[cannot apply to asoc/for-next next-20200327]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Matt-Flax/ASoC-snd_soc_dai_set_fmt-add-substream-independence/20200328-102100
base: 16fbf79b0f83bc752cee8589279f1ebfe57b3b6e
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> sound/soc/sh/fsi.c:1701:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = fsi_dai_set_fmt,
^~~~~~~~~~~~~~~
sound/soc/sh/fsi.c:1701:13: note: (near initialization for 'fsi_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/sh/rcar/core.c:1051:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = rsnd_soc_dai_set_fmt,
^~~~~~~~~~~~~~~~~~~~
sound/soc/sh/rcar/core.c:1051:13: note: (near initialization for 'rsnd_soc_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/sirf/sirf-usp.c:267:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = sirf_usp_pcm_set_dai_fmt,
^~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/sirf/sirf-usp.c:267:13: note: (near initialization for 'sirf_usp_pcm_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/sti/uniperif_player.c:1043:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = sti_uniperiph_dai_set_fmt,
^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/sti/uniperif_player.c:1043:14: note: (near initialization for 'uni_player_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/sti/uniperif_reader.c:406:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = sti_uniperiph_dai_set_fmt,
^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/sti/uniperif_reader.c:406:14: note: (near initialization for 'uni_reader_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/stm/stm32_sai_sub.c:1227:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = stm32_sai_set_dai_fmt,
^~~~~~~~~~~~~~~~~~~~~
sound/soc/stm/stm32_sai_sub.c:1227:13: note: (near initialization for 'stm32_sai_pcm_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/stm/stm32_i2s.c:741:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = stm32_i2s_set_dai_fmt,
^~~~~~~~~~~~~~~~~~~~~
sound/soc/stm/stm32_i2s.c:741:13: note: (near initialization for 'stm32_i2s_pcm_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/sunxi/sun4i-i2s.c:846:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = sun4i_i2s_set_fmt,
^~~~~~~~~~~~~~~~~
sound/soc/sunxi/sun4i-i2s.c:846:13: note: (near initialization for 'sun4i_i2s_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/sunxi/sun8i-codec.c:489:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = sun8i_set_fmt,
^~~~~~~~~~~~~
sound/soc/sunxi/sun8i-codec.c:489:13: note: (near initialization for 'sun8i_codec_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/tegra/tegra20_i2s.c:241:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = tegra20_i2s_set_fmt,
^~~~~~~~~~~~~~~~~~~
sound/soc/tegra/tegra20_i2s.c:241:13: note: (near initialization for 'tegra20_i2s_dai_ops.set_fmt')
cc1: some warnings being treated as errors
--
>> sound/soc/tegra/tegra30_i2s.c:296:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.set_fmt = tegra30_i2s_set_fmt,
^~~~~~~~~~~~~~~~~~~
sound/soc/tegra/tegra30_i2s.c:296:13: note: (near initialization for 'tegra30_i2s_dai_ops.set_fmt')
cc1: some warnings being treated as errors
..
vim +/snd_soc_dai_set_fmt +1515 sound/soc/soc-core.c
2eea392d0a28a0 Jarkko Nikula 2010-11-25 1457
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1458 /**
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1459 * snd_soc_runtime_set_dai_fmt() - Change DAI link format for a ASoC runtime
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1460 * @rtd: The runtime for which the DAI link format should be changed
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1461 * @dai_fmt: The new DAI link format
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1462 *
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1463 * This function updates the DAI link format for all DAIs connected to the DAI
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1464 * link for the specified runtime.
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1465 *
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1466 * Note: For setups with a static format set the dai_fmt field in the
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1467 * corresponding snd_dai_link struct instead of using this function.
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1468 *
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1469 * Returns 0 on success, otherwise a negative error code.
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1470 */
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1471 int snd_soc_runtime_set_dai_fmt(struct snd_soc_pcm_runtime *rtd,
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1472 unsigned int dai_fmt)
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1473 {
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1474 struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
0b7990e38971da Kuninori Morimoto 2018-09-03 1475 struct snd_soc_dai *codec_dai;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1476 unsigned int i;
2e8b7dfc808873 Matt Flax 2020-03-28 1477 int ret, stream;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1478
0b7990e38971da Kuninori Morimoto 2018-09-03 1479 for_each_rtd_codec_dai(rtd, i, codec_dai) {
2e8b7dfc808873 Matt Flax 2020-03-28 1480 int stream = 0;
2e8b7dfc808873 Matt Flax 2020-03-28 1481 ret = snd_soc_dai_set_fmt(codec_dai, dai_fmt, stream);
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1482 if (ret != 0 && ret != -ENOTSUPP) {
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1483 dev_warn(codec_dai->dev,
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1484 "ASoC: Failed to set DAI format: %d\n", ret);
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1485 return ret;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1486 }
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1487 }
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1488
2c7b696a7589ab Marcel Ziswiler 2018-10-18 1489 /*
2c7b696a7589ab Marcel Ziswiler 2018-10-18 1490 * Flip the polarity for the "CPU" end of a CODEC<->CODEC link
2c7b696a7589ab Marcel Ziswiler 2018-10-18 1491 * the component which has non_legacy_dai_naming is Codec
2c7b696a7589ab Marcel Ziswiler 2018-10-18 1492 */
999f7f5af8eb77 Kuninori Morimoto 2018-05-08 1493 if (cpu_dai->component->driver->non_legacy_dai_naming) {
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1494 unsigned int inv_dai_fmt;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1495
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1496 inv_dai_fmt = dai_fmt & ~SND_SOC_DAIFMT_MASTER_MASK;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1497 switch (dai_fmt & SND_SOC_DAIFMT_MASTER_MASK) {
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1498 case SND_SOC_DAIFMT_CBM_CFM:
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1499 inv_dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1500 break;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1501 case SND_SOC_DAIFMT_CBM_CFS:
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1502 inv_dai_fmt |= SND_SOC_DAIFMT_CBS_CFM;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1503 break;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1504 case SND_SOC_DAIFMT_CBS_CFM:
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1505 inv_dai_fmt |= SND_SOC_DAIFMT_CBM_CFS;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1506 break;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1507 case SND_SOC_DAIFMT_CBS_CFS:
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1508 inv_dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1509 break;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1510 }
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1511
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1512 dai_fmt = inv_dai_fmt;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1513 }
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1514
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 @1515 ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt);
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1516 if (ret != 0 && ret != -ENOTSUPP) {
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1517 dev_warn(cpu_dai->dev,
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1518 "ASoC: Failed to set DAI format: %d\n", ret);
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1519 return ret;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1520 }
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1521
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1522 return 0;
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1523 }
ddaca25aa4dade Lars-Peter Clausen 2015-01-08 1524 EXPORT_SYMBOL_GPL(snd_soc_runtime_set_dai_fmt);
ce64c8b9cf5be2 Lars-Peter Clausen 2015-01-06 1525
:::::: The code at line 1515 was first introduced by commit
:::::: ce64c8b9cf5be2a93508af4667110dbe90904557 ASoC: Add helper function for changing the DAI link format
:::::: TO: Lars-Peter Clausen <lars@metafoo.de>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 71455 bytes --]
next prev parent reply other threads:[~2020-03-28 3:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 1:58 [PATCH] ASoC: snd_soc_dai_set_fmt add substream independence Matt Flax
2020-03-28 3:31 ` kbuild test robot
2020-03-28 3:44 ` kbuild test robot [this message]
2020-03-30 10:32 ` Mark Brown
2020-03-30 12:28 ` Matt Flax
2020-03-30 16:31 ` Mark Brown
2020-03-31 7:40 ` Matt Flax
2020-03-31 11:13 ` Mark Brown
2020-03-31 11:52 ` Matt Flax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003281128.KAgzaEeD%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.