From: Jonathan Cameron <jic23@kernel.org>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
daniel.baluta@gmail.com, kieran.bingham@ideasonboard.com,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
Date: Sat, 28 Mar 2020 13:24:12 +0000 [thread overview]
Message-ID: <20200328132412.6f6368f2@archlinux> (raw)
In-Reply-To: <20200322185350.GA12377@deeUbuntu>
On Mon, 23 Mar 2020 00:23:54 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:
> Reformat pointer initialization to make it more readable as per the
> coding standards. Problem detected by checkpatch.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Check your cc list before sending and make sure it makes sense.
Driver has nothing to do with IIO and half your list are from
IIO MAINTAINERS entry.
> ---
>
> Changes since v1:
> - Correct commit message and description as advised vy Stefano. Its
> pointer initialization and not declaration as mentioned earlier.
>
> drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 569e27b824c8..52826fad6f42 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
> if (r < 0)
> goto fail_return_bufs;
>
> -
> if (!imgu_all_nodes_streaming(imgu, node))
> return 0;
>
> @@ -1013,8 +1012,9 @@ static const struct v4l2_ioctl_ops imgu_v4l2_meta_ioctl_ops = {
>
> static int imgu_sd_s_ctrl(struct v4l2_ctrl *ctrl)
> {
> - struct imgu_v4l2_subdev *imgu_sd =
> - container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> + struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> + struct imgu_v4l2_subdev,
> + ctrl_handler);
> struct imgu_device *imgu = v4l2_get_subdevdata(&imgu_sd->subdev);
> struct device *dev = &imgu->pci_dev->dev;
>
next prev parent reply other threads:[~2020-03-28 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 18:53 [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Deepak R Varma
2020-03-22 19:17 ` [Outreachy kernel] " Julia Lawall
2020-03-22 23:35 ` Andy Shevchenko
2020-03-23 15:17 ` DEEPAK VARMA
2020-03-25 20:48 ` DEEPAK VARMA
2020-03-28 13:24 ` Jonathan Cameron [this message]
2020-03-28 20:32 ` DEEPAK VARMA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328132412.6f6368f2@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.