From: Wei Liu <wl@xen.org>
To: Simran Singhal <singhalsimran0@gmail.com>
Cc: xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen/x86: Compress lines for immediate return
Date: Sun, 29 Mar 2020 14:46:57 +0100 [thread overview]
Message-ID: <20200329134657.zdbanqkhzmtmurue@debian> (raw)
In-Reply-To: <20200329061608.GA29651@simran-Inspiron-5558>
On Sun, Mar 29, 2020 at 11:46:08AM +0530, Simran Singhal wrote:
> diff --git a/xen/arch/x86/oprofile/op_model_athlon.c b/xen/arch/x86/oprofile/op_model_athlon.c
> index 5c48f868ae..2bc0d04a1f 100644
> --- a/xen/arch/x86/oprofile/op_model_athlon.c
> +++ b/xen/arch/x86/oprofile/op_model_athlon.c
> @@ -343,9 +343,8 @@ static int athlon_check_ctrs(unsigned int const cpu,
> }
> }
>
> - ovf = handle_ibs(mode, regs);
> /* See op_model_ppro.c */
> - return ovf;
> + return handle_ibs(mode, regs);
Hmm... ovf can potentially be set in the for loop before this hunk, but
then immediately get overwritten by the function call. I bet the ovf = 1
line is the reason why you didn't remove ovf out right.
I think you can perhaps just remove ovf here. It would make any
difference logically.
Other changes look correct to me.
Wei.
next prev parent reply other threads:[~2020-03-29 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 6:16 [Xen-devel] [PATCH] xen/x86: Compress lines for immediate return Simran Singhal
2020-03-29 13:46 ` Wei Liu [this message]
2020-03-29 13:48 ` Wei Liu
2020-03-30 11:28 ` Simran Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200329134657.zdbanqkhzmtmurue@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=singhalsimran0@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.