From: Leon Romanovsky <leon@kernel.org>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
linux-um <linux-um@lists.infradead.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>
Subject: Re: [PATCH 1/2] um: Don't overwrite ethtool driver version
Date: Mon, 30 Mar 2020 10:22:48 +0300 [thread overview]
Message-ID: <20200330072248.GH2454444@unreal> (raw)
In-Reply-To: <CAFLxGvxem_z-0sX4THYzqZnEW0xXjsXW1zP99VZeDRJXvZYjvQ@mail.gmail.com>
On Sun, Mar 29, 2020 at 11:38:10PM +0200, Richard Weinberger wrote:
> On Thu, Feb 20, 2020 at 8:35 PM Anton Ivanov
> <anton.ivanov@cambridgegreys.com> wrote:
> >
> >
> >
> > On 20/02/2020 08:40, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@mellanox.com>
> > >
> > >
> > > In-tree drivers don't need to manage internal version because
> > > they are aligned to the global Linux kernel version, which is
> > > reported by default with "ethtool -i".
> > >
> > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > > ---
> > > arch/um/drivers/net_kern.c | 1 -
> > > arch/um/drivers/vector_kern.c | 2 --
> > > 2 files changed, 3 deletions(-)
> > >
> > > diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
> > > index 35ebeebfc1a8..af07733c2dc8 100644
> > > --- a/arch/um/drivers/net_kern.c
> > > +++ b/arch/um/drivers/net_kern.c
> > > @@ -266,7 +266,6 @@ static void uml_net_get_drvinfo(struct net_device *dev,
> > > struct ethtool_drvinfo *info)
> > > {
> > > strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver));
> > > - strlcpy(info->version, "42", sizeof(info->version));
> > > }
> > >
> > > static const struct ethtool_ops uml_net_ethtool_ops = {
> > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> > > index 0ff86391f77d..9693dfca7651 100644
> > > --- a/arch/um/drivers/vector_kern.c
> > > +++ b/arch/um/drivers/vector_kern.c
> > > @@ -46,7 +46,6 @@
> > >
> > >
> > > #define DRIVER_NAME "uml-vector"
> > > -#define DRIVER_VERSION "01"
> > > struct vector_cmd_line_arg {
> > > struct list_head list;
> > > int unit;
> > > @@ -1378,7 +1377,6 @@ static void vector_net_get_drvinfo(struct net_device *dev,
> > > struct ethtool_drvinfo *info)
> > > {
> > > strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver));
> > > - strlcpy(info->version, DRIVER_VERSION, sizeof(info->version));
> > > }
> > >
> > > static int vector_net_load_bpf_flash(struct net_device *dev,
> > > --
> > > 2.24.1
> > >
> > >
> >
> > Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>
> Both patches applied, thanks!
Thanks for taking care.
>
> --
> Thanks,
> //richard
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-03-30 7:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:40 [PATCH 0/2] Remove dead code and driver version Leon Romanovsky
2020-02-20 8:40 ` [PATCH 1/2] um: Don't overwrite ethtool " Leon Romanovsky
2020-02-20 19:35 ` Anton Ivanov
2020-03-29 21:38 ` Richard Weinberger
2020-03-30 7:22 ` Leon Romanovsky [this message]
2020-02-20 8:40 ` [PATCH 2/2] um: Delete never executed timer Leon Romanovsky
2020-02-20 19:36 ` Anton Ivanov
2020-02-20 19:35 ` [PATCH 0/2] Remove dead code and driver version Anton Ivanov
2020-02-23 10:51 ` Leon Romanovsky
2020-02-23 19:58 ` Anton Ivanov
2020-02-24 16:45 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330072248.GH2454444@unreal \
--to=leon@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=jdike@addtoit.com \
--cc=linux-um@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.