From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFBEC43331 for ; Mon, 30 Mar 2020 08:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00BC720732 for ; Mon, 30 Mar 2020 08:50:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="gVLOl7bP"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="18N07cye" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729538AbgC3IuL (ORCPT ); Mon, 30 Mar 2020 04:50:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53067 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbgC3IuL (ORCPT ); Mon, 30 Mar 2020 04:50:11 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4ADB35C07F9; Mon, 30 Mar 2020 04:50:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 30 Mar 2020 04:50:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=TAc9BqbPJQRkYjEeHp/KesbVTGc OThwXtcE4IBNbdjQ=; b=gVLOl7bPHHI6DCmUw5/tJyzpH8CPXfxKWL0Nh64mV+l cbXe/1OnMczhkDBnszyc2jWCHmudyl6FD72IVb9SOln1CcSiurOFAy1u5WLGHXrc 6agBrZQl3f4p4SHYJzM/yXoZhe4/VG7mR6OqZeBQl2i1Iy5IBbgGOrYACXArfBAF QEFQStuieBrF2lcVMOiABtQJ2lmnvmZS3rF6SKyk8ce0z/bQaMCzDE0arDwhP61r /aZRfhGh0GZXKYoSBlXODbCUY/hVV/BxAtLB3kJ7hNFttxlUat8/A1CSzNzOr/17 7+EFa5AugOlD+cjlz4dX0ursqjMCkNRCGsDEJJOVJKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TAc9Bq bPJQRkYjEeHp/KesbVTGcOThwXtcE4IBNbdjQ=; b=18N07cyeooU50jb5UTtkaD mFnao8sgAoMn/wCirer+j1qt7ZeFjmRYVqe10Zf07hIfYkzZYtHk/t++bVHE5v/M l4w9ditc02s/MDwRpk0pgjIw7gepq3AJLPnBD/rGAUY5UOlraBAomjxs2bplFM0B 3qFpeq0igTyXkv/pqpNoyeNrFBUNFUPSAW8HXqeYLd94BPLNYK8A8mZo91GCvcD3 iGWZiIfIuFU5dCvTzIIpYJf8uIVzrUUxIfuga93R0GpfgvfvQmcEHXcvdawPBaYh NmHG8ADmfZv8j6SrUGns1e0Hhz3k8kCUfkzthQMgoD60fcpA9ZbgZmwq43ar39oA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeihedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrddutd ejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhr vghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id C89FF306C975; Mon, 30 Mar 2020 04:50:09 -0400 (EDT) Date: Mon, 30 Mar 2020 10:50:07 +0200 From: Greg KH To: Jason Andryuk Cc: stable@vger.kernel.org, Johannes Berg , Luca Coelho , Kalle Valo Subject: Re: Stable request: iwlwifi: mvm: fix non-ACPI function Message-ID: <20200330085007.GA239298@kroah.com> References: <20200329184111.17469-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Mar 29, 2020 at 03:17:32PM -0400, Jason Andryuk wrote: > On Sun, Mar 29, 2020 at 2:41 PM Jason Andryuk wrote: > > > > From: Johannes Berg > > > > commit 7937fd3227055892e169f4b34d21157e57d919e2 upstream. > > > > The code now compiles without ACPI, but there's a warning since > > iwl_mvm_get_ppag_table() isn't used, and iwl_mvm_ppag_init() must > > not unconditionally fail but return success instead. > > > > Signed-off-by: Johannes Berg > > Signed-off-by: Luca Coelho > > Signed-off-by: Kalle Valo > > [Drop hunk removing iwl_mvm_get_ppag_table() since it doesn't exist in > > 5.4] > > Signed-off-by: Jason Andryuk > > --- > > A 5.4 kernel can't "up" an iwlwifi interface when CONFIG_ACPI=n. > > `wpa_supplicant` or `ip link set wlan0 up` return "No such file or > > directory". The non-acpi stub iwl_mvm_ppag_init() always returns > > -ENOENT which means iwl_mvm_up() always fails. Backporting the commit > > lets iwl_mvm_up() succeed. > > This stable request is only applicable to 5.4 > > Fixes 6ce1e5c0c207 "iwlwifi: support per-platform antenna gain" Now queued up, thanks. greg k-h