From: Stefano Brivio <sbrivio@redhat.com>
To: Sam Muhammed <jane.pnx9@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [PATCH 1/4] Staging: rtl8192u: ieee80211: Use netdev_dbg() for debug messages.
Date: Mon, 30 Mar 2020 09:59:24 +0200 [thread overview]
Message-ID: <20200330095924.4824f330@elisabeth> (raw)
In-Reply-To: <84dc7e33954509457efce2a35fb293e631845a96.1585233434.git.jane.pnx9@gmail.com>
On Thu, 26 Mar 2020 11:02:35 -0400
Sam Muhammed <jane.pnx9@gmail.com> wrote:
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> @@ -436,7 +436,7 @@ int ieee80211_wx_set_encode(struct ieee80211_device *ieee,
> if (ieee->reset_on_keychange &&
> ieee->iw_mode != IW_MODE_INFRA &&
> ieee->reset_port && ieee->reset_port(dev)) {
> - printk(KERN_DEBUG "%s: reset_port failed\n", dev->name);
> + netdev_dbg(ieee->dev, "reset_port failed\n");
I guess you should stick to 'dev' here -- it's the same as ieee->dev,
but reset_port() is invoked on 'dev', so it would be less confusing.
--
Stefano
next prev parent reply other threads:[~2020-03-30 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:02 [PATCH 0/4] Staging: rtl8192u: ieee80211: Replace printk(KERN_<LEVEL> ...) with netdev_*() family Sam Muhammed
2020-03-26 15:02 ` [PATCH 1/4] Staging: rtl8192u: ieee80211: Use netdev_dbg() for debug messages Sam Muhammed
2020-03-30 7:59 ` Stefano Brivio [this message]
2020-03-30 13:01 ` [Outreachy kernel] " Sam Muhammed
2020-03-30 13:50 ` Stefano Brivio
2020-03-26 15:02 ` [PATCH 2/4] Staging: rtl8192u: ieee80211: Use netdev_warn() for network devices Sam Muhammed
2020-03-26 15:02 ` [PATCH 3/4] Staging: rtl8192u: ieee80211: Use netdev_info() with " Sam Muhammed
2020-03-26 15:02 ` [PATCH 4/4] Staging: rtl8192u: ieee80211: Use netdev_alert() Sam Muhammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330095924.4824f330@elisabeth \
--to=sbrivio@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jane.pnx9@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.